From patchwork Fri Mar 11 09:09:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peppe CAVALLARO X-Patchwork-Id: 8563611 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2BA8C9F9A0 for ; Fri, 11 Mar 2016 09:10:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2496220259 for ; Fri, 11 Mar 2016 09:10:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC10620211 for ; Fri, 11 Mar 2016 09:10:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aeJ5b-0002qI-5G; Fri, 11 Mar 2016 09:10:31 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aeJ5X-0001rb-PD; Fri, 11 Mar 2016 09:10:29 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id u2B94RIP011814; Fri, 11 Mar 2016 10:09:57 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 21j1gngqg5-1 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 11 Mar 2016 10:09:57 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 9B44048; Fri, 11 Mar 2016 09:09:51 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas22.st.com [10.75.90.92]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2538210D5; Fri, 11 Mar 2016 09:09:51 +0000 (GMT) Received: from [10.52.139.42] (10.52.139.42) by Webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Mar 2016 10:09:51 +0100 Message-ID: <56E28B5D.6000708@st.com> Date: Fri, 11 Mar 2016 10:09:49 +0100 From: Giuseppe CAVALLARO User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Dinh Nguyen , Tomeu Vizoso Subject: Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement References: <1457294038-14243-1-git-send-email-afaerber@suse.de> <56DD7172.4000707@suse.de> <2714888.1DdqvJZ8cb@diego> <56DD7593.5060003@suse.de> <56DD8176.2080603@st.com> <56DD8FBE.9010200@suse.de> <56DD99A4.5030004@st.com> <56DDA26C.3050301@suse.de> <56DDA3D5.3090209@st.com> <56DDB749.1020808@suse.de> <56DE7E1D.5070508@st.com> <56DFE55B.2090806@st.com> <56DFE64B.8060606@st.com> <56DFF253.9050208@st.com> <56DFFA9E.7060602@st.com> <56E033C8.40506@st.com> <56E038CE.606@st.com> <56E13AAB.2080900@st.com> In-Reply-To: X-Originating-IP: [10.52.139.42] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-03-11_04:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160311_011028_158997_9837EB53 X-CRM114-Status: GOOD ( 19.52 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , netdev@vger.kernel.org, LKML , =?UTF-8?B?RnJhbmsgU2Now6RmZXI=?= , "open list:ARM/Rockchip SoC..." , Gabriel Fernandez , Fabrice GASNIER , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , LAKML , Alexandre TORGUE Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 3/10/2016 5:47 PM, Dinh Nguyen wrote: > On Thu, Mar 10, 2016 at 3:13 AM, Giuseppe CAVALLARO > wrote: >> On 3/9/2016 5:31 PM, Dinh Nguyen wrote: >>> >>> On Wed, Mar 9, 2016 at 8:53 AM, Giuseppe CAVALLARO >>> wrote: >>>> >>>> Hi Tomeu, Dinh, Andreas >>>> >>>> I need a sum and help from you to go ahead on the >>>> tx timeout. >>>> >>>> The "stmmac: MDIO fixes" seems to be the candidate to >>>> fix the phy connection and I will send the V2 asap (Andreas' comment). >>>> >>>> So, supposing the probe is ok and phy is connected, >>>> I need your input ... >>>> >>>> Tomeu: after revering the 0e80bdc9a72d (stmmac: first frame >>>> prep at the end of xmit routine) the network is >>>> not stable and there is a timeout after a while. >>>> The box has 3.50 with normal desc settings. >>>> >>>> Dinh: the network is ok, I wonder if you can share a boot >>>> log just to understand if the normal or enhanced >>>> descriptors are used. >>>> >>> >>> Here it is: >> >> ... >>> >>> [ 0.850523] stmmac - user ID: 0x10, Synopsys ID: 0x37 >>> [ 0.855570] Ring mode enabled >>> [ 0.858611] DMA HW capability register supported >>> [ 0.863128] Enhanced/Alternate descriptors >>> [ 0.867482] Enabled extended descriptors >>> [ 0.871482] RX Checksum Offload Engine supported (type 2) >>> [ 0.876948] TX Checksum insertion supported >>> [ 0.881204] Enable RX Mitigation via HW Watchdog Timer >>> [ 0.886863] socfpga-dwmac ff702000.ethernet eth0: No MDIO subnode found >>> [ 0.899090] libphy: stmmac: probed >>> [ 0.902484] eth0: PHY ID 00221611 at 4 IRQ POLL (stmmac-0:04) active >> >> >> Thx Dinh, so you are using the Enhanced/Alternate descriptors >> I am debugging on my side on a setup with normal descriptors, I let you >> know >> > > Doesn't the printout "Enhanced/Alternate descriptors" mean that I'm using > Enhanced/Alternate descriptors? yes this means that you have the Databook 3.70a and, from the HW capability register, the driver will use the Enhanced/Alternate descriptors. This is the same HW I am using on my side where the stmmac is working fine. In the case where it is failing on net-next, although on Databook 3.50a, the HW capability register says that there is no enhanced descriptors and the driver uses the normal ones. Tomeu, I kindly ask you to try the patch attached. I found a bug on Tx path for normal descriptors. Please let me know if this help. Also let me know if we actually need to revert the 0e80bdc9a72d. I am trying to find some HW where test the normal descriptors to speed-up the tests on my side directly. Let me know and thx in advance. Regards, Peppe > > Dinh > From ed3e38befc5500e05f46e1d52ea20a0b8d3829f3 Mon Sep 17 00:00:00 2001 From: Giuseppe Cavallaro Date: Thu, 10 Mar 2016 14:57:48 +0100 Subject: [PATCH (linux-sti-4.1)] stmmac: fix tx prepare for normal desc This patch fixes a bug inside when use the normal descriptors. While preparing the tx descriptor the frame size was not properly set. Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/norm_desc.c b/drivers/net/ethernet/stmicro/stmmac/norm_desc.c index e13228f..432b3f1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/norm_desc.c +++ b/drivers/net/ethernet/stmicro/stmmac/norm_desc.c @@ -197,13 +197,15 @@ static void ndesc_prepare_tx_desc(struct dma_desc *p, int is_fs, int len, bool csum_flag, int mode, bool tx_own, bool ls) { - unsigned int tdes1 = p->des1; + unsigned int tdes1; if (mode == STMMAC_CHAIN_MODE) norm_set_tx_desc_len_on_chain(p, len); else norm_set_tx_desc_len_on_ring(p, len); + tdes1 = p->des1; + if (is_fs) tdes1 |= TDES1_FIRST_SEGMENT; else -- 1.7.4.4