| Message ID | AM3PR03MB0966818FAAAE6192FF4ED11AAC7D0@AM3PR03MB0966.eurprd03.prod.outlook.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs | expand |
Hi Jonas, Thank you for the patch. On Wed, Feb 20, 2019 at 07:52:31AM +0000, Jonas Karlman wrote: > The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > also been identified as needing this workaround with a single iteration. > > Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version") > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> This makes me wonder if we have any device at all that doesn't need the workaround... The HDMI encoder in R-Car SoCs doesn't seem to require it, but it reports the same version number as on other SoCs that require the workaround, and enabling it doesn't seem to affect R-Car adversely. Should we thus enable it unconditionally ? Input from Synopsys would be useful. > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 64c3cf027518..14223c0ee784 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > * iteration for others. > * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing > * the workaround with a single iteration. > + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > + * been identified as needing the workaround with a single iteration. > */ > > switch (hdmi->version) { > @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > break; > case 0x131a: > case 0x132a: > + case 0x200a: > case 0x201a: > + case 0x211a: > case 0x212a: > count = 1; > break;
Am Mittwoch, 20. Februar 2019, 08:52:31 CET schrieb Jonas Karlman: > The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > also been identified as needing this workaround with a single iteration. > > Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version") > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> On rk3328 and rk3288 Tested-by: Heiko Stueber <heiko@sntech.de> If I remember correctly, this should remove the pink line that shows up sometimes. With this patch I couldn't see it anymore during multiple reboots. Heiko > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 64c3cf027518..14223c0ee784 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > * iteration for others. > * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing > * the workaround with a single iteration. > + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > + * been identified as needing the workaround with a single iteration. > */ > > switch (hdmi->version) { > @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > break; > case 0x131a: > case 0x132a: > + case 0x200a: > case 0x201a: > + case 0x211a: > case 0x212a: > count = 1; > break; >
On 20.02.2019 08:52, Jonas Karlman wrote: > The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > also been identified as needing this workaround with a single iteration. > > Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version") > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> Queued to drm-misc-fixes. -- Regards Andrzej > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 64c3cf027518..14223c0ee784 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > * iteration for others. > * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing > * the workaround with a single iteration. > + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > + * been identified as needing the workaround with a single iteration. > */ > > switch (hdmi->version) { > @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > break; > case 0x131a: > case 0x132a: > + case 0x200a: > case 0x201a: > + case 0x211a: > case 0x212a: > count = 1; > break;
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 64c3cf027518..14223c0ee784 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) * iteration for others. * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing * the workaround with a single iteration. + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have + * been identified as needing the workaround with a single iteration. */ switch (hdmi->version) { @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) break; case 0x131a: case 0x132a: + case 0x200a: case 0x201a: + case 0x211a: case 0x212a: count = 1; break;
The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have also been identified as needing this workaround with a single iteration. Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version") Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++ 1 file changed, 4 insertions(+)