diff mbox series

arm64: dts: rockchip: Disable display for NanoPi R2S

Message ID c4553dfad1ad6792c4f22454c135ff55de77e2d6.1611186099.git.robin.murphy@arm.com (mailing list archive)
State New
Headers show
Series arm64: dts: rockchip: Disable display for NanoPi R2S | expand

Commit Message

Robin Murphy Jan. 20, 2021, 11:41 p.m. UTC
NanoPi R2S is headless, so rightly does not enable any of the display
interface hardware, which currently provokes an obnoxious error in the
boot log from the fake DRM device failing to find anything to bind to.
It probably isn't *too* hard to obviate the fake device shenanigans
entirely with a bit of driver reshuffling, but for now let's just
disable it here to shut up the spurious error.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
 arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Chen-Yu Tsai Jan. 21, 2021, 5:21 a.m. UTC | #1
On Thu, Jan 21, 2021 at 7:42 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> NanoPi R2S is headless, so rightly does not enable any of the display
> interface hardware, which currently provokes an obnoxious error in the
> boot log from the fake DRM device failing to find anything to bind to.
> It probably isn't *too* hard to obviate the fake device shenanigans
> entirely with a bit of driver reshuffling, but for now let's just
> disable it here to shut up the spurious error.

Maybe we should just drop the error message from the driver?

I should probably send a similar patch for the ROCK Pi E. :/

> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> index 2ee07d15a6e3..1eecad724f04 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> @@ -114,6 +114,10 @@
>         cpu-supply = <&vdd_arm>;
>  };
>
> +&display_subsystem {
> +       status = "disabled";
> +};
> +
>  &gmac2io {
>         assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
>         assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Heiko Stübner Jan. 25, 2021, 11:56 p.m. UTC | #2
On Wed, 20 Jan 2021 23:41:39 +0000, Robin Murphy wrote:
> NanoPi R2S is headless, so rightly does not enable any of the display
> interface hardware, which currently provokes an obnoxious error in the
> boot log from the fake DRM device failing to find anything to bind to.
> It probably isn't *too* hard to obviate the fake device shenanigans
> entirely with a bit of driver reshuffling, but for now let's just
> disable it here to shut up the spurious error.

Applied, thanks!

[1/1] arm64: dts: rockchip: Disable display for NanoPi R2S
      commit: 74532de460ec664e5a725507d1b59aa9e4d40776

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
index 2ee07d15a6e3..1eecad724f04 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
@@ -114,6 +114,10 @@ 
 	cpu-supply = <&vdd_arm>;
 };
 
+&display_subsystem {
+	status = "disabled";
+};
+
 &gmac2io {
 	assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
 	assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;