| Message ID | cd0312093fc04a0d13467660bafb2b3a48b29332.1735887742.git.xiaopei01@kylinos.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: dw-rockchip: remove redundant dev_err | expand |
On Fri, Jan 03, 2025 at 03:04:52PM +0800, Pei Xiao wrote: > dev_err is redundant because platform_get_irq_byname() already prints an > error. > > cocci warnings: > drivers/pci/controller/dwc/pcie-dw-rockchip.c:454:2-9:line 454 is > redundant because platform_get_irq() already prints an error > > so remove redundant dev_err. > > Fixes: 8719dbc54668 ("PCI: dw-rockchip: Enumerate endpoints based on dll_link_up irq in the combined sys irq") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202412312343.najrW1Db-lkp@intel.com/ > Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> > --- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index ce4b511bff9b..a9795866e915 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -458,10 +458,8 @@ static int rockchip_pcie_configure_rc(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_rc_sys_irq_thread, > @@ -504,10 +502,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_ep_sys_irq_thread, > -- > 2.25.1 > Reviewed-by: Niklas Cassel <cassel@kernel.org>
On Fri, Jan 03, 2025 at 03:04:52PM +0800, Pei Xiao wrote: > dev_err is redundant because platform_get_irq_byname() already prints an > error. > > cocci warnings: > drivers/pci/controller/dwc/pcie-dw-rockchip.c:454:2-9:line 454 is > redundant because platform_get_irq() already prints an error > > so remove redundant dev_err. > > Fixes: 8719dbc54668 ("PCI: dw-rockchip: Enumerate endpoints based on dll_link_up irq in the combined sys irq") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202412312343.najrW1Db-lkp@intel.com/ > Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> > --- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index ce4b511bff9b..a9795866e915 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -458,10 +458,8 @@ static int rockchip_pcie_configure_rc(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_rc_sys_irq_thread, > @@ -504,10 +502,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_ep_sys_irq_thread, > -- > 2.25.1 > You did not CC: linux-pci. Patches for drivers/pci/controller/dwc/pcie-dw-rockchip.c are merged via the PCI tree. Please send a V2 to the proper list. Kind regards, Niklas
diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c index ce4b511bff9b..a9795866e915 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -458,10 +458,8 @@ static int rockchip_pcie_configure_rc(struct platform_device *pdev, return -ENODEV; irq = platform_get_irq_byname(pdev, "sys"); - if (irq < 0) { - dev_err(dev, "missing sys IRQ resource\n"); + if (irq < 0) return irq; - } ret = devm_request_threaded_irq(dev, irq, NULL, rockchip_pcie_rc_sys_irq_thread, @@ -504,10 +502,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev, return -ENODEV; irq = platform_get_irq_byname(pdev, "sys"); - if (irq < 0) { - dev_err(dev, "missing sys IRQ resource\n"); + if (irq < 0) return irq; - } ret = devm_request_threaded_irq(dev, irq, NULL, rockchip_pcie_ep_sys_irq_thread,
dev_err is redundant because platform_get_irq_byname() already prints an error. cocci warnings: drivers/pci/controller/dwc/pcie-dw-rockchip.c:454:2-9:line 454 is redundant because platform_get_irq() already prints an error so remove redundant dev_err. Fixes: 8719dbc54668 ("PCI: dw-rockchip: Enumerate endpoints based on dll_link_up irq in the combined sys irq") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202412312343.najrW1Db-lkp@intel.com/ Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)