From patchwork Sun Oct 11 21:23:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 11831305 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EAC1E14D5 for ; Sun, 11 Oct 2020 21:25:30 +0000 (UTC) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EE2B2076C for ; Sun, 11 Oct 2020 21:25:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.elisa.tech header.i=@lists.elisa.tech header.b="p4xIl5pC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EE2B2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=bounce+72012+77+4688437+8417402@lists.elisa.tech X-Received: by 127.0.0.2 with SMTP id TC7MYY4689772xEhQr4rCp9d; Sun, 11 Oct 2020 14:25:29 -0700 X-Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.26720.1602451529127749319 for ; Sun, 11 Oct 2020 14:25:29 -0700 X-Received: by mail-wm1-f68.google.com with SMTP id e2so15610329wme.1 for ; Sun, 11 Oct 2020 14:25:28 -0700 (PDT) X-Gm-Message-State: LN0Djs604AFdwt3cPB7Iby2ix4688437AA= X-Google-Smtp-Source: ABdhPJxNEUKo2W9hGeuoPkuyK6LDZibfcvoGmM+X2LpblcY0/MsoiH5sox5Bs66Yf3mxRQU74EO8AQ== X-Received: by 2002:a1c:2e0d:: with SMTP id u13mr7862095wmu.179.1602451527531; Sun, 11 Oct 2020 14:25:27 -0700 (PDT) X-Received: from localhost.localdomain (host-92-5-241-147.as43234.net. [92.5.241.147]) by smtp.gmail.com with ESMTPSA id z17sm8908722wrr.93.2020.10.11.14.25.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Oct 2020 14:25:27 -0700 (PDT) From: "Sudip Mukherjee" To: Jesse Brandeburg , Tony Nguyen , "David S . Miller" , Jakub Kicinski Cc: linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Sudip Mukherjee Subject: [linux-safety] [PATCH] e1000: drop unneeded assignment in e1000_set_itr() Date: Sun, 11 Oct 2020 22:23:26 +0100 Message-Id: <20201011212326.2758-1-sudipm.mukherjee@gmail.com> Precedence: Bulk List-Unsubscribe: Sender: linux-safety@lists.elisa.tech List-Id: Mailing-List: list linux-safety@lists.elisa.tech; contact linux-safety+owner@lists.elisa.tech Delivered-To: mailing list linux-safety@lists.elisa.tech List-Post: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.elisa.tech; q=dns/txt; s=20140610; t=1602451529; bh=sURguwJD3BjJKCZeMxTGYLF2UlltXCyvltBsq1yuppc=; h=Cc:Date:From:Subject:To; b=p4xIl5pCihcGO5c3DRTyNMdf/AFlKQqoZpuvOhY97rB/E+lVoSke4nXB5xV2qXD4Gfi L0biFkM9RxP/JX/Woj0oJejDrHmHROxHSXLQ/yA/4olf7T3/X7dhK1DSJ+huRqClenCXi zLLf+6o0Rtqn6D5eYp3bADbJuITmS0C0//Y= The variable 'current_itr' is assigned to 0 before jumping to 'set_itr_now' but it has not been used after the jump. So, remove the unneeded assignement. Signed-off-by: Sudip Mukherjee Reviewed-by: Lukas Bulwahn --- drivers/net/ethernet/intel/e1000/e1000_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c index 5e28cf4fa2cd..042de276e632 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_main.c +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c @@ -2632,7 +2632,6 @@ static void e1000_set_itr(struct e1000_adapter *adapter) /* for non-gigabit speeds, just fix the interrupt rate at 4000 */ if (unlikely(adapter->link_speed != SPEED_1000)) { - current_itr = 0; new_itr = 4000; goto set_itr_now; }