mbox series

[v2,0/3] soc: samsung: exynos-chipid: be a module!

Message ID 20210919093114.35987-1-krzysztof.kozlowski@canonical.com (mailing list archive)
Headers show
Series soc: samsung: exynos-chipid: be a module! | expand

Message

Krzysztof Kozlowski Sept. 19, 2021, 9:31 a.m. UTC 
Hi,

Changes since v1
================
1. Drop patch 1/2 - exporting soc_device_to_device
2. Add new patches: 1/3 and 3/3.

Question
========

A question - what is the convention for naming modules: underscores '_' or
hyphens '-'?

The C-unit file already uses a hyphen "exynos-chipid.c", so I could
create a module named:
1. exynos_chipid
2. soc-exynos-chipid
3. exynos-chip-id

The Linux device name is "exynos-chipid".

Best regards,
Krzysztof


Krzysztof Kozlowski (3):
  soc: samsung: exynos-chipid: avoid soc_device_to_device()
  soc: samsung: exynos-chipid: convert to a module
  soc: samsung: exynos-chipid: do not enforce built-in

 arch/arm/mach-exynos/Kconfig         |  1 -
 drivers/soc/samsung/Kconfig          |  4 +++-
 drivers/soc/samsung/Makefile         |  3 ++-
 drivers/soc/samsung/exynos-chipid.c  | 14 +++++++++++---
 drivers/soc/samsung/exynos5422-asv.c |  1 +
 5 files changed, 17 insertions(+), 6 deletions(-)

Comments

Alim Akhtar Sept. 19, 2021, 5:32 p.m. UTC | #1 
Hello Krzysztof

On Sun, Sep 19, 2021 at 6:28 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Hi,
>
> Changes since v1
> ================
> 1. Drop patch 1/2 - exporting soc_device_to_device
> 2. Add new patches: 1/3 and 3/3.
>
> Question
> ========
>
> A question - what is the convention for naming modules: underscores '_' or
> hyphens '-'?
>
> The C-unit file already uses a hyphen "exynos-chipid.c", so I could
> create a module named:
> 1. exynos_chipid
> 2. soc-exynos-chipid
> 3. exynos-chip-id
>
> The Linux device name is "exynos-chipid".
>
> Best regards,
> Krzysztof
>
>
> Krzysztof Kozlowski (3):
>   soc: samsung: exynos-chipid: avoid soc_device_to_device()
>   soc: samsung: exynos-chipid: convert to a module
>   soc: samsung: exynos-chipid: do not enforce built-in
>
>  arch/arm/mach-exynos/Kconfig         |  1 -
>  drivers/soc/samsung/Kconfig          |  4 +++-
>  drivers/soc/samsung/Makefile         |  3 ++-
>  drivers/soc/samsung/exynos-chipid.c  | 14 +++++++++++---
>  drivers/soc/samsung/exynos5422-asv.c |  1 +
>  5 files changed, 17 insertions(+), 6 deletions(-)
>
Thanks for the patches. For this series
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

Also tested on exynos7 based platform, so
Tested-by: Alim Akhtar <alim.akhtar@samsung.com>

> --
> 2.30.2
>
Sylwester Nawrocki Sept. 21, 2021, 10:03 a.m. UTC | #2 
On 19.09.2021 11:31, Krzysztof Kozlowski wrote:
> Krzysztof Kozlowski (3):
>    soc: samsung: exynos-chipid: avoid soc_device_to_device()
>    soc: samsung: exynos-chipid: convert to a module
>    soc: samsung: exynos-chipid: do not enforce built-in
> 
>   arch/arm/mach-exynos/Kconfig         |  1 -
>   drivers/soc/samsung/Kconfig          |  4 +++-
>   drivers/soc/samsung/Makefile         |  3 ++-
>   drivers/soc/samsung/exynos-chipid.c  | 14 +++++++++++---
>   drivers/soc/samsung/exynos5422-asv.c |  1 +


For the series:
Reviewed-by: Sylwester Nawrocki <snawrocki@kernel.org>
Tested-by: Sylwester Nawrocki <snawrocki@kernel.org>

I just verified Odroid-XU4 is still booting without the driver
and with the driver as a module. Thanks.
Krzysztof Kozlowski Sept. 29, 2021, 1:58 p.m. UTC | #3 
On Sun, 19 Sep 2021 11:31:11 +0200, Krzysztof Kozlowski wrote:
> Changes since v1
> ================
> 1. Drop patch 1/2 - exporting soc_device_to_device
> 2. Add new patches: 1/3 and 3/3.
> 
> Question
> ========
> 
> [...]

Applied, thanks!

[1/3] soc: samsung: exynos-chipid: avoid soc_device_to_device()
      commit: d1141886c8d72ad77920e6e4b617d366e6e3ee8a
[2/3] soc: samsung: exynos-chipid: convert to a module
      commit: 1e3e559f8d4e5b4c873414078facb35273ecbf4b
[3/3] soc: samsung: exynos-chipid: do not enforce built-in
      commit: 140bbfe7cd4be0aa6543f94d3994e4774b325abc

Best regards,