| Message ID | 20211124184603.3897245-1-john@metanate.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: dw_mmc: start deprecating mshcN aliases | expand |
On Wed, 24 Nov 2021 at 19:46, John Keeping <john@metanate.com> wrote: > > This series is prompted by discussion on a previous patch set [1] but is > a totally different approach and only a partial solution. > > With these patches, the dependency on the mshcN alias is totally removed > from dw_mmc-hi3798cv200 and dw_mmc-rockchip and dw_mmc-exynos moves > towards being able to consider the mshcN aliases deprecated. > > I haven't changed dw_mci_hi6220_caps here, although it looks like it's > possible to apply MMC_CAP_CMD23 to all controllers there with no change > in behaviour as the final entry is SDIO for which CMD23 is not > applicable IIUC. But I'm not familiar with that hardware and don't feel > confident making that change. > > [1] https://lore.kernel.org/all/20211116190244.1417591-1-john@metanate.com/ > > John Keeping (4): > mmc: dw_mmc: add common capabilities to replace caps > mmc: dw_mmc: hi3798cv200: use common_caps > mmc: dw_mmc: rockchip: use common_caps > mmc: dw_mmc: exynos: use common_caps > > drivers/mmc/host/dw_mmc-exynos.c | 9 +++++---- > drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +-------- > drivers/mmc/host/dw_mmc-rockchip.c | 11 +---------- > drivers/mmc/host/dw_mmc.c | 3 +++ > drivers/mmc/host/dw_mmc.h | 3 +++ > 5 files changed, 13 insertions(+), 22 deletions(-) > > -- > 2.34.0 > This looks good to me, I intend to apply this later this week, unless objections of course. In the meantime, I will continue to look at what we can do to resolve the exynos/k3 issues around this. Kind regards Uffe
On Mittwoch, 24. November 2021 19:45:58 CET John Keeping wrote: > This series is prompted by discussion on a previous patch set [1] but is > a totally different approach and only a partial solution. > > With these patches, the dependency on the mshcN alias is totally removed > from dw_mmc-hi3798cv200 and dw_mmc-rockchip and dw_mmc-exynos moves > towards being able to consider the mshcN aliases deprecated. > > I haven't changed dw_mci_hi6220_caps here, although it looks like it's > possible to apply MMC_CAP_CMD23 to all controllers there with no change > in behaviour as the final entry is SDIO for which CMD23 is not > applicable IIUC. But I'm not familiar with that hardware and don't feel > confident making that change. > > [1] https://lore.kernel.org/all/20211116190244.1417591-1-john@metanate.com/ > > John Keeping (4): > mmc: dw_mmc: add common capabilities to replace caps > mmc: dw_mmc: hi3798cv200: use common_caps > mmc: dw_mmc: rockchip: use common_caps > mmc: dw_mmc: exynos: use common_caps > > drivers/mmc/host/dw_mmc-exynos.c | 9 +++++---- > drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +-------- > drivers/mmc/host/dw_mmc-rockchip.c | 11 +---------- > drivers/mmc/host/dw_mmc.c | 3 +++ > drivers/mmc/host/dw_mmc.h | 3 +++ > 5 files changed, 13 insertions(+), 22 deletions(-) > > For rockchip: Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com> Tested on a rk3566 with no obvious issues arising. Regards, Nicolas Frattaroli
On Wed, 24 Nov 2021 at 20:24, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Wed, 24 Nov 2021 at 19:46, John Keeping <john@metanate.com> wrote: > > > > This series is prompted by discussion on a previous patch set [1] but is > > a totally different approach and only a partial solution. > > > > With these patches, the dependency on the mshcN alias is totally removed > > from dw_mmc-hi3798cv200 and dw_mmc-rockchip and dw_mmc-exynos moves > > towards being able to consider the mshcN aliases deprecated. > > > > I haven't changed dw_mci_hi6220_caps here, although it looks like it's > > possible to apply MMC_CAP_CMD23 to all controllers there with no change > > in behaviour as the final entry is SDIO for which CMD23 is not > > applicable IIUC. But I'm not familiar with that hardware and don't feel > > confident making that change. > > > > [1] https://lore.kernel.org/all/20211116190244.1417591-1-john@metanate.com/ > > > > John Keeping (4): > > mmc: dw_mmc: add common capabilities to replace caps > > mmc: dw_mmc: hi3798cv200: use common_caps > > mmc: dw_mmc: rockchip: use common_caps > > mmc: dw_mmc: exynos: use common_caps > > > > drivers/mmc/host/dw_mmc-exynos.c | 9 +++++---- > > drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +-------- > > drivers/mmc/host/dw_mmc-rockchip.c | 11 +---------- > > drivers/mmc/host/dw_mmc.c | 3 +++ > > drivers/mmc/host/dw_mmc.h | 3 +++ > > 5 files changed, 13 insertions(+), 22 deletions(-) > > > > -- > > 2.34.0 > > > > This looks good to me, I intend to apply this later this week, unless > objections of course. > > In the meantime, I will continue to look at what we can do to resolve > the exynos/k3 issues around this. Let's consider additional changes to be on top of this, as this is certainly a nice step forward. So, applied for next, thanks! Kind regards Uffe