| Message ID | 20230128133151.29471-1-henrik@grimler.se (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: dts: add mmc aliases for Exynos devices | expand |
On 28.01.2023 14:31, Henrik Grimler wrote: > It is convenient to have fixed mmcblk numbering of the eMMC and sdcard > so that assigned numbers will not change from boot-to-boot or > depending on if storage devices are actually attached or not. > > Anton Bambura has done the work for the chromebooks while I have > looked at the other devices. On the chromebooks, mmc0 is used for > eMMC and mmc1 for sdcard, while mmc0 is used for eMMC and mmc2 for > sdcard on the other boards, simply because Anton and I had different > preferences. > > Also remove mshc aliases, as they should not be needed after [1] as > I understand it. Thanks for this patchset. Long time ago I've tried to submit something similar, but that time it has been rejected: https://lore.kernel.org/all/20201105114804.18326-1-m.szyprowski@samsung.com/ I hope that the mshc alias removal will help here. BTW, similar patchset is needed for arch/arm64/boot/dts/exynos > [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com > > --- > > Changes since v1: > * Move mshc alias cleanup to a separate commit > * Use mmc0 and mmc1 (instead of mmc0 and mmc2) for eMMC and sdcard on > chromebooks > * Address Krzysztof's review comments: > - Make changes per device rather than in soc dtsi > > > Henrik Grimler (2): > ARM: dts: exynos: drop mshc aliases > ARM: dts: exynos: add mmc aliases > > arch/arm/boot/dts/exynos3250-artik5-eval.dts | 5 +++++ > arch/arm/boot/dts/exynos3250-artik5.dtsi | 5 +++++ > arch/arm/boot/dts/exynos3250-monk.dts | 1 + > arch/arm/boot/dts/exynos3250-rinato.dts | 2 ++ > arch/arm/boot/dts/exynos3250.dtsi | 3 --- > arch/arm/boot/dts/exynos4210-i9100.dts | 6 ++++++ > arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++ > arch/arm/boot/dts/exynos4210-smdkv310.dts | 4 ++++ > arch/arm/boot/dts/exynos4210-trats.dts | 6 ++++++ > arch/arm/boot/dts/exynos4210-universal_c210.dts | 6 ++++++ > arch/arm/boot/dts/exynos4412-itop-elite.dts | 5 +++++ > arch/arm/boot/dts/exynos4412-midas.dtsi | 3 +++ > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++ > arch/arm/boot/dts/exynos4412-origen.dts | 5 +++++ > arch/arm/boot/dts/exynos4412-p4note.dtsi | 6 ++++++ > arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 ++++ > arch/arm/boot/dts/exynos4412-tiny4412.dts | 4 ++++ > arch/arm/boot/dts/exynos4412.dtsi | 1 - > arch/arm/boot/dts/exynos5250-arndale.dts | 5 +++++ > arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 ++ > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +++ > arch/arm/boot/dts/exynos5250-spring.dts | 5 +++++ > arch/arm/boot/dts/exynos5250.dtsi | 4 ---- > arch/arm/boot/dts/exynos5260-xyref5260.dts | 5 +++++ > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 ++ > arch/arm/boot/dts/exynos5410-smdk5410.dts | 5 +++++ > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 5 +++++ > arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi | 5 +++++ > arch/arm/boot/dts/exynos5420-peach-pit.dts | 3 +++ > arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ > arch/arm/boot/dts/exynos5420.dtsi | 3 --- > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 5 +++++ > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 ++++ > arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 4 ++++ > arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 +++ > 35 files changed, 133 insertions(+), 11 deletions(-) > > > base-commit: 9ca5a7ce492d182c25ea2e785eeb72cee1d5056b Best regards
Hi Marek, On Mon, Jan 30, 2023 at 02:28:27PM +0100, Marek Szyprowski wrote: > On 28.01.2023 14:31, Henrik Grimler wrote: > > It is convenient to have fixed mmcblk numbering of the eMMC and sdcard > > so that assigned numbers will not change from boot-to-boot or > > depending on if storage devices are actually attached or not. > > > > Anton Bambura has done the work for the chromebooks while I have > > looked at the other devices. On the chromebooks, mmc0 is used for > > eMMC and mmc1 for sdcard, while mmc0 is used for eMMC and mmc2 for > > sdcard on the other boards, simply because Anton and I had different > > preferences. > > > > Also remove mshc aliases, as they should not be needed after [1] as > > I understand it. > > Thanks for this patchset. Long time ago I've tried to submit something > similar, but that time it has been rejected: > > https://lore.kernel.org/all/20201105114804.18326-1-m.szyprowski@samsung.com/ Thanks for testing! I missed that you had sent it before, Krzysztof pointed it out in v1 as well. > I hope that the mshc alias removal will help here. > > BTW, similar patchset is needed for arch/arm64/boot/dts/exynos Sure, I do not have any of the currently supported arm64 boards to test with, but can send the same type of patch for arm64 as well. [1] Best regards, Henrik Grimler > > [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com > > > > --- > > > > Changes since v1: > > * Move mshc alias cleanup to a separate commit > > * Use mmc0 and mmc1 (instead of mmc0 and mmc2) for eMMC and sdcard on > > chromebooks > > * Address Krzysztof's review comments: > > - Make changes per device rather than in soc dtsi > > > > > > Henrik Grimler (2): > > ARM: dts: exynos: drop mshc aliases > > ARM: dts: exynos: add mmc aliases > > > > arch/arm/boot/dts/exynos3250-artik5-eval.dts | 5 +++++ > > arch/arm/boot/dts/exynos3250-artik5.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos3250-monk.dts | 1 + > > arch/arm/boot/dts/exynos3250-rinato.dts | 2 ++ > > arch/arm/boot/dts/exynos3250.dtsi | 3 --- > > arch/arm/boot/dts/exynos4210-i9100.dts | 6 ++++++ > > arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++ > > arch/arm/boot/dts/exynos4210-smdkv310.dts | 4 ++++ > > arch/arm/boot/dts/exynos4210-trats.dts | 6 ++++++ > > arch/arm/boot/dts/exynos4210-universal_c210.dts | 6 ++++++ > > arch/arm/boot/dts/exynos4412-itop-elite.dts | 5 +++++ > > arch/arm/boot/dts/exynos4412-midas.dtsi | 3 +++ > > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos4412-origen.dts | 5 +++++ > > arch/arm/boot/dts/exynos4412-p4note.dtsi | 6 ++++++ > > arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 ++++ > > arch/arm/boot/dts/exynos4412-tiny4412.dts | 4 ++++ > > arch/arm/boot/dts/exynos4412.dtsi | 1 - > > arch/arm/boot/dts/exynos5250-arndale.dts | 5 +++++ > > arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 ++ > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +++ > > arch/arm/boot/dts/exynos5250-spring.dts | 5 +++++ > > arch/arm/boot/dts/exynos5250.dtsi | 4 ---- > > arch/arm/boot/dts/exynos5260-xyref5260.dts | 5 +++++ > > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 ++ > > arch/arm/boot/dts/exynos5410-smdk5410.dts | 5 +++++ > > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 5 +++++ > > arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 3 +++ > > arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ > > arch/arm/boot/dts/exynos5420.dtsi | 3 --- > > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 ++++ > > arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 4 ++++ > > arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 +++ > > 35 files changed, 133 insertions(+), 11 deletions(-) > > > > > > base-commit: 9ca5a7ce492d182c25ea2e785eeb72cee1d5056b > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland >