From patchwork Tue Apr 2 15:58:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Luba X-Patchwork-Id: 13614382 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5E9E6131751; Tue, 2 Apr 2024 15:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712073532; cv=none; b=iD4bKMCSdWt3olfoeI3uE3NjSeZ5Ij7DZBcq6oxwWCTKr5NwR1Lvw4X3dba0zlyztYGT2fHzUisqMWRs/99Drpp9QwIqNUiIZ9XAnD7x+P40lzF3pXQDMzdXh+6RNaBXCPsE1EQeQ9DE+aWJtEu8YbzOSp8hk+TjoaltJjkNT0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712073532; c=relaxed/simple; bh=8lpID7tMtIEmyGjb2Y3jIWs4aR03dvcFiUx/N9ij9Hw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=h8lt4O8OQk7aZwOfOwhz5B5ayx3k0lzKZHpAnk6BBE/zMCseissKzMkuFC6a7V4wQZWICPffFX8TpiUykQVUz7rMKlmI+tPmDuLaRW3q3SQyjg5ktcX3jPz+7KE2sVt0w1wYspf4Xr8q10XLR7654YKy6QeoJKTnOukoPsNqK3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DBD791042; Tue, 2 Apr 2024 08:59:20 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.72.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1DE993F64C; Tue, 2 Apr 2024 08:58:42 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [PATCH v4 0/4] Update Energy Model after chip binning adjusted voltages Date: Tue, 2 Apr 2024 16:58:18 +0100 Message-Id: <20240402155822.505491-1-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi all, This is a follow-up patch aiming to add EM modification due to chip binning. The first RFC and the discussion can be found here [1]. It uses Exynos chip driver code as a 1st user. The EM framework has been extended to handle this use case easily, when the voltage has been changed after setup. On my Odroid-xu4 in some OPPs I can observe ~20% power difference. According to that data in driver tables it could be up to ~29%. This chip binning is applicable to a lot of SoCs, so the EM framework should make it easy to update. It uses the existing OPP and DT information to re-calculate the new power values. It has dependency on Exynos SoC driver tree. Changes: v4: - added asterisk in the comment section (test robot) - change the patch 2/4 header name and use 'Refactor' v3: - updated header description patch 2/4 (Dietmar) - removed 2 sentences from comment and adjusted in patch 3/4 (Dietmar) - patch 4/4 re-phrased code comment (Dietmar) - collected tags (Krzysztof, Viresh) v2: - removed 'ret' from error message which wasn't initialized (Christian) v1: - exported the OPP calculation function from the OPP/OF so it can be used from EM fwk (Viresh) - refactored EM updating function to re-use common code - added new EM function which can be used by chip device drivers which modify the voltage in OPPs RFC is at [1] Regards, Lukasz Luba [1] https://lore.kernel.org/lkml/20231220110339.1065505-1-lukasz.luba@arm.com/ Lukasz Luba (4): OPP: OF: Export dev_opp_pm_calc_power() for usage from EM PM: EM: Refactor em_adjust_new_capacity() PM: EM: Add em_dev_update_chip_binning() soc: samsung: exynos-asv: Update Energy Model after adjusting voltage drivers/opp/of.c | 17 +++-- drivers/soc/samsung/exynos-asv.c | 11 +++- include/linux/energy_model.h | 5 ++ include/linux/pm_opp.h | 8 +++ kernel/power/energy_model.c | 106 +++++++++++++++++++++++++------ 5 files changed, 122 insertions(+), 25 deletions(-) Reviewed-by: Dietmar Eggemann