| Message ID | 20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | pinctrl: Use scope based of_node_put() cleanups | expand |
Hi Peng, On Sat, May 4, 2024 at 3:12 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > Use scope based of_node_put() to simplify code. It reduces the chance > of forgetting of_node_put(), and also simplifies error handling path. > I not able to test the changes on all the hardwares, so driver owners, > please help review when you have time. > > This patchset was inspired from Dan's comments on pinctrl-scmi-imx.c, > thanks. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> Andy's question about code generation on a related patch made me wonder, too. On arm32, a conversion to for_each_child_of_node_scoped() seems to cost ca. 48 bytes of additional code, regardless of whether there were explicit cleanups before or not. I checked "pinctrl: renesas: Use scope based of_node_put() cleanups", and all but the conversions in *_dt_node_to_map() cost 48 bytes each. Gr{oetje,eeting}s, Geert
Hi Geert > Subject: Re: [PATCH v2 00/20] pinctrl: Use scope based of_node_put() > cleanups > > Hi Peng, > > On Sat, May 4, 2024 at 3:12 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> > wrote: > > Use scope based of_node_put() to simplify code. It reduces the chance > > of forgetting of_node_put(), and also simplifies error handling path. > > I not able to test the changes on all the hardwares, so driver owners, > > please help review when you have time. > > > > This patchset was inspired from Dan's comments on pinctrl-scmi-imx.c, > > thanks. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > Andy's question about code generation on a related patch made me wonder, > too. > > On arm32, a conversion to for_each_child_of_node_scoped() seems to cost ca. > 48 bytes of additional code, regardless of whether there were explicit > cleanups before or not. > > I checked "pinctrl: renesas: Use scope based of_node_put() cleanups", and all > but the conversions in *_dt_node_to_map() cost 48 bytes each. > I am not sure this is an issue or else. What would you suggest me to do? If you think extra 48bytes consumption is not good here, feel free to drop the patch. Thanks, Peng. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Peng, On Fri, May 31, 2024 at 5:07 AM Peng Fan <peng.fan@nxp.com> wrote: > > Subject: Re: [PATCH v2 00/20] pinctrl: Use scope based of_node_put() > > cleanups > > On Sat, May 4, 2024 at 3:12 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> > > wrote: > > > Use scope based of_node_put() to simplify code. It reduces the chance > > > of forgetting of_node_put(), and also simplifies error handling path. > > > I not able to test the changes on all the hardwares, so driver owners, > > > please help review when you have time. > > > > > > This patchset was inspired from Dan's comments on pinctrl-scmi-imx.c, > > > thanks. > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > > Andy's question about code generation on a related patch made me wonder, > > too. > > > > On arm32, a conversion to for_each_child_of_node_scoped() seems to cost ca. > > 48 bytes of additional code, regardless of whether there were explicit > > cleanups before or not. > > > > I checked "pinctrl: renesas: Use scope based of_node_put() cleanups", and all > > but the conversions in *_dt_node_to_map() cost 48 bytes each. > > I am not sure this is an issue or else. What would you suggest me to do? > If you think extra 48bytes consumption is not good here, feel free to drop the > patch. I suggest doing nothing about this. I just wanted people to be aware of the impact. I guess it's just part of the slow but steady increase of kernel size (ca. 20-30 KiB/release)... ;-) Gr{oetje,eeting}s, Geert
Hi Linus, > Subject: [PATCH v2 00/20] pinctrl: Use scope based of_node_put() > cleanups st/stm32/renesas patches are picked. Would you handle the remaining ones? Thanks, Peng. > > Use scope based of_node_put() to simplify code. It reduces the chance > of forgetting of_node_put(), and also simplifies error handling path. > I not able to test the changes on all the hardwares, so driver owners, > please help review when you have time. > > This patchset was inspired from Dan's comments on pinctrl-scmi-imx.c, > thanks. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > Changes in v2: > - Drop aspeed changes per Andrew Jeffery > - Drop changes to code pattern that of_node_get(or other refcount > increasing) followed by of_node_put. That said, but I still have a change > for samsung pinctrl that drops several of_node_put places. If this is not > welcomed, patch 20/20 could be dropped. > - Add Fix tag for patch 1 > - Add A-b for patch 4 > - Drop unneeded {} in patch 8 Per Dan Carpenter > - Add a new patch 18. > - Moved patch [19,20]/20, in case people are not happy with the > changes, the two patch could be dropped when apply if no v3 patchset. > - Link to v1: https://lore.kernel.org/r/20240501-pinctrl-cleanup-v1-0- > 797ceca46e5c@nxp.com > > --- > Peng Fan (20): > pinctrl: ti: iodelay: Use scope based of_node_put() cleanups > pinctrl: tegra: Use scope based of_node_put() cleanups > pinctrl: stm32: Use scope based of_node_put() cleanups > pinctrl: starfive: Use scope based of_node_put() cleanups > pinctrl: sprd: Use scope based of_node_put() cleanups > pinctrl: spear: Use scope based of_node_put() cleanups > pinctrl: renesas: Use scope based of_node_put() cleanups > pinctrl: st: Use scope based of_node_put() cleanups > pinctrl: rockchip: Use scope based of_node_put() cleanups > pinctrl: equilibrium: Use scope based of_node_put() cleanups > pinctrl: at91: Use scope based of_node_put() cleanups > pinctrl: s32cc: Use scope based of_node_put() cleanups > pinctrl: nomadik: Use scope based of_node_put() cleanups > pinctrl: mediatek: Use scope based of_node_put() cleanups > pinctrl: freescale: Use scope based of_node_put() cleanups > pinctrl: bcm: bcm63xx: Use scope based of_node_put() cleanups > pinctrl: pinconf-generic: Use scope based of_node_put() cleanups > pinctrl: freescale: mxs: Fix refcount of child > pinctrl: k210: Use scope based of_node_put() cleanups > pinctrl: samsung: Use scope based of_node_put() cleanups > > drivers/pinctrl/bcm/pinctrl-bcm63xx.c | 4 +-- > drivers/pinctrl/freescale/pinctrl-imx.c | 25 ++++----------- > drivers/pinctrl/freescale/pinctrl-imx1-core.c | 16 +++------- > drivers/pinctrl/freescale/pinctrl-mxs.c | 18 ++++------- > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +-- > drivers/pinctrl/mediatek/pinctrl-paris.c | 4 +-- > drivers/pinctrl/nomadik/pinctrl-abx500.c | 4 +-- > drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +-- > drivers/pinctrl/nxp/pinctrl-s32cc.c | 31 ++++++------------ > drivers/pinctrl/pinconf-generic.c | 7 ++-- > drivers/pinctrl/pinctrl-at91-pio4.c | 7 ++-- > drivers/pinctrl/pinctrl-at91.c | 14 +++----- > drivers/pinctrl/pinctrl-equilibrium.c | 21 +++--------- > drivers/pinctrl/pinctrl-k210.c | 7 ++-- > drivers/pinctrl/pinctrl-rockchip.c | 11 ++----- > drivers/pinctrl/pinctrl-st.c | 37 +++++++--------------- > drivers/pinctrl/renesas/pinctrl-rza1.c | 14 +++----- > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 7 ++-- > drivers/pinctrl/renesas/pinctrl-rzn1.c | 23 ++++---------- > drivers/pinctrl/renesas/pinctrl-rzv2m.c | 7 ++-- > drivers/pinctrl/renesas/pinctrl.c | 7 ++-- > drivers/pinctrl/samsung/pinctrl-exynos.c | 16 +++------- > drivers/pinctrl/samsung/pinctrl-samsung.c | 19 +++-------- > drivers/pinctrl/spear/pinctrl-spear.c | 13 +++----- > drivers/pinctrl/sprd/pinctrl-sprd.c | 14 +++----- > drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c | 27 +++++++--------- > drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 18 +++++------ > drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +-- > drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 7 ++-- > drivers/pinctrl/tegra/pinctrl-tegra.c | 4 +-- > drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 37 ++++++++-------------- > 31 files changed, 133 insertions(+), 298 deletions(-) > --- > base-commit: bb7a2467e6beef44a80a17d45ebf2931e7631083 > change-id: 20240429-pinctrl-cleanup-e4d461c32648 > > Best regards, > -- > Peng Fan <peng.fan@nxp.com>
On Tue, Jun 18, 2024 at 1:52 PM Peng Fan <peng.fan@nxp.com> wrote: > > Subject: [PATCH v2 00/20] pinctrl: Use scope based of_node_put() > > cleanups > > st/stm32/renesas patches are picked. Would you handle the remaining > ones? Hm right, I applied all that apply cleanly: 971c8b4c08e7 (HEAD -> devel) pinctrl: samsung: Use scope based of_node_put() cleanups 3a882554a3bb pinctrl: k210: Use scope based of_node_put() cleanups 7f500f2011c0 pinctrl: freescale: mxs: Fix refcount of child d7f5120a944a pinctrl: pinconf-generic: Use scope based of_node_put() cleanups 240c5f238d59 pinctrl: bcm: bcm63xx: Use scope based of_node_put() cleanups 3a0278cfb448 pinctrl: mediatek: Use scope based of_node_put() cleanups c957ae7e7e68 pinctrl: nomadik: Use scope based of_node_put() cleanups 3dcc01b36f18 pinctrl: s32cc: Use scope based of_node_put() cleanups 7c2aabb56f92 pinctrl: at91: Use scope based of_node_put() cleanups 56c42f6c7b2c pinctrl: rockchip: Use scope based of_node_put() cleanups 8c5dc2a5b3a7 pinctrl: spear: Use scope based of_node_put() cleanups 794e5dc533b0 pinctrl: sprd: Use scope based of_node_put() cleanups 8fa99c00351c pinctrl: starfive: Use scope based of_node_put() cleanups 11eefc0ac884 pinctrl: tegra: Use scope based of_node_put() cleanups Can you look into rebasing the remaining ones? I am a bit unsure about Samsung, Krzysztof usually pick these, but no big deal I guess, if he objects I can just take it out again. Yours, Linus Walleij
On 26/06/2024 12:02, Linus Walleij wrote: > On Tue, Jun 18, 2024 at 1:52 PM Peng Fan <peng.fan@nxp.com> wrote: > >>> Subject: [PATCH v2 00/20] pinctrl: Use scope based of_node_put() >>> cleanups >> >> st/stm32/renesas patches are picked. Would you handle the remaining >> ones? > > Hm right, I applied all that apply cleanly: > 971c8b4c08e7 (HEAD -> devel) pinctrl: samsung: Use scope based > of_node_put() cleanups > 3a882554a3bb pinctrl: k210: Use scope based of_node_put() cleanups > 7f500f2011c0 pinctrl: freescale: mxs: Fix refcount of child > d7f5120a944a pinctrl: pinconf-generic: Use scope based of_node_put() cleanups > 240c5f238d59 pinctrl: bcm: bcm63xx: Use scope based of_node_put() cleanups > 3a0278cfb448 pinctrl: mediatek: Use scope based of_node_put() cleanups > c957ae7e7e68 pinctrl: nomadik: Use scope based of_node_put() cleanups > 3dcc01b36f18 pinctrl: s32cc: Use scope based of_node_put() cleanups > 7c2aabb56f92 pinctrl: at91: Use scope based of_node_put() cleanups > 56c42f6c7b2c pinctrl: rockchip: Use scope based of_node_put() cleanups > 8c5dc2a5b3a7 pinctrl: spear: Use scope based of_node_put() cleanups > 794e5dc533b0 pinctrl: sprd: Use scope based of_node_put() cleanups > 8fa99c00351c pinctrl: starfive: Use scope based of_node_put() cleanups > 11eefc0ac884 pinctrl: tegra: Use scope based of_node_put() cleanups > > Can you look into rebasing the remaining ones? > > I am a bit unsure about Samsung, Krzysztof usually pick these, but no big > deal I guess, if he objects I can just take it out again. I can grab that one. Best regards, Krzysztof
Use scope based of_node_put() to simplify code. It reduces the chance of forgetting of_node_put(), and also simplifies error handling path. I not able to test the changes on all the hardwares, so driver owners, please help review when you have time. This patchset was inspired from Dan's comments on pinctrl-scmi-imx.c, thanks. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- Changes in v2: - Drop aspeed changes per Andrew Jeffery - Drop changes to code pattern that of_node_get(or other refcount increasing) followed by of_node_put. That said, but I still have a change for samsung pinctrl that drops several of_node_put places. If this is not welcomed, patch 20/20 could be dropped. - Add Fix tag for patch 1 - Add A-b for patch 4 - Drop unneeded {} in patch 8 Per Dan Carpenter - Add a new patch 18. - Moved patch [19,20]/20, in case people are not happy with the changes, the two patch could be dropped when apply if no v3 patchset. - Link to v1: https://lore.kernel.org/r/20240501-pinctrl-cleanup-v1-0-797ceca46e5c@nxp.com --- Peng Fan (20): pinctrl: ti: iodelay: Use scope based of_node_put() cleanups pinctrl: tegra: Use scope based of_node_put() cleanups pinctrl: stm32: Use scope based of_node_put() cleanups pinctrl: starfive: Use scope based of_node_put() cleanups pinctrl: sprd: Use scope based of_node_put() cleanups pinctrl: spear: Use scope based of_node_put() cleanups pinctrl: renesas: Use scope based of_node_put() cleanups pinctrl: st: Use scope based of_node_put() cleanups pinctrl: rockchip: Use scope based of_node_put() cleanups pinctrl: equilibrium: Use scope based of_node_put() cleanups pinctrl: at91: Use scope based of_node_put() cleanups pinctrl: s32cc: Use scope based of_node_put() cleanups pinctrl: nomadik: Use scope based of_node_put() cleanups pinctrl: mediatek: Use scope based of_node_put() cleanups pinctrl: freescale: Use scope based of_node_put() cleanups pinctrl: bcm: bcm63xx: Use scope based of_node_put() cleanups pinctrl: pinconf-generic: Use scope based of_node_put() cleanups pinctrl: freescale: mxs: Fix refcount of child pinctrl: k210: Use scope based of_node_put() cleanups pinctrl: samsung: Use scope based of_node_put() cleanups drivers/pinctrl/bcm/pinctrl-bcm63xx.c | 4 +-- drivers/pinctrl/freescale/pinctrl-imx.c | 25 ++++----------- drivers/pinctrl/freescale/pinctrl-imx1-core.c | 16 +++------- drivers/pinctrl/freescale/pinctrl-mxs.c | 18 ++++------- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +-- drivers/pinctrl/mediatek/pinctrl-paris.c | 4 +-- drivers/pinctrl/nomadik/pinctrl-abx500.c | 4 +-- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +-- drivers/pinctrl/nxp/pinctrl-s32cc.c | 31 ++++++------------ drivers/pinctrl/pinconf-generic.c | 7 ++-- drivers/pinctrl/pinctrl-at91-pio4.c | 7 ++-- drivers/pinctrl/pinctrl-at91.c | 14 +++----- drivers/pinctrl/pinctrl-equilibrium.c | 21 +++--------- drivers/pinctrl/pinctrl-k210.c | 7 ++-- drivers/pinctrl/pinctrl-rockchip.c | 11 ++----- drivers/pinctrl/pinctrl-st.c | 37 +++++++--------------- drivers/pinctrl/renesas/pinctrl-rza1.c | 14 +++----- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 7 ++-- drivers/pinctrl/renesas/pinctrl-rzn1.c | 23 ++++---------- drivers/pinctrl/renesas/pinctrl-rzv2m.c | 7 ++-- drivers/pinctrl/renesas/pinctrl.c | 7 ++-- drivers/pinctrl/samsung/pinctrl-exynos.c | 16 +++------- drivers/pinctrl/samsung/pinctrl-samsung.c | 19 +++-------- drivers/pinctrl/spear/pinctrl-spear.c | 13 +++----- drivers/pinctrl/sprd/pinctrl-sprd.c | 14 +++----- drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c | 27 +++++++--------- drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 18 +++++------ drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +-- drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 7 ++-- drivers/pinctrl/tegra/pinctrl-tegra.c | 4 +-- drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 37 ++++++++-------------- 31 files changed, 133 insertions(+), 298 deletions(-) --- base-commit: bb7a2467e6beef44a80a17d45ebf2931e7631083 change-id: 20240429-pinctrl-cleanup-e4d461c32648 Best regards,