From patchwork Wed Sep 11 05:02:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13799679 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB9E7558BC; Wed, 11 Sep 2024 05:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726031297; cv=none; b=BG2n367pPz3+c5O7DkTZ3hR/v2dvqvR/b8zEQ0iU+J1yKuRHPBq3pdSkQAxtiHlh8ozA36j97PBgI13/S2Oghh+/9WUWMvhawBs6ycR5v2dkmNWjf4fBVaNJJ5TowZEzfkMfygeS6deShu1aWTY6vdBjYbTjQKWIxHX99zHWql0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726031297; c=relaxed/simple; bh=AwzBXZIzFQKKCdF7T+KzC877Td4dtULqKAPc7SXlFYc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IrQw5vnjgT/3Y25o5jnrFR3WT5rvT5n+HEHPAckeBTjqX/kTYTvaMRUOqPcDUCcfG0/woBXTIZa5W1Woif/k6wfUdgdDVabt/1XS6uQIQ3rCXoMbmPoLWvxEP4AiLhnj/1Xa6J2jg/caPVz8RrgeijVntnU5JAzc9Te+8gjxpp8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N8qyxDdK; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N8qyxDdK" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-7d916b6a73aso1919776a12.1; Tue, 10 Sep 2024 22:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726031295; x=1726636095; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FJNquf2p9Vd205iSBUl3QuEluAS8I7046ZFy2HBvaPU=; b=N8qyxDdKfuxFPctX5kJzB6grL2nkK6hwJj6GdhWWG9fpZuxGZxAFJPk9zeVnNB9GRa xrbPsmJKQvk6TJKcSmgjMR5PFyD3G6QcXpO6jrfHYTLjsT9/zMjSKSI6VEeJ/cw26L5c sZDLQhjuxU66eNNkRA7QoEumV6QD8UC73fLlzN0xcxkVlIfPDgv4fbS8ENTfkw7R+jJY zzUBT2K8Vhwk3D0CUTMZuIEdazHmx35w2YeELIe+OUSAQtd8Do8sLJrPvjq6WQ6LpLRl k1hBYX4XjQASf6iyOhFsYVvdBTsGrBL6QJcE/kOL4hDTnseXionhUTdTlBfDsfP2G16m SeOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726031295; x=1726636095; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FJNquf2p9Vd205iSBUl3QuEluAS8I7046ZFy2HBvaPU=; b=S6k4hIIW8geaoRuMLovvn2LAVoziL5+GK+kJunlX84L4xmyL0JKWk708jTcfXjustn eA9CoGPSjh2yR1mxLoS6/IJ4QCLpJAC218w2uYY9ep1T8Cn0KMaZMZoqcg/gn5KEoeOI Ggg+0b7/kR+u3BtHAr+AXYdVcXcjshT2/IY6H7ptF8q3wqRNW/akKmhzzyLv82yeIGqo QbjEDrPzINXOQBWnI3pwJPiah+StfQmLFN9NBYBZQKjjq2uoS1S+5dpP2/9rk6I3uiS9 6Ddc2oUMujeQPJ2FyMpsdoOHqSRZnAMJ9TcBx+bFMxLy4Se1ItggKhf4oMibBGLX3dLy jGtA== X-Forwarded-Encrypted: i=1; AJvYcCX0D2zoIq0Ad93aV6HjqHFw85iMgiAhbthzs6ORs3GyBnDW90ITikNEQqE45BDlFi1oQoRcWmbhhEWJFYIWAMv/rkU=@vger.kernel.org, AJvYcCX4raU3SBvmV78EbwgA1bqVv4UAgAC3RgAQ9S++VUZyEtVd9TWuNGw4XoL5FcfnlnB+pBuzbkVx8GPdbf8=@vger.kernel.org, AJvYcCX6XYVLgg9jYjjkF0PKzldgnjZqTAGTOJWrqNBEBmsxdSS53UO9zg9cRbZcyH2tJdFExUcHMMJSCQzVRIbn@vger.kernel.org X-Gm-Message-State: AOJu0Yzv2+XrNZdJq5cbmxW929UEPNLOifE5uvH5h+kI30eTyrEy/ejG Ge6qdNWTPc7qPhaB2yrOV2y/BHkFT36uRWerriAMBRUrYaOYJs+A X-Google-Smtp-Source: AGHT+IGHyQ/thpVPHpLlMROm5PaaH2JXUVeTNkTbxO/M3qZ9x2+zgfugUFwAwVylRL4VZAW3TYD2Yg== X-Received: by 2002:a05:6a20:c6cd:b0:1cf:4d21:f4c1 with SMTP id adf61e73a8af0-1cf5e094debmr3981813637.19.1726031294830; Tue, 10 Sep 2024 22:08:14 -0700 (PDT) Received: from nick-mbp.ust.hk (wf121-022.ust.hk. [175.159.121.22]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-719090d11e6sm2156984b3a.205.2024.09.10.22.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 22:08:14 -0700 (PDT) From: Nick Chan To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: asahi@lists.linux.dev, Nick Chan Subject: [PATCH v5 0/3] tty: serial: samsung: Serial fixes for Apple A7-A11 SoCs Date: Wed, 11 Sep 2024 13:02:10 +0800 Message-ID: <20240911050741.14477-1-towinchenmi@gmail.com> X-Mailer: git-send-email 2.46.0 Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, This series fixes issues with serial on A7-A11 SoCs. The changes do not seem to affect existing M1 and up users so they can be applied unconditionally. Firstly, these SoCs require 32-bit writes on the serial port. This only manifested in earlycon as reg-io-width in device tree is consulted for normal serial writes. Secondly, A7-A9 SoCs seems to use different bits for RXTO and RXTO enable. Accessing these bits in addition to the original RXTO and RXTO enable bits will allow serial rx to work correctly on those SoCs. Changes in v5: - Convert existing APPLE_S5L_* entries to use GENMASK() macro in addition to BIT(), as suggested by Andi. Changes in v4: - Removed fake Reviewed-by tag added by accident... need to stop making stupid mistakes that wastes everyone's time. The remaining Reviewed-by is real as far as I am aware. Changes in v3: - v2 did not declare itself as v2 in subject line... resend as v3. Changes in v2: - Mention A7-A11 in the comment about changing register accesses to MMIO32. - Use BIT() macro for new entries, and change the existing APPLE_S5L_* entries for consistency. v1: https://lore.kernel.org/linux-samsung-soc/20240907111431.2970-1-towinchenmi@gmail.com v2: https://lore.kernel.org/linux-samsung-soc/20240908075904.12133-1-towinchenmi@gmail.com v3: https://lore.kernel.org/linux-samsung-soc/20240908090939.2745-1-towinchenmi@gmail.com v4: https://lore.kernel.org/linux-samsung-soc/20240909084222.3209-1-towinchenmi@gmail.com/ Nick Chan --- Nick Chan (3): tty: serial: samsung: Use bit manipulation macros for APPLE_S5L_* tty: serial: samsung: Fix A7-A11 serial earlycon SError tty: serial: samsung: Fix serial rx on Apple A7-A9 drivers/tty/serial/samsung_tty.c | 22 ++++++++++++++++------ include/linux/serial_s3c.h | 24 ++++++++++++++---------- 2 files changed, 30 insertions(+), 16 deletions(-) base-commit: 6708132e80a2ced620bde9b9c36e426183544a23