| Message ID | 20250204-exynos7870-chipid-v1-0-0bf2db08e621@disroot.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add chip ID for Exynos7870 SoC | expand |
On 03/02/2025 21:32, Kaustabh Chakraborty wrote: > This patch series is a part of Exynos7870 upstreaming. > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > --- > Kaustabh Chakraborty (2): > dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible > soc: samsung: exynos-chipid: add support for exynos7870 > > Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 + > drivers/soc/samsung/exynos-chipid.c | 1 + > 2 files changed, 2 insertions(+) When I asked to split, I said per subsystem. Soc is one subsystem. Everything targeting SoC should be in one patchset. get_maintainers.pl tells the name of the subsystem and its maintainers. If there is going to be resend/new version, combine patchsets for soc into one patchset (just like the example I gave last time). Best regards, Krzysztof
On Tue, Feb 04, 2025 at 08:53:31AM +0100, Krzysztof Kozlowski wrote: > On 03/02/2025 21:32, Kaustabh Chakraborty wrote: > > This patch series is a part of Exynos7870 upstreaming. > > > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > > --- > > Kaustabh Chakraborty (2): > > dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible > > soc: samsung: exynos-chipid: add support for exynos7870 > > > > Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 + > > drivers/soc/samsung/exynos-chipid.c | 1 + > > 2 files changed, 2 insertions(+) > > When I asked to split, I said per subsystem. Soc is one subsystem. > Everything targeting SoC should be in one patchset. get_maintainers.pl > tells the name of the subsystem and its maintainers. > > If there is going to be resend/new version, combine patchsets for soc > into one patchset (just like the example I gave last time). And please send patches to the address people list in maintainers, don't modify the addresses.
On 2025-02-04 07:53, Krzysztof Kozlowski wrote: > On 03/02/2025 21:32, Kaustabh Chakraborty wrote: >> This patch series is a part of Exynos7870 upstreaming. >> >> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >> --- >> Kaustabh Chakraborty (2): >> dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible >> soc: samsung: exynos-chipid: add support for exynos7870 >> >> Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 + >> drivers/soc/samsung/exynos-chipid.c | 1 + >> 2 files changed, 2 insertions(+) > > When I asked to split, I said per subsystem. Soc is one subsystem. > Everything targeting SoC should be in one patchset. get_maintainers.pl > tells the name of the subsystem and its maintainers. > > If there is going to be resend/new version, combine patchsets for soc > into one patchset (just like the example I gave last time). Alright, so I'll move these patches to the one which has the devicetrees. There's also a Documentation/devicetree/bindings/soc/ patch in exynos7870-pmu-clocks [1]. The CLKOUT driver uses the compatible declared in there, i.e., the CLKOUT driver depends on that commit. So, should it stay there? Or...? [1] https://lore.kernel.org/r/20250204-exynos7870-pmu-clocks-v1-0-a3030ae5bb53@disroot.org > > Best regards, > Krzysztof
On 04/02/2025 20:29, Kaustabh Chakraborty wrote: > On 2025-02-04 07:53, Krzysztof Kozlowski wrote: >> On 03/02/2025 21:32, Kaustabh Chakraborty wrote: >>> This patch series is a part of Exynos7870 upstreaming. >>> >>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> >>> --- >>> Kaustabh Chakraborty (2): >>> dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible >>> soc: samsung: exynos-chipid: add support for exynos7870 >>> >>> Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 + >>> drivers/soc/samsung/exynos-chipid.c | 1 + >>> 2 files changed, 2 insertions(+) >> >> When I asked to split, I said per subsystem. Soc is one subsystem. >> Everything targeting SoC should be in one patchset. get_maintainers.pl >> tells the name of the subsystem and its maintainers. >> >> If there is going to be resend/new version, combine patchsets for soc >> into one patchset (just like the example I gave last time). > > Alright, so I'll move these patches to the one which has the devicetrees. > > There's also a Documentation/devicetree/bindings/soc/ patch in > exynos7870-pmu-clocks [1]. The CLKOUT driver uses the compatible declared > in there, i.e., the CLKOUT driver depends on that commit. So, should it > stay there? Or...? The binding stays with the driver. Best regards, Krzysztof
This patch series is a part of Exynos7870 upstreaming. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- Kaustabh Chakraborty (2): dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible soc: samsung: exynos-chipid: add support for exynos7870 Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 + drivers/soc/samsung/exynos-chipid.c | 1 + 2 files changed, 2 insertions(+) --- base-commit: df4b2bbff898227db0c14264ac7edd634e79f755 change-id: 20250203-exynos7870-chipid-c6f24a9a814d Best regards,