diff mbox

pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()

Message ID 001901ce05be$aacdeb30$0069c190$%han@samsung.com
State New, archived
Headers show

Commit Message

Jingoo Han Feb. 8, 2013, 5:39 a.m. UTC
This patch removes duplicated line of samsung_pinctrl_register(),
because the number of pins is redundantly assigned twice.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pinctrl/pinctrl-samsung.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Tomasz Figa Feb. 8, 2013, 10:28 a.m. UTC | #1
On Friday 08 of February 2013 14:39:30 Jingoo Han wrote:
> This patch removes duplicated line of samsung_pinctrl_register(),
> because the number of pins is redundantly assigned twice.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/pinctrl/pinctrl-samsung.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-samsung.c
> b/drivers/pinctrl/pinctrl-samsung.c index 294bcdd..3d5cf63 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct
> platform_device *pdev, }
>  	ctrldesc->pins = pindesc;
>  	ctrldesc->npins = drvdata->ctrl->nr_pins;
> -	ctrldesc->npins = drvdata->ctrl->nr_pins;
> 
>  	/* dynamically populate the pin number and pin name for pindesc */
>  	for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++, 
pdesc++)

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Kim Kukjin Feb. 8, 2013, 10:44 p.m. UTC | #2
Jingoo Han wrote:
> 
> This patch removes duplicated line of samsung_pinctrl_register(),
> because the number of pins is redundantly assigned twice.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks.

- Kukjin

> ---
>  drivers/pinctrl/pinctrl-samsung.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-
> samsung.c
> index 294bcdd..3d5cf63 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct
> platform_device *pdev,
>  	}
>  	ctrldesc->pins = pindesc;
>  	ctrldesc->npins = drvdata->ctrl->nr_pins;
> -	ctrldesc->npins = drvdata->ctrl->nr_pins;
> 
>  	/* dynamically populate the pin number and pin name for pindesc */
>  	for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++,
pdesc++)
> --
> 1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Feb. 10, 2013, 7:17 p.m. UTC | #3
On Fri, Feb 8, 2013 at 6:39 AM, Jingoo Han <jg1.han@samsung.com> wrote:

> This patch removes duplicated line of samsung_pinctrl_register(),
> because the number of pins is redundantly assigned twice.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Patch applied with the Reviewed-by/Acked-by tags from
the maintainers.

Thanks!
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index 294bcdd..3d5cf63 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -716,7 +716,6 @@  static int samsung_pinctrl_register(struct platform_device *pdev,
 	}
 	ctrldesc->pins = pindesc;
 	ctrldesc->npins = drvdata->ctrl->nr_pins;
-	ctrldesc->npins = drvdata->ctrl->nr_pins;
 
 	/* dynamically populate the pin number and pin name for pindesc */
 	for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++, pdesc++)