| Message ID | 003401cea225$a3dc0c40$eb9424c0$%han@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mr. Han, On 26 August 2013 11:59, Jingoo Han <jg1.han@samsung.com> wrote: > Since DP PHY driver is not yet merged, DP PHY node should be > removed from exynos5250.dtsi. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 864ae90..72aec7f 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -625,17 +625,16 @@ > interrupts = <0 94 0>; > }; > > - dp_phy: video-phy@10040720 { > - compatible = "samsung,exynos5250-dp-video-phy"; > - reg = <0x10040720 4>; > - #phy-cells = <0>; > - }; > - > dp-controller@145B0000 { > clocks = <&clock 342>; > clock-names = "dp"; > - phys = <&dp_phy>; > - phy-names = "dp"; > + #address-cells = <1>; > + #size-cells = <0>; > + I think you can skip the above 2 lines, as those are already present in exynos5.dtsi. > + dptx-phy { > + reg = <0x10040720>; > + samsung,enable-mask = <1>; > + }; > }; > > fimd@14400000 { > -- > 1.7.10.4 > >
On Monday, August 26, 2013 3:43 PM, Vikas Sajjan wrote: > On 26 August 2013 11:59, Jingoo Han <jg1.han@samsung.com> wrote: > > Since DP PHY driver is not yet merged, DP PHY node should be > > removed from exynos5250.dtsi. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > --- > > arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++-------- > > 1 file changed, 7 insertions(+), 8 deletions(-) > > [.....] > > dp-controller@145B0000 { > > clocks = <&clock 342>; > > clock-names = "dp"; > > - phys = <&dp_phy>; > > - phy-names = "dp"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > I think you can skip the above 2 lines, as those are already present > in exynos5.dtsi. OK, I see. I will remove above 2 lines, and send V2 patch soon. Thank you for your comment. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 864ae90..72aec7f 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -625,17 +625,16 @@ interrupts = <0 94 0>; }; - dp_phy: video-phy@10040720 { - compatible = "samsung,exynos5250-dp-video-phy"; - reg = <0x10040720 4>; - #phy-cells = <0>; - }; - dp-controller@145B0000 { clocks = <&clock 342>; clock-names = "dp"; - phys = <&dp_phy>; - phy-names = "dp"; + #address-cells = <1>; + #size-cells = <0>; + + dptx-phy { + reg = <0x10040720>; + samsung,enable-mask = <1>; + }; }; fimd@14400000 {
Since DP PHY driver is not yet merged, DP PHY node should be removed from exynos5250.dtsi. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)