diff mbox

ARM: SAMSUNG: Remove unnecessary exynos4_default_sdhci*()

Message ID 004d01ce80f1$33533d90$99f9b8b0$@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jingoo Han July 15, 2013, 12:21 a.m. UTC 
Commit 17397a2("ARM: EXYNOS: Remove platform device initialization")
removes calling exynos4_default_sdhci*() functions; thus, these are
not necessary any more.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 arch/arm/plat-samsung/include/plat/sdhci.h |   38 ----------------------------
 1 file changed, 38 deletions(-)

Comments

Kim Kukjin Aug. 18, 2013, 8:24 p.m. UTC | #1 
On 07/15/13 09:21, Jingoo Han wrote:
> Commit 17397a2("ARM: EXYNOS: Remove platform device initialization")
> removes calling exynos4_default_sdhci*() functions; thus, these are
> not necessary any more.
>
> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> ---
>   arch/arm/plat-samsung/include/plat/sdhci.h |   38 ----------------------------
>   1 file changed, 38 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-samsung/include/plat/sdhci.h
> index ce1d0f7..bf65021 100644
> --- a/arch/arm/plat-samsung/include/plat/sdhci.h
> +++ b/arch/arm/plat-samsung/include/plat/sdhci.h
> @@ -260,44 +260,6 @@ static inline void s5pv210_default_sdhci3(void) { }
>
>   #endif /* CONFIG_S5PV210_SETUP_SDHCI */
>
> -/* EXYNOS4 SDHCI setup */
> -#ifdef CONFIG_EXYNOS4_SETUP_SDHCI
> -static inline void exynos4_default_sdhci0(void)
> -{
> -#ifdef CONFIG_S3C_DEV_HSMMC
> -	s3c_hsmmc0_def_platdata.cfg_gpio = exynos4_setup_sdhci0_cfg_gpio;
> -#endif
> -}
> -
> -static inline void exynos4_default_sdhci1(void)
> -{
> -#ifdef CONFIG_S3C_DEV_HSMMC1
> -	s3c_hsmmc1_def_platdata.cfg_gpio = exynos4_setup_sdhci1_cfg_gpio;
> -#endif
> -}
> -
> -static inline void exynos4_default_sdhci2(void)
> -{
> -#ifdef CONFIG_S3C_DEV_HSMMC2
> -	s3c_hsmmc2_def_platdata.cfg_gpio = exynos4_setup_sdhci2_cfg_gpio;
> -#endif
> -}
> -
> -static inline void exynos4_default_sdhci3(void)
> -{
> -#ifdef CONFIG_S3C_DEV_HSMMC3
> -	s3c_hsmmc3_def_platdata.cfg_gpio = exynos4_setup_sdhci3_cfg_gpio;
> -#endif
> -}
> -
> -#else
> -static inline void exynos4_default_sdhci0(void) { }
> -static inline void exynos4_default_sdhci1(void) { }
> -static inline void exynos4_default_sdhci2(void) { }
> -static inline void exynos4_default_sdhci3(void) { }
> -
> -#endif /* CONFIG_EXYNOS4_SETUP_SDHCI */
> -
>   static inline void s3c_sdhci_setname(int id, char *name)
>   {
>   	switch (id) {

Looks good to me, applied.

Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-samsung/include/plat/sdhci.h
index ce1d0f7..bf65021 100644
--- a/arch/arm/plat-samsung/include/plat/sdhci.h
+++ b/arch/arm/plat-samsung/include/plat/sdhci.h
@@ -260,44 +260,6 @@  static inline void s5pv210_default_sdhci3(void) { }
 
 #endif /* CONFIG_S5PV210_SETUP_SDHCI */
 
-/* EXYNOS4 SDHCI setup */
-#ifdef CONFIG_EXYNOS4_SETUP_SDHCI
-static inline void exynos4_default_sdhci0(void)
-{
-#ifdef CONFIG_S3C_DEV_HSMMC
-	s3c_hsmmc0_def_platdata.cfg_gpio = exynos4_setup_sdhci0_cfg_gpio;
-#endif
-}
-
-static inline void exynos4_default_sdhci1(void)
-{
-#ifdef CONFIG_S3C_DEV_HSMMC1
-	s3c_hsmmc1_def_platdata.cfg_gpio = exynos4_setup_sdhci1_cfg_gpio;
-#endif
-}
-
-static inline void exynos4_default_sdhci2(void)
-{
-#ifdef CONFIG_S3C_DEV_HSMMC2
-	s3c_hsmmc2_def_platdata.cfg_gpio = exynos4_setup_sdhci2_cfg_gpio;
-#endif
-}
-
-static inline void exynos4_default_sdhci3(void)
-{
-#ifdef CONFIG_S3C_DEV_HSMMC3
-	s3c_hsmmc3_def_platdata.cfg_gpio = exynos4_setup_sdhci3_cfg_gpio;
-#endif
-}
-
-#else
-static inline void exynos4_default_sdhci0(void) { }
-static inline void exynos4_default_sdhci1(void) { }
-static inline void exynos4_default_sdhci2(void) { }
-static inline void exynos4_default_sdhci3(void) { }
-
-#endif /* CONFIG_EXYNOS4_SETUP_SDHCI */
-
 static inline void s3c_sdhci_setname(int id, char *name)
 {
 	switch (id) {