| Message ID | 013a01d0c87c$854d4d00$8fe7e700$@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 27.07.2015 23:57, Kukjin Kim wrote: > > This patch moves regs-srom header file into mach-exynos. Hi, Minor nits: 1. Could you trim it and remove unnecessary empty line before description? 2. Could you answer in commit message: Why? Why are you moving the headers? > > c: Krzysztof Kozlowski <k.kozlowski@samsung.com> Malformed "Cc:" tag. Best regards, Krzysztof > Signed-off-by: Kukjin Kim <kgene@kernel.org> > --- > arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h | 3 +-- > arch/arm/mach-exynos/suspend.c | 4 ++-- > 2 files changed, 3 insertions(+), 4 deletions(-) > rename arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h (96%) > > diff --git a/arch/arm/plat-samsung/include/plat/regs-srom.h b/arch/arm/mach-exynos/regs-srom.h > similarity index 96% > rename from arch/arm/plat-samsung/include/plat/regs-srom.h > rename to arch/arm/mach-exynos/regs-srom.h > index 9b6729c..5c4d442 100644 > --- a/arch/arm/plat-samsung/include/plat/regs-srom.h > +++ b/arch/arm/mach-exynos/regs-srom.h > @@ -1,5 +1,4 @@ > -/* linux/arch/arm/plat-samsung/include/plat/regs-srom.h > - * > +/* > * Copyright (c) 2010 Samsung Electronics Co., Ltd. > * http://www.samsung.com > * > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c > index c506f8e..e00eb39 100644 > --- a/arch/arm/mach-exynos/suspend.c > +++ b/arch/arm/mach-exynos/suspend.c > @@ -32,11 +32,11 @@ > #include <asm/suspend.h> > > #include <plat/pm-common.h> > -#include <plat/regs-srom.h> > > #include "common.h" > -#include "regs-pmu.h" > #include "exynos-pmu.h" > +#include "regs-pmu.h" > +#include "regs-srom.h" > > #define REG_TABLE_END (-1U) > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski wrote: > > On 27.07.2015 23:57, Kukjin Kim wrote: > > > > This patch moves regs-srom header file into mach-exynos. > > Hi, > Hi, > Minor nits: > 1. Could you trim it and remove unnecessary empty line before description? Yeah, actually I couldn't use git send-email when I submitted but just used e-mail. It should be fine in my local branch. > 2. Could you answer in commit message: Why? Why are you moving the headers? > OK, basically we don't need to keep headers in <mach/xxx> and <plat/xxx> if it is not required. For example, actually common.h files in mach-xxxx/ have been made/moved because of the reason before. Someday we did because it was required to support multi_v7 as well. Anyway it is still required and note that I have some more patches to move headers which are used only for under drivers/ not arch side into drivers/. And next step is removing some definitions which are not used more. > > > > c: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > Malformed "Cc:" tag. > Oh, OK. Thanks. One more thing, please ignore patch "[09/12] ARM: SAMSUNG: local keypad header in mach-s3c64xx" in this series because the header is used in plat-samsung as well. Anyway, thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/plat-samsung/include/plat/regs-srom.h b/arch/arm/mach-exynos/regs-srom.h similarity index 96% rename from arch/arm/plat-samsung/include/plat/regs-srom.h rename to arch/arm/mach-exynos/regs-srom.h index 9b6729c..5c4d442 100644 --- a/arch/arm/plat-samsung/include/plat/regs-srom.h +++ b/arch/arm/mach-exynos/regs-srom.h @@ -1,5 +1,4 @@ -/* linux/arch/arm/plat-samsung/include/plat/regs-srom.h - * +/* * Copyright (c) 2010 Samsung Electronics Co., Ltd. * http://www.samsung.com * diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index c506f8e..e00eb39 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -32,11 +32,11 @@ #include <asm/suspend.h> #include <plat/pm-common.h> -#include <plat/regs-srom.h> #include "common.h" -#include "regs-pmu.h" #include "exynos-pmu.h" +#include "regs-pmu.h" +#include "regs-srom.h" #define REG_TABLE_END (-1U)
This patch moves regs-srom header file into mach-exynos. c: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Kukjin Kim <kgene@kernel.org> --- arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h | 3 +-- arch/arm/mach-exynos/suspend.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) rename arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h (96%)