From patchwork Tue Jul 8 13:09:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 4504951 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 13DD6BEEAA for ; Tue, 8 Jul 2014 13:11:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5670E20155 for ; Tue, 8 Jul 2014 13:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61EF020127 for ; Tue, 8 Jul 2014 13:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802AbaGHNLq (ORCPT ); Tue, 8 Jul 2014 09:11:46 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:15944 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754784AbaGHNLo (ORCPT ); Tue, 8 Jul 2014 09:11:44 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N8E002989ZI6530@mailout3.samsung.com>; Tue, 08 Jul 2014 22:11:42 +0900 (KST) X-AuditID: cbfee61a-f79e46d00000134f-f8-53bbee0ea6e6 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id B7.8D.04943.E0EEBB35; Tue, 08 Jul 2014 22:11:42 +0900 (KST) Received: from amdc1032.localnet ([106.116.147.136]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N8E00HP39ZAWT20@mmp2.samsung.com>; Tue, 08 Jul 2014 22:11:42 +0900 (KST) From: Bartlomiej Zolnierkiewicz To: Eduardo Valentin Cc: Zhang Rui , Amit Daniel Kachhap , Kyungmin Park , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] thermal: exynos: fix ordering in exynos_tmu_remove() Date: Tue, 08 Jul 2014 15:09:56 +0200 Message-id: <10113119.9fnj2984Hk@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-54-generic-pae; KDE/4.8.5; i686; ; ) MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsVy+t9jQV2+d7uDDX51y1s0XA2xWLP/J5PF 2aY37BaXd81hs/jce4TRYsb5fUwWTx72sTmweyze85LJo2/LKkaP4ze2M3l83iQXwBLFZZOS mpNZllqkb5fAlfFgziaWggPsFc/O72VtYNzD1sXIySEhYCJxc/pSZghbTOLCvfVAcS4OIYHp jBIf+p8wQjgtTBKr3i9jBKliE7CSmNi+CswWEdCTuPHiCROIzSxwj1Gib7kBiC0s4Cpx//kE FhCbRUBV4v3GnawgNq+AlkTTialgcVEBT4kd21eyQcQFJX5MvscCMUdeYt/+qawQtpbE+p3H mSYw8s1CUjYLSdksJGULGJlXMYqmFiQXFCel5xrqFSfmFpfmpesl5+duYgSH6jOpHYwrGywO MQpwMCrx8K44uCtYiDWxrLgy9xCjBAezkgjvl1O7g4V4UxIrq1KL8uOLSnNSiw8xSnOwKInz Hmi1DhQSSE8sSc1OTS1ILYLJMnFwSjUwdnw0mZUyc0bX7RxxI5vlt7s92H8oKC/ZusW2fab8 WsHCd1OnpRVNzDgiX7CufPXDM97ptZn8au/WdTzZYJ/xNlIh8prPnUfzOJ+ebrp2ytVlHf+j YGXOy18q2it2r3wWPGNKm0mKf5oMY5vABRdxf4/61Z/YtXjupG2NWXT0wzGGYG2PecXdSizF GYmGWsxFxYkAsz4uzlECAAA= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It might not be a problem currently but unregister/uninitialize things in the reverse order that they are registered/initialized. Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Kyungmin Park Reviewed-by: Amit Daniel Kachhap --- drivers/thermal/samsung/exynos_tmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index d7ca9f4..6243ba0 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -759,10 +759,10 @@ static int exynos_tmu_remove(struct platform_device *pdev) { struct exynos_tmu_data *data = platform_get_drvdata(pdev); - exynos_tmu_control(pdev, false); - exynos_unregister_thermal(data->reg_conf); + exynos_tmu_control(pdev, false); + clk_unprepare(data->clk); if (!IS_ERR(data->clk_sec)) clk_unprepare(data->clk_sec);