diff mbox

ARM: S5PV210: Fix early uart output in fifo mode

Message ID 1360328454-20321-1-git-send-email-agalakhov@gmail.com
State New, archived
Headers show

Commit Message

Alexey Galakhov Feb. 8, 2013, 1 p.m. UTC
Enabling UART FIFO in bootloader caused the kernel infinite
loop on S5PV210 due to uninitialized fifo_max and fifo_mask global
variables. This patch adds the correct initialization.

Signed-off-by: Alexey Galakhov <agalakhov@gmail.com>
---
 arch/arm/mach-s5pv210/include/mach/uncompress.h |    2 ++
 1 file changed, 2 insertions(+)

Comments

Kim Kukjin Feb. 8, 2013, 10:48 p.m. UTC | #1
Alexey Galakhov wrote:
> 
> Enabling UART FIFO in bootloader caused the kernel infinite
> loop on S5PV210 due to uninitialized fifo_max and fifo_mask global
> variables. This patch adds the correct initialization.
> 
> Signed-off-by: Alexey Galakhov <agalakhov@gmail.com>
> ---
>  arch/arm/mach-s5pv210/include/mach/uncompress.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-s5pv210/include/mach/uncompress.h
> b/arch/arm/mach-s5pv210/include/mach/uncompress.h
> index 08ff2fd..ef977ea 100644
> --- a/arch/arm/mach-s5pv210/include/mach/uncompress.h
> +++ b/arch/arm/mach-s5pv210/include/mach/uncompress.h
> @@ -19,6 +19,8 @@
>  static void arch_detect_cpu(void)
>  {
>  	/* we do not need to do any cpu detection here at the moment. */
> +	fifo_mask = S5PV210_UFSTAT_TXMASK;
> +	fifo_max = 63 << S5PV210_UFSTAT_TXSHIFT;
>  }
> 
>  #endif /* __ASM_ARCH_UNCOMPRESS_H */
> --
> 1.7.10.4

Applied, thanks.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-s5pv210/include/mach/uncompress.h b/arch/arm/mach-s5pv210/include/mach/uncompress.h
index 08ff2fd..ef977ea 100644
--- a/arch/arm/mach-s5pv210/include/mach/uncompress.h
+++ b/arch/arm/mach-s5pv210/include/mach/uncompress.h
@@ -19,6 +19,8 @@ 
 static void arch_detect_cpu(void)
 {
 	/* we do not need to do any cpu detection here at the moment. */
+	fifo_mask = S5PV210_UFSTAT_TXMASK;
+	fifo_max = 63 << S5PV210_UFSTAT_TXSHIFT;
 }
 
 #endif /* __ASM_ARCH_UNCOMPRESS_H */