diff mbox

S3C24XX: remove unneeded "config SMDK2440_CPU2442"

Message ID 1363778011.1390.96.camel@x61.thuisdomein (mailing list archive)
State New, archived
Headers show

Commit Message

Paul Bolle March 20, 2013, 11:13 a.m. UTC
The Kconfig entry for SMDK2440_CPU2442 was moved from one Kconfig file
to another in commit acf2d41d8595829eb0ac7bf6891f4875a78d4d6e ("ARM:
S3C24XX: Move mach-s3c2440/ pll into mach-s3c24xx/"). In that move it
also lost its statement to select CPU_S3C2442. That was not needed
anymore because it now depended on that same symbol.

But without its select this entry became a nop: enabling it has no
effect, as it changes no code. It can safely be removed.

Fix a related, and trivial, comment typo too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.

 arch/arm/mach-s3c24xx/Kconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Kim Kukjin March 25, 2013, 1:08 a.m. UTC | #1
Paul Bolle wrote:
> 
> The Kconfig entry for SMDK2440_CPU2442 was moved from one Kconfig file
> to another in commit acf2d41d8595829eb0ac7bf6891f4875a78d4d6e ("ARM:
> S3C24XX: Move mach-s3c2440/ pll into mach-s3c24xx/"). In that move it
> also lost its statement to select CPU_S3C2442. That was not needed
> anymore because it now depended on that same symbol.
> 
> But without its select this entry became a nop: enabling it has no
> effect, as it changes no code. It can safely be removed.
> 
> Fix a related, and trivial, comment typo too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
> 
>  arch/arm/mach-s3c24xx/Kconfig | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
> index 37f513d..92c07a2 100644
> --- a/arch/arm/mach-s3c24xx/Kconfig
> +++ b/arch/arm/mach-s3c24xx/Kconfig
> @@ -663,10 +663,7 @@ config MACH_RX1950
>  	help
>  	   Say Y here if you're using HP iPAQ rx1950
> 
> -config SMDK2440_CPU2442
> -	bool "SMDM2440 with S3C2442 CPU module"
> -
> -endif	# CPU_S3C2440
> +endif	# CPU_S3C2442
> 
>  if CPU_S3C2443 || CPU_S3C2416
> 
> --
> 1.7.11.7

Looks good to me, applied.

Thanks.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 37f513d..92c07a2 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -663,10 +663,7 @@  config MACH_RX1950
 	help
 	   Say Y here if you're using HP iPAQ rx1950
 
-config SMDK2440_CPU2442
-	bool "SMDM2440 with S3C2442 CPU module"
-
-endif	# CPU_S3C2440
+endif	# CPU_S3C2442
 
 if CPU_S3C2443 || CPU_S3C2416