From patchwork Wed Mar 27 23:39:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Spang X-Patchwork-Id: 2353691 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 98ED2DFE82 for ; Wed, 27 Mar 2013 23:40:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754236Ab3C0XkE (ORCPT ); Wed, 27 Mar 2013 19:40:04 -0400 Received: from mail-qa0-f74.google.com ([209.85.216.74]:54551 "EHLO mail-qa0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753941Ab3C0XkD (ORCPT ); Wed, 27 Mar 2013 19:40:03 -0400 Received: by mail-qa0-f74.google.com with SMTP id k4so208633qaq.1 for ; Wed, 27 Mar 2013 16:40:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=CF1QvUYyAjI2ezdnCug5Ww5GpGehpCgdfMOH5rKTeFI=; b=nmvY4JKb5OEfWwK+X/W1D5sbv8qKaAq+4UxSfLNjfCkzVCArKVsrn4KUhoWHv+ZLYN K0KWAQRILL/n2rvOil1WMKIDBcKvp+/sbqBBPxVlldOAp3ngk7x7uressW7YhnB/Mvy+ qMX94NjmkE0ChS6YEE1FaC0vEEEsj6DiDThpRXLifuEQdCcfHxsNKYhkB7sxLNHucXnf JRtUZ8NGaUTyGzO+77L92VPPW2vTtH0cFdY+9zb+8VnbUuNF8fH1BoV+tjUKrMx/SnXj wLzAC8wIRbHx6G6buWP39IJa8vaWCTmjY8nC4DUVLwy5ItznahTj8SUVrU2S+xhkTcAZ RpNw== X-Received: by 10.224.18.132 with SMTP id w4mr12765584qaa.1.1364427602435; Wed, 27 Mar 2013 16:40:02 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id f2si3443533qcv.1.2013.03.27.16.40.02 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Wed, 27 Mar 2013 16:40:02 -0700 (PDT) Received: from xtahua.wat.corp.google.com (xtahua.wat.corp.google.com [172.23.176.177]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 0FEFD31C228; Wed, 27 Mar 2013 16:40:02 -0700 (PDT) Received: by xtahua.wat.corp.google.com (Postfix, from userid 81778) id 884911E093A; Wed, 27 Mar 2013 19:40:01 -0400 (EDT) From: Michael Spang To: Kukjin Kim , Ben Dooks Cc: Russell King , Abhilash Kesavan , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Spang Subject: [PATCH] serial: samsung: Use printk instead of printascii for S3C_PMDBG Date: Wed, 27 Mar 2013 19:39:58 -0400 Message-Id: <1364427598-17899-1-git-send-email-spang@chromium.org> X-Mailer: git-send-email 1.8.1.3 X-Gm-Message-State: ALoCoQnTWAXsOh8HD4tyygSGg/JL1aKlwb6I3waaxI1Zz/2oUr/AEK/GfNEwAlSgIGnKHbbr6gzdqf8ZMHaxMXyQOhnP34IvOGcHobCiPzBNURPsnfupE4sDFkusT1pMCZ8iFw69t6wdCMjAUEZrKSKuaZFMsidkwwoMgD4BmT9zKtSKa8HrHO56ufSRwa8Z5tv2O3l5vT27TKUkrhZApPvr1wJJIbbcHQ== Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Users should use no_console_suspend if they want output during suspend, rather than relying on DEBUG_LL. Using DEBUG_LL has two disadvantages: 1. It doesn't respect power management. When the UART is suspended the clock is stopped, and trying to use DEBUG_LL will just hang. This means if the user selects CONFIG_SAMSUNG_PM_DEBUG but does NOT disable console suspend, the system will hang during suspend. 2. It skips syslog and other console devices such as pstore. Signed-off-by: Michael Spang --- arch/arm/plat-samsung/include/plat/pm.h | 14 -------------- arch/arm/plat-samsung/pm.c | 13 ------------- 2 files changed, 27 deletions(-) diff --git a/arch/arm/plat-samsung/include/plat/pm.h b/arch/arm/plat-samsung/include/plat/pm.h index f6fcade..6d6e2a8 100644 --- a/arch/arm/plat-samsung/include/plat/pm.h +++ b/arch/arm/plat-samsung/include/plat/pm.h @@ -116,21 +116,7 @@ extern int s3c_irqext_wake(struct irq_data *data, unsigned int state); /* PM debug functions */ -#ifdef CONFIG_SAMSUNG_PM_DEBUG -/** - * s3c_pm_dbg() - low level debug function for use in suspend/resume. - * @msg: The message to print. - * - * This function is used mainly to debug the resume process before the system - * can rely on printk/console output. It uses the low-level debugging output - * routine printascii() to do its work. - */ -extern void s3c_pm_dbg(const char *msg, ...); - -#define S3C_PMDBG(fmt...) s3c_pm_dbg(fmt) -#else #define S3C_PMDBG(fmt...) printk(KERN_DEBUG fmt) -#endif #ifdef CONFIG_S3C_PM_DEBUG_LED_SMDK /** diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c index 002b147..7459fc6 100644 --- a/arch/arm/plat-samsung/pm.c +++ b/arch/arm/plat-samsung/pm.c @@ -43,19 +43,6 @@ unsigned long s3c_pm_flags; */ #ifdef CONFIG_SAMSUNG_PM_DEBUG -extern void printascii(const char *); - -void s3c_pm_dbg(const char *fmt, ...) -{ - va_list va; - char buff[256]; - - va_start(va, fmt); - vsnprintf(buff, sizeof(buff), fmt, va); - va_end(va); - - printascii(buff); -} static inline void s3c_pm_debug_init(void) {