| Message ID | 1371036526-16589-3-git-send-email-amit.daniel@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Amit Daniel Kachhap wrote: > > This patch registers the basic C0 state for all exynos SOC's but > limits the C1(AFTR -Arm off top running) state in only the supported > SOC's(ie. EXYNOS 4210, 4212, 4412 and 5250). > > Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com> > --- > arch/arm/mach-exynos/cpuidle.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach- > exynos/cpuidle.c > index 2d071c6..ccb2b48 100644 > --- a/arch/arm/mach-exynos/cpuidle.c > +++ b/arch/arm/mach-exynos/cpuidle.c > @@ -176,7 +176,9 @@ static int __init exynos4_init_cpuidle(void) > device->cpu = cpu_id; > > /* Support IDLE only */ > - if (cpu_id != 0) > + if (!(soc_is_exynos4210() || soc_is_exynos4212() || > + soc_is_exynos4412() || soc_is_exynos5250()) || > + cpu_id != 0) How about exynos5420? So... + if (soc_is_exynos5440() || cpu_id !=0) ? > device->state_count = 1; > > ret = cpuidle_register_device(device); > -- > 1.7.1 - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Jul 24, 2013 at 10:45 AM, Kukjin Kim <kgene@kernel.org> wrote: > Amit Daniel Kachhap wrote: >> >> This patch registers the basic C0 state for all exynos SOC's but >> limits the C1(AFTR -Arm off top running) state in only the supported >> SOC's(ie. EXYNOS 4210, 4212, 4412 and 5250). >> >> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com> >> --- >> arch/arm/mach-exynos/cpuidle.c | 4 +++- >> 1 files changed, 3 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach- >> exynos/cpuidle.c >> index 2d071c6..ccb2b48 100644 >> --- a/arch/arm/mach-exynos/cpuidle.c >> +++ b/arch/arm/mach-exynos/cpuidle.c >> @@ -176,7 +176,9 @@ static int __init exynos4_init_cpuidle(void) >> device->cpu = cpu_id; >> >> /* Support IDLE only */ >> - if (cpu_id != 0) >> + if (!(soc_is_exynos4210() || soc_is_exynos4212() || >> + soc_is_exynos4412() || soc_is_exynos5250()) || >> + cpu_id != 0) > > How about exynos5420? > > So... > > + if (soc_is_exynos5440() || cpu_id !=0) ? This is fine. Thanks, Amit > >> device->state_count = 1; >> >> ret = cpuidle_register_device(device); >> -- >> 1.7.1 > > - Kukjin > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
amit daniel kachhap wrote: [...] > >> /* Support IDLE only */ > >> - if (cpu_id != 0) > >> + if (!(soc_is_exynos4210() || soc_is_exynos4212() || > >> + soc_is_exynos4412() || soc_is_exynos5250()) || > >> + cpu_id != 0) > > > > How about exynos5420? > > > > So... > > > > + if (soc_is_exynos5440() || cpu_id !=0) ? > This is fine. > So, you will re-send? - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 24, 2013 at 1:06 PM, Kukjin Kim <kgene@kernel.org> wrote: > amit daniel kachhap wrote: > > [...] > >> >> /* Support IDLE only */ >> >> - if (cpu_id != 0) >> >> + if (!(soc_is_exynos4210() || soc_is_exynos4212() || >> >> + soc_is_exynos4412() || soc_is_exynos5250()) || >> >> + cpu_id != 0) >> > >> > How about exynos5420? >> > >> > So... >> > >> > + if (soc_is_exynos5440() || cpu_id !=0) ? >> This is fine. >> > So, you will re-send? Just submitted the patch with this change. Thanks, Amit > > - Kukjin > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 2d071c6..ccb2b48 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c @@ -176,7 +176,9 @@ static int __init exynos4_init_cpuidle(void) device->cpu = cpu_id; /* Support IDLE only */ - if (cpu_id != 0) + if (!(soc_is_exynos4210() || soc_is_exynos4212() || + soc_is_exynos4412() || soc_is_exynos5250()) || + cpu_id != 0) device->state_count = 1; ret = cpuidle_register_device(device);
This patch registers the basic C0 state for all exynos SOC's but limits the C1(AFTR -Arm off top running) state in only the supported SOC's(ie. EXYNOS 4210, 4212, 4412 and 5250). Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com> --- arch/arm/mach-exynos/cpuidle.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)