| Message ID | 1371143144-31764-1-git-send-email-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > It's convenient if get_maintainer suggests sending samsung/exynos > pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry for > that. Well, if we are already at it, we could list the actual maintainers of the driver. The original maintainer was Thomas Abraham <thomas.abraham@linaro.org> (added to CC) and after joining to development of this driver last year I have become a de facto maintainer as well, so... > Signed-off-by: Doug Anderson <dianders@chromium.org> > --- > MAINTAINERS | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8d97b3e..d026e38 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6284,6 +6284,16 @@ L: linux-arm-kernel@lists.infradead.org > (moderated for non-subscribers) S: Maintained > F: drivers/pinctrl/pinctrl-at91.c > > +PIN CONTROLLER - SAMSUNG > +M: Linus Walleij <linus.walleij@linaro.org> > +M: Kukjin Kim <kgene.kim@samsung.com> So actually this would be: M: Thomas Abraham <thomas.abraham@linaro.org> M: Tomasz Figa <t.figa@samsung.com> Thomas, do you agree on this? Best regards, Tomasz > +L: linux-arm-kernel@lists.infradead.org (moderated for non- subscribers) > +L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers) > +S: Maintained > +F: drivers/pinctrl/pinctrl-exynos.* > +F: drivers/pinctrl/pinctrl-s3c* > +F: drivers/pinctrl/pinctrl-samsung.* > + > PIN CONTROLLER - ST SPEAR > M: Viresh Kumar <viresh.linux@gmail.com> > L: spear-devel@list.st.com -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Tomasz, On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: >> It's convenient if get_maintainer suggests sending samsung/exynos >> pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry for >> that. > > Well, if we are already at it, we could list the actual maintainers of the > driver. > > The original maintainer was Thomas Abraham <thomas.abraham@linaro.org> > (added to CC) and after joining to development of this driver last year I > have become a de facto maintainer as well, so... > >> Signed-off-by: Doug Anderson <dianders@chromium.org> >> --- >> MAINTAINERS | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 8d97b3e..d026e38 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -6284,6 +6284,16 @@ L: linux-arm-kernel@lists.infradead.org >> (moderated for non-subscribers) S: Maintained >> F: drivers/pinctrl/pinctrl-at91.c >> >> +PIN CONTROLLER - SAMSUNG >> +M: Linus Walleij <linus.walleij@linaro.org> >> +M: Kukjin Kim <kgene.kim@samsung.com> > > So actually this would be: > M: Thomas Abraham <thomas.abraham@linaro.org> > M: Tomasz Figa <t.figa@samsung.com> > > Thomas, do you agree on this? Ah. Wasn't sure where the official maintainership should lie. ;) If Thomas is happy with this then I'll spin and re-send. Shall I remove Kukjin and Linus, then? It's convenient to have Linus on the list since he tends to be the one applying the patches... -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > Tomasz, > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > >> It's convenient if get_maintainer suggests sending samsung/exynos > >> pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry for > >> that. > > > > Well, if we are already at it, we could list the actual maintainers of > > the driver. > > > > The original maintainer was Thomas Abraham <thomas.abraham@linaro.org> > > (added to CC) and after joining to development of this driver last > > year I have become a de facto maintainer as well, so... > > > >> Signed-off-by: Doug Anderson <dianders@chromium.org> > >> --- > >> > >> MAINTAINERS | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 8d97b3e..d026e38 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -6284,6 +6284,16 @@ L: linux-arm-kernel@lists.infradead.org > >> (moderated for non-subscribers) S: Maintained > >> > >> F: drivers/pinctrl/pinctrl-at91.c > >> > >> +PIN CONTROLLER - SAMSUNG > >> +M: Linus Walleij <linus.walleij@linaro.org> > >> +M: Kukjin Kim <kgene.kim@samsung.com> > > > > So actually this would be: > > M: Thomas Abraham <thomas.abraham@linaro.org> > > M: Tomasz Figa <t.figa@samsung.com> > > > > Thomas, do you agree on this? > > Ah. Wasn't sure where the official maintainership should lie. ;) If > Thomas is happy with this then I'll spin and re-send. Shall I remove > Kukjin and Linus, then? It's convenient to have Linus on the list > since he tends to be the one applying the patches... From my understanding how it works, there is no need to list Linus in particular drivers, because he's already listed as a maintainer of the whole pinctrl subsystem and get-maintainer accounts for this. Similarly for Kukjin, he's listed as the main Samsung maintainer already, but AFAIK in this case the script can't infer this based on directory structure. Let's see how it's done for other Samsung drivers: DRM DRIVERS FOR EXYNOS M: Inki Dae <inki.dae@samsung.com> M: Joonyoung Shim <jy0922.shim@samsung.com> M: Seung-Woo Kim <sw0312.kim@samsung.com> M: Kyungmin Park <kyungmin.park@samsung.com> L: dri-devel@lists.freedesktop.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm- exynos.git S: Supported F: drivers/gpu/drm/exynos F: include/drm/exynos* F: include/uapi/drm/exynos* EXYNOS DP DRIVER M: Jingoo Han <jg1.han@samsung.com> L: linux-fbdev@vger.kernel.org S: Maintained F: drivers/video/exynos/exynos_dp* F: include/video/exynos_dp* EXYNOS MIPI DISPLAY DRIVERS M: Inki Dae <inki.dae@samsung.com> M: Donghwa Lee <dh09.lee@samsung.com> M: Kyungmin Park <kyungmin.park@samsung.com> L: linux-fbdev@vger.kernel.org S: Maintained F: drivers/video/exynos/exynos_mipi* F: include/video/exynos_mipi* ARM/SAMSUNG S5P SERIES 2D GRAPHICS ACCELERATION (G2D) SUPPORT M: Kyungmin Park <kyungmin.park@samsung.com> M: Kamil Debski <k.debski@samsung.com> L: linux-arm-kernel@lists.infradead.org L: linux-media@vger.kernel.org S: Maintained F: drivers/media/platform/s5p-g2d/ and so on. So I think, based on this precedent, we can do the same for pinctrl. Let's wait to see Thomas' view on this. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2013-06-13 at 19:32 +0200, Tomasz Figa wrote: [] > Similarly for Kukjin, he's listed as the main Samsung maintainer already, > but AFAIK in this case the script can't infer this based on directory > structure. Let's see how it's done for other Samsung drivers: A pattern could be added that matches any file with "exynos" in it. N: Files and directories with regex patterns. N: [^a-z]tegra all files whose path contains the word tegra One pattern per line. Multiple N: lines acceptable. like: N: exynos or N: drivers/pinctrl/.*exynos -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jun 13, 2013 at 7:25 PM, Doug Anderson <dianders@chromium.org> wrote: >>> +PIN CONTROLLER - SAMSUNG >>> +M: Linus Walleij <linus.walleij@linaro.org> >>> +M: Kukjin Kim <kgene.kim@samsung.com> >> >> So actually this would be: >> M: Thomas Abraham <thomas.abraham@linaro.org> >> M: Tomasz Figa <t.figa@samsung.com> >> >> Thomas, do you agree on this? > > Ah. Wasn't sure where the official maintainership should lie. ;) If > Thomas is happy with this then I'll spin and re-send. Shall I remove > Kukjin and Linus, then? It's convenient to have Linus on the list > since he tends to be the one applying the patches... Check what output you get from scripts/get-maintainer before and after this patch. I don't know how it works but I think I will end up on this list anyway due to the way the bigger regex for the subsystem works. I.e. this: PIN CONTROL SUBSYSTEM M: Linus Walleij <linus.walleij@linaro.org> S: Maintained F: drivers/pinctrl/ F: include/linux/pinctrl/ Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > > Tomasz, > > > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa <tomasz.figa@gmail.com> > wrote: > > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > > >> It's convenient if get_maintainer suggests sending samsung/exynos > > >> pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry for > > >> that. > > > > > > Well, if we are already at it, we could list the actual maintainers of > > > the driver. > > > > > > The original maintainer was Thomas Abraham <thomas.abraham@linaro.org> > > > (added to CC) and after joining to development of this driver last > > > year I have become a de facto maintainer as well, so... > > > > > >> Signed-off-by: Doug Anderson <dianders@chromium.org> > > >> --- > > >> > > >> MAINTAINERS | 10 ++++++++++ > > >> 1 file changed, 10 insertions(+) > > >> > > >> diff --git a/MAINTAINERS b/MAINTAINERS > > >> index 8d97b3e..d026e38 100644 > > >> --- a/MAINTAINERS > > >> +++ b/MAINTAINERS > > >> @@ -6284,6 +6284,16 @@ L: linux-arm-kernel@lists.infradead.org > > >> (moderated for non-subscribers) S: Maintained > > >> > > >> F: drivers/pinctrl/pinctrl-at91.c > > >> > > >> +PIN CONTROLLER - SAMSUNG > > >> +M: Linus Walleij <linus.walleij@linaro.org> > > >> +M: Kukjin Kim <kgene.kim@samsung.com> > > > > > > So actually this would be: > > > M: Thomas Abraham <thomas.abraham@linaro.org> > > > M: Tomasz Figa <t.figa@samsung.com> > > > > > > Thomas, do you agree on this? > > > > Ah. Wasn't sure where the official maintainership should lie. ;) If > > Thomas is happy with this then I'll spin and re-send. Shall I remove > > Kukjin and Linus, then? It's convenient to have Linus on the list > > since he tends to be the one applying the patches... > > From my understanding how it works, there is no need to list Linus in > particular drivers, because he's already listed as a maintainer of the > whole pinctrl subsystem and get-maintainer accounts for this. > > Similarly for Kukjin, he's listed as the main Samsung maintainer already, If so, the directory like pinctrl should be added under Samsung ARM Architectures like spi and sound for Samsung stuff... > but AFAIK in this case the script can't infer this based on directory > structure. Let's see how it's done for other Samsung drivers: > Well, I don't think so, because pinctrl has the close relationship with exynos arch part and it's little bit different with following. Just in my understanding. > DRM DRIVERS FOR EXYNOS > M: Inki Dae <inki.dae@samsung.com> > M: Joonyoung Shim <jy0922.shim@samsung.com> > M: Seung-Woo Kim <sw0312.kim@samsung.com> > M: Kyungmin Park <kyungmin.park@samsung.com> > L: dri-devel@lists.freedesktop.org > T: git git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm- > exynos.git > S: Supported > F: drivers/gpu/drm/exynos > F: include/drm/exynos* > F: include/uapi/drm/exynos* > > EXYNOS DP DRIVER > M: Jingoo Han <jg1.han@samsung.com> > L: linux-fbdev@vger.kernel.org > S: Maintained > F: drivers/video/exynos/exynos_dp* > F: include/video/exynos_dp* > > EXYNOS MIPI DISPLAY DRIVERS > M: Inki Dae <inki.dae@samsung.com> > M: Donghwa Lee <dh09.lee@samsung.com> > M: Kyungmin Park <kyungmin.park@samsung.com> > L: linux-fbdev@vger.kernel.org > S: Maintained > F: drivers/video/exynos/exynos_mipi* > F: include/video/exynos_mipi* > > ARM/SAMSUNG S5P SERIES 2D GRAPHICS ACCELERATION (G2D) SUPPORT > M: Kyungmin Park <kyungmin.park@samsung.com> > M: Kamil Debski <k.debski@samsung.com> > L: linux-arm-kernel@lists.infradead.org > L: linux-media@vger.kernel.org > S: Maintained > F: drivers/media/platform/s5p-g2d/ > And I'm asking above all guys _really_ do review and maintaining the file or directories? I don't think so. > and so on. > > So I think, based on this precedent, we can do the same for pinctrl. Let's > wait to see Thomas' view on this. > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: > Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > > > Tomasz, > > > > > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa > > > <tomasz.figa@gmail.com> > > > > wrote: > > > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > > > >> It's convenient if get_maintainer suggests sending samsung/exynos > > > >> pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry > > > >> for > > > >> that. > > > > > > > > Well, if we are already at it, we could list the actual > > > > maintainers of > > > > the driver. > > > > > > > > The original maintainer was Thomas Abraham > > > > <thomas.abraham@linaro.org> > > > > (added to CC) and after joining to development of this driver last > > > > year I have become a de facto maintainer as well, so... > > > > > > > >> Signed-off-by: Doug Anderson <dianders@chromium.org> > > > >> --- > > > >> > > > >> MAINTAINERS | 10 ++++++++++ > > > >> 1 file changed, 10 insertions(+) > > > >> > > > >> diff --git a/MAINTAINERS b/MAINTAINERS > > > >> index 8d97b3e..d026e38 100644 > > > >> --- a/MAINTAINERS > > > >> +++ b/MAINTAINERS > > > >> @@ -6284,6 +6284,16 @@ L: > > > >> linux-arm-kernel@lists.infradead.org > > > >> (moderated for non-subscribers) S: Maintained > > > >> > > > >> F: drivers/pinctrl/pinctrl-at91.c > > > >> > > > >> +PIN CONTROLLER - SAMSUNG > > > >> +M: Linus Walleij <linus.walleij@linaro.org> > > > >> +M: Kukjin Kim <kgene.kim@samsung.com> > > > > > > > > So actually this would be: > > > > M: Thomas Abraham <thomas.abraham@linaro.org> > > > > M: Tomasz Figa <t.figa@samsung.com> > > > > > > > > Thomas, do you agree on this? > > > > > > Ah. Wasn't sure where the official maintainership should lie. ;) > > > If > > > Thomas is happy with this then I'll spin and re-send. Shall I > > > remove > > > Kukjin and Linus, then? It's convenient to have Linus on the list > > > since he tends to be the one applying the patches... > > > > From my understanding how it works, there is no need to list Linus in > > particular drivers, because he's already listed as a maintainer of the > > whole pinctrl subsystem and get-maintainer accounts for this. > > > > Similarly for Kukjin, he's listed as the main Samsung maintainer > > already, > If so, the directory like pinctrl should be added under Samsung ARM > Architectures like spi and sound for Samsung stuff... I don't think so, because it's a part of the pin control subsystem. > > but AFAIK in this case the script can't infer this based on directory > > > structure. Let's see how it's done for other Samsung drivers: > Well, I don't think so, because pinctrl has the close relationship with > exynos arch part and it's little bit different with following. Just in > my understanding. I'm not really sure what you mean. Pin control is a separate kernel subsystem, which shouldn't have any dependencies on arch code. > > DRM DRIVERS FOR EXYNOS > > M: Inki Dae <inki.dae@samsung.com> > > M: Joonyoung Shim <jy0922.shim@samsung.com> > > M: Seung-Woo Kim <sw0312.kim@samsung.com> > > M: Kyungmin Park <kyungmin.park@samsung.com> > > L: dri-devel@lists.freedesktop.org > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm- > > exynos.git > > S: Supported > > F: drivers/gpu/drm/exynos > > F: include/drm/exynos* > > F: include/uapi/drm/exynos* > > > > EXYNOS DP DRIVER > > M: Jingoo Han <jg1.han@samsung.com> > > L: linux-fbdev@vger.kernel.org > > S: Maintained > > F: drivers/video/exynos/exynos_dp* > > F: include/video/exynos_dp* > > > > EXYNOS MIPI DISPLAY DRIVERS > > M: Inki Dae <inki.dae@samsung.com> > > M: Donghwa Lee <dh09.lee@samsung.com> > > M: Kyungmin Park <kyungmin.park@samsung.com> > > L: linux-fbdev@vger.kernel.org > > S: Maintained > > F: drivers/video/exynos/exynos_mipi* > > F: include/video/exynos_mipi* > > > > ARM/SAMSUNG S5P SERIES 2D GRAPHICS ACCELERATION (G2D) SUPPORT > > M: Kyungmin Park <kyungmin.park@samsung.com> > > M: Kamil Debski <k.debski@samsung.com> > > L: linux-arm-kernel@lists.infradead.org > > L: linux-media@vger.kernel.org > > S: Maintained > > F: drivers/media/platform/s5p-g2d/ > > And I'm asking above all guys _really_ do review and maintaining the > file or directories? I don't think so. I'm not really sure what makes you think they don't. I can see all of them involved in works on mentioned drivers. Best regards, Tomasz > > and so on. > > > > So I think, based on this precedent, we can do the same for pinctrl. > > Let's wait to see Thomas' view on this. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > > It's convenient if get_maintainer suggests sending samsung/exynos > > pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry for > > that. > > Well, if we are already at it, we could list the actual maintainers of the > driver. > > The original maintainer was Thomas Abraham <thomas.abraham@linaro.org> Should be original author?! I think, original maintainer was/is Linus Walleij. Let's see, probably original author should have some knowledge for it but the meaning of the maintainer is different. Of course, would be helpful if original author could review and maintain... - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: > Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > > > Tomasz, > > > > > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa > > > <tomasz.figa@gmail.com> > > > > wrote: > > > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > > > >> It's convenient if get_maintainer suggests sending samsung/exynos > > > >> pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry > > > >> for > > > >> that. > > > > > > > > Well, if we are already at it, we could list the actual > > > > maintainers of > > > > the driver. > > > > > > > > The original maintainer was Thomas Abraham > > > > <thomas.abraham@linaro.org> > > > > (added to CC) and after joining to development of this driver last > > > > year I have become a de facto maintainer as well, so... > > > > > > > >> Signed-off-by: Doug Anderson <dianders@chromium.org> > > > >> --- > > > >> > > > >> MAINTAINERS | 10 ++++++++++ > > > >> 1 file changed, 10 insertions(+) > > > >> > > > >> diff --git a/MAINTAINERS b/MAINTAINERS > > > >> index 8d97b3e..d026e38 100644 > > > >> --- a/MAINTAINERS > > > >> +++ b/MAINTAINERS > > > >> @@ -6284,6 +6284,16 @@ L: > > > >> linux-arm-kernel@lists.infradead.org > > > >> (moderated for non-subscribers) S: Maintained > > > >> > > > >> F: drivers/pinctrl/pinctrl-at91.c > > > >> > > > >> +PIN CONTROLLER - SAMSUNG > > > >> +M: Linus Walleij <linus.walleij@linaro.org> > > > >> +M: Kukjin Kim <kgene.kim@samsung.com> > > > > > > > > So actually this would be: > > > > M: Thomas Abraham <thomas.abraham@linaro.org> > > > > M: Tomasz Figa <t.figa@samsung.com> > > > > > > > > Thomas, do you agree on this? > > > > > > Ah. Wasn't sure where the official maintainership should lie. ;) > > > If > > > Thomas is happy with this then I'll spin and re-send. Shall I > > > remove > > > Kukjin and Linus, then? It's convenient to have Linus on the list > > > since he tends to be the one applying the patches... > > > > From my understanding how it works, there is no need to list Linus in > > particular drivers, because he's already listed as a maintainer of the > > whole pinctrl subsystem and get-maintainer accounts for this. > > > > Similarly for Kukjin, he's listed as the main Samsung maintainer > > already, > If so, the directory like pinctrl should be added under Samsung ARM > Architectures like spi and sound for Samsung stuff... One more thing. As Joe Perches suggested, we might as well add N: exynos to ARM/S5P EXYNOS ARM ARCHITECTURE entry, but I'm not really sure if it's the right thing to do. Best regards, Tomasz > > but AFAIK in this case the script can't infer this based on directory > > > structure. Let's see how it's done for other Samsung drivers: > Well, I don't think so, because pinctrl has the close relationship with > exynos arch part and it's little bit different with following. Just in > my understanding. > > > DRM DRIVERS FOR EXYNOS > > M: Inki Dae <inki.dae@samsung.com> > > M: Joonyoung Shim <jy0922.shim@samsung.com> > > M: Seung-Woo Kim <sw0312.kim@samsung.com> > > M: Kyungmin Park <kyungmin.park@samsung.com> > > L: dri-devel@lists.freedesktop.org > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm- > > exynos.git > > S: Supported > > F: drivers/gpu/drm/exynos > > F: include/drm/exynos* > > F: include/uapi/drm/exynos* > > > > EXYNOS DP DRIVER > > M: Jingoo Han <jg1.han@samsung.com> > > L: linux-fbdev@vger.kernel.org > > S: Maintained > > F: drivers/video/exynos/exynos_dp* > > F: include/video/exynos_dp* > > > > EXYNOS MIPI DISPLAY DRIVERS > > M: Inki Dae <inki.dae@samsung.com> > > M: Donghwa Lee <dh09.lee@samsung.com> > > M: Kyungmin Park <kyungmin.park@samsung.com> > > L: linux-fbdev@vger.kernel.org > > S: Maintained > > F: drivers/video/exynos/exynos_mipi* > > F: include/video/exynos_mipi* > > > > ARM/SAMSUNG S5P SERIES 2D GRAPHICS ACCELERATION (G2D) SUPPORT > > M: Kyungmin Park <kyungmin.park@samsung.com> > > M: Kamil Debski <k.debski@samsung.com> > > L: linux-arm-kernel@lists.infradead.org > > L: linux-media@vger.kernel.org > > S: Maintained > > F: drivers/media/platform/s5p-g2d/ > > And I'm asking above all guys _really_ do review and maintaining the > file or directories? I don't think so. > > > and so on. > > > > So I think, based on this precedent, we can do the same for pinctrl. > > Let's wait to see Thomas' view on this. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Tomasz Figa wrote: > [...] > > > From my understanding how it works, there is no need to list Linus in > > > particular drivers, because he's already listed as a maintainer of the > > > whole pinctrl subsystem and get-maintainer accounts for this. > > > > > > Similarly for Kukjin, he's listed as the main Samsung maintainer > > > already, > > If so, the directory like pinctrl should be added under Samsung ARM > > Architectures like spi and sound for Samsung stuff... > > I don't think so, because it's a part of the pin control subsystem. > Yes right. I mean, pinctrl is clos > > > but AFAIK in this case the script can't infer this based on directory > > > > > structure. Let's see how it's done for other Samsung drivers: > > Well, I don't think so, because pinctrl has the close relationship with > > exynos arch part and it's little bit different with following. Just in > > my understanding. > > I'm not really sure what you mean. Pin control is a separate kernel > subsystem, which shouldn't have any dependencies on arch code. > Yes, right. I have no objection about it is a subsystem. I meant just relationship and it helps people find the overall architecture. [...] > > And I'm asking above all guys _really_ do review and maintaining the > > file or directories? I don't think so. > > I'm not really sure what makes you think they don't. I can see all of them > involved in works on mentioned drivers. > What's the role of maintainer? I mean, as you said, above guys are really do it... - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Kukjin Kim wrote: > > Tomasz Figa wrote: > > [...] > > > > And I'm asking above all guys _really_ do review and maintaining the > > > file or directories? I don't think so. > > > > I'm not really sure what makes you think they don't. I can see all of > them > > involved in works on mentioned drivers. > > > What's the role of maintainer? I mean, as you said, above guys are really > do it... > One more, I don't blame and I'm not saying it was wrong :) - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 14 of June 2013 07:47:15 Kukjin Kim wrote: > Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > > > It's convenient if get_maintainer suggests sending samsung/exynos > > > pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry > > > for > > > that. > > > > Well, if we are already at it, we could list the actual maintainers of > > the driver. > > > > The original maintainer was Thomas Abraham <thomas.abraham@linaro.org> > > Should be original author?! I think, original maintainer was/is Linus > Walleij. Linus is the maintainer of the pin control subsystem. In addition drivers can have their own maintainers, but of course they are lower in the hierarchy than subsystem maintainers. > Let's see, probably original author should have some knowledge for it > but the meaning of the maintainer is different. Of course, would be > helpful if original author could review and maintain... Maintainer is the person who takes care of the code, including testing, fixes, review of patches, but also development as well to keep the driver up to date with core code, improve things, add support for new hardware, etc. Originally Thomas Abraham was the person doing it for this driver. At least I remember, he was the person who reviewed and acked my patches when I started my work on improving this driver. Later on I took over most of those tasks and I've been doing so ever since that time. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 14 of June 2013 00:49:08 Tomasz Figa wrote: > On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: > > Tomasz Figa wrote: > > > On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > > > > Tomasz, > > > > > > > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa > > > > <tomasz.figa@gmail.com> > > > > > > wrote: > > > > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > > > > >> It's convenient if get_maintainer suggests sending > > > > >> samsung/exynos > > > > >> pinctrl changes to linux-samsung-soc and to Kukjin. Add an > > > > >> entry > > > > >> for > > > > >> that. > > > > > > > > > > Well, if we are already at it, we could list the actual > > > > > maintainers of > > > > > the driver. > > > > > > > > > > The original maintainer was Thomas Abraham > > > > > <thomas.abraham@linaro.org> > > > > > (added to CC) and after joining to development of this driver > > > > > last > > > > > year I have become a de facto maintainer as well, so... > > > > > > > > > >> Signed-off-by: Doug Anderson <dianders@chromium.org> > > > > >> --- > > > > >> > > > > >> MAINTAINERS | 10 ++++++++++ > > > > >> 1 file changed, 10 insertions(+) > > > > >> > > > > >> diff --git a/MAINTAINERS b/MAINTAINERS > > > > >> index 8d97b3e..d026e38 100644 > > > > >> --- a/MAINTAINERS > > > > >> +++ b/MAINTAINERS > > > > >> @@ -6284,6 +6284,16 @@ L: > > > > >> linux-arm-kernel@lists.infradead.org > > > > >> (moderated for non-subscribers) S: Maintained > > > > >> > > > > >> F: drivers/pinctrl/pinctrl-at91.c > > > > >> > > > > >> +PIN CONTROLLER - SAMSUNG > > > > >> +M: Linus Walleij <linus.walleij@linaro.org> > > > > >> +M: Kukjin Kim <kgene.kim@samsung.com> > > > > > > > > > > So actually this would be: > > > > > M: Thomas Abraham <thomas.abraham@linaro.org> > > > > > M: Tomasz Figa <t.figa@samsung.com> > > > > > > > > > > Thomas, do you agree on this? > > > > > > > > Ah. Wasn't sure where the official maintainership should lie. ;) > > > > If > > > > Thomas is happy with this then I'll spin and re-send. Shall I > > > > remove > > > > Kukjin and Linus, then? It's convenient to have Linus on the list > > > > since he tends to be the one applying the patches... > > > > > > From my understanding how it works, there is no need to list Linus > > > in > > > particular drivers, because he's already listed as a maintainer of > > > the > > > whole pinctrl subsystem and get-maintainer accounts for this. > > > > > > Similarly for Kukjin, he's listed as the main Samsung maintainer > > > already, > > > > If so, the directory like pinctrl should be added under Samsung ARM > > Architectures like spi and sound for Samsung stuff... > > One more thing. > > As Joe Perches suggested, we might as well add > > N: exynos > > to ARM/S5P EXYNOS ARM ARCHITECTURE entry, but I'm not really sure if > it's the right thing to do. To clarify things a bit, I'm not against doing it. Just I don't think I'm the one to decide about it. Best regards, Tomasz > > > but AFAIK in this case the script can't infer this based on > > > directory > > > > > structure. Let's see how it's done for other Samsung drivers: > > Well, I don't think so, because pinctrl has the close relationship > > with > > exynos arch part and it's little bit different with following. Just in > > my understanding. > > > > > DRM DRIVERS FOR EXYNOS > > > M: Inki Dae <inki.dae@samsung.com> > > > M: Joonyoung Shim <jy0922.shim@samsung.com> > > > M: Seung-Woo Kim <sw0312.kim@samsung.com> > > > M: Kyungmin Park <kyungmin.park@samsung.com> > > > L: dri-devel@lists.freedesktop.org > > > T: git > > > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm- > > > exynos.git > > > S: Supported > > > F: drivers/gpu/drm/exynos > > > F: include/drm/exynos* > > > F: include/uapi/drm/exynos* > > > > > > EXYNOS DP DRIVER > > > M: Jingoo Han <jg1.han@samsung.com> > > > L: linux-fbdev@vger.kernel.org > > > S: Maintained > > > F: drivers/video/exynos/exynos_dp* > > > F: include/video/exynos_dp* > > > > > > EXYNOS MIPI DISPLAY DRIVERS > > > M: Inki Dae <inki.dae@samsung.com> > > > M: Donghwa Lee <dh09.lee@samsung.com> > > > M: Kyungmin Park <kyungmin.park@samsung.com> > > > L: linux-fbdev@vger.kernel.org > > > S: Maintained > > > F: drivers/video/exynos/exynos_mipi* > > > F: include/video/exynos_mipi* > > > > > > ARM/SAMSUNG S5P SERIES 2D GRAPHICS ACCELERATION (G2D) SUPPORT > > > M: Kyungmin Park <kyungmin.park@samsung.com> > > > M: Kamil Debski <k.debski@samsung.com> > > > L: linux-arm-kernel@lists.infradead.org > > > L: linux-media@vger.kernel.org > > > S: Maintained > > > F: drivers/media/platform/s5p-g2d/ > > > > And I'm asking above all guys _really_ do review and maintaining the > > file or directories? I don't think so. > > > > > and so on. > > > > > > So I think, based on this precedent, we can do the same for pinctrl. > > > Let's wait to see Thomas' view on this. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 14, 2013 at 1:03 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > On Friday 14 of June 2013 07:47:15 Kukjin Kim wrote: >> Tomasz Figa wrote: >> > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: >> > > It's convenient if get_maintainer suggests sending samsung/exynos >> > > pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry >> > > for >> > > that. >> > >> > Well, if we are already at it, we could list the actual maintainers of >> > the driver. >> > >> > The original maintainer was Thomas Abraham <thomas.abraham@linaro.org> >> >> Should be original author?! I think, original maintainer was/is Linus >> Walleij. > > Linus is the maintainer of the pin control subsystem. In addition drivers > can have their own maintainers, but of course they are lower in the > hierarchy than subsystem maintainers. Well I don't really like hiearchies, as I'm basically anarchist :-P Anyway, as long as the get-mainater script output both Thomas and my name I don't really care, the only practical intent with this file is to be able to mail the right people. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/MAINTAINERS b/MAINTAINERS index 8d97b3e..d026e38 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6284,6 +6284,16 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained F: drivers/pinctrl/pinctrl-at91.c +PIN CONTROLLER - SAMSUNG +M: Linus Walleij <linus.walleij@linaro.org> +M: Kukjin Kim <kgene.kim@samsung.com> +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) +L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers) +S: Maintained +F: drivers/pinctrl/pinctrl-exynos.* +F: drivers/pinctrl/pinctrl-s3c* +F: drivers/pinctrl/pinctrl-samsung.* + PIN CONTROLLER - ST SPEAR M: Viresh Kumar <viresh.linux@gmail.com> L: spear-devel@list.st.com
It's convenient if get_maintainer suggests sending samsung/exynos pinctrl changes to linux-samsung-soc and to Kukjin. Add an entry for that. Signed-off-by: Doug Anderson <dianders@chromium.org> --- MAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)