| Message ID | 1371214954-29358-4-git-send-email-l.krishna@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 14, 2013 at 3:02 PM, Leela Krishna Amudala <l.krishna@samsung.com> wrote: How does this topic: > Skip exynos5420 gpiolib registration if pinctrl support is enabled. (...) Correlate with that: > { .compatible = "samsung,exynos5250-pinctrl", }, > + { .compatible = "samsung,exynos5420-pinctrl", }, Sorry I don't get it. Should the subject not be "add compatible string for 5420" or something? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Linus, On Saturday 15 of June 2013 21:51:04 Linus Walleij wrote: > On Fri, Jun 14, 2013 at 3:02 PM, Leela Krishna Amudala > <l.krishna@samsung.com> wrote: > > How does this topic: > > Skip exynos5420 gpiolib registration if pinctrl support is enabled. > > (...) > > Correlate with that: > > { .compatible = "samsung,exynos5250-pinctrl", }, > > > > + { .compatible = "samsung,exynos5420-pinctrl", }, > > Sorry I don't get it. > > Should the subject not be "add compatible string for 5420" or > something? Hehe, based on the context it really does not make sense :) . But if you take a closer look, you can see that it's a list of compatible strings for which initialization of the old gpio driver should be bypassed. Best regards, Tomasz > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe > linux-samsung-soc" in the body of a message to > majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 14 of June 2013 18:32:34 Leela Krishna Amudala wrote: > Skip exynos5420 gpiolib registration if pinctrl support is enabled. > > Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com> > Reviewed-by: Doug Anderson <dianders@chromium.org> > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > --- > drivers/gpio/gpio-samsung.c | 1 + > 1 file changed, 1 insertion(+) This patch is not needed any more, because ARCH_EXYNOS does not select GPIO_SAMSUNG after cleanup patches I posted recently. Best regards, Tomasz > diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c > index 83a0d71..b3dd984 100644 > --- a/drivers/gpio/gpio-samsung.c > +++ b/drivers/gpio/gpio-samsung.c > @@ -3033,6 +3033,7 @@ static __init int samsung_gpiolib_init(void) > { .compatible = "samsung,exynos4210-pinctrl", }, > { .compatible = "samsung,exynos4x12-pinctrl", }, > { .compatible = "samsung,exynos5250-pinctrl", }, > + { .compatible = "samsung,exynos5420-pinctrl", }, > { .compatible = "samsung,exynos5440-pinctrl", }, > { } > }; -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c index 83a0d71..b3dd984 100644 --- a/drivers/gpio/gpio-samsung.c +++ b/drivers/gpio/gpio-samsung.c @@ -3033,6 +3033,7 @@ static __init int samsung_gpiolib_init(void) { .compatible = "samsung,exynos4210-pinctrl", }, { .compatible = "samsung,exynos4x12-pinctrl", }, { .compatible = "samsung,exynos5250-pinctrl", }, + { .compatible = "samsung,exynos5420-pinctrl", }, { .compatible = "samsung,exynos5440-pinctrl", }, { } };