| Message ID | 1374600763-19466-1-git-send-email-tobetter@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 23 July 2013 23:02, Dongjin Kim <tobetter@gmail.com> wrote: > This patch adds EHCI and OHCI host device nodes for Exynos4. > > Signed-off-by: Dongjin Kim <tobetter@gmail.com> > --- > arch/arm/boot/dts/exynos4.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 3f94fe8..1cdbf89 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -155,6 +155,26 @@ > status = "disabled"; > }; > > + ehci@12580000 { > + compatible = "samsung,exynos4210-ehci"; > + reg = <0x12580000 0x100>; > + interrupts = <0 70 0>; > + status = "disabled"; > + > + clocks = <&clock 304>; > + clock-names = "usbhost"; > + }; > + > + ohci@12590000 { > + compatible = "samsung,exynos4210-ohci"; > + reg = <0x12580000 0x100>; Register value and node name do not match. Typo? > + interrupts = <0 70 0>; > + status = "disabled"; > + > + clocks = <&clock 304>; > + clock-names = "usbhost"; > + }; > + > mfc: codec@13400000 { > compatible = "samsung,mfc-v5"; > reg = <0x13400000 0x10000>; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
+Jingoo Han Sorry, its my bad. Typo problem. I found another patch same with mine, https://patchwork.kernel.org/patch/2628451, submitted by Jingoo Han and tested on Exynos4210. Mine is tested on Exynos4412. Both SoC have same USB host address space, so I think USB host device nodes can be placed in exynos4.dtsi. Regards, Dongjin. On Wed, Jul 24, 2013 at 12:38 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > On 23 July 2013 23:02, Dongjin Kim <tobetter@gmail.com> wrote: >> This patch adds EHCI and OHCI host device nodes for Exynos4. >> >> Signed-off-by: Dongjin Kim <tobetter@gmail.com> >> --- >> arch/arm/boot/dts/exynos4.dtsi | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >> index 3f94fe8..1cdbf89 100644 >> --- a/arch/arm/boot/dts/exynos4.dtsi >> +++ b/arch/arm/boot/dts/exynos4.dtsi >> @@ -155,6 +155,26 @@ >> status = "disabled"; >> }; >> >> + ehci@12580000 { >> + compatible = "samsung,exynos4210-ehci"; >> + reg = <0x12580000 0x100>; >> + interrupts = <0 70 0>; >> + status = "disabled"; >> + >> + clocks = <&clock 304>; >> + clock-names = "usbhost"; >> + }; >> + >> + ohci@12590000 { >> + compatible = "samsung,exynos4210-ohci"; >> + reg = <0x12580000 0x100>; > > Register value and node name do not match. Typo? > > >> + interrupts = <0 70 0>; >> + status = "disabled"; >> + >> + clocks = <&clock 304>; >> + clock-names = "usbhost"; >> + }; >> + >> mfc: codec@13400000 { >> compatible = "samsung,mfc-v5"; >> reg = <0x13400000 0x10000>; >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > With warm regards, > Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday, July 24, 2013 3:29 PM, Dongjin Kim wrote: > > +Jingoo Han > > Sorry, its my bad. Typo problem. > > I found another patch same with mine, > https://patchwork.kernel.org/patch/2628451, submitted by Jingoo Han > and tested on Exynos4210. Mine is tested on Exynos4412. Both SoC have > same USB host address space, so I think USB host device nodes can be > placed in exynos4.dtsi. OK, USB host device nodes can be placed in exynos4.dtsi. However, next time, please leave comment on earlier patch. The patch for Exynos4210 USB was already submitted 2 months ago. > > Regards, > Dongjin. > > On Wed, Jul 24, 2013 at 12:38 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > > On 23 July 2013 23:02, Dongjin Kim <tobetter@gmail.com> wrote: > >> This patch adds EHCI and OHCI host device nodes for Exynos4. > >> > >> Signed-off-by: Dongjin Kim <tobetter@gmail.com> > >> --- > >> arch/arm/boot/dts/exynos4.dtsi | 20 ++++++++++++++++++++ > >> 1 file changed, 20 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > >> index 3f94fe8..1cdbf89 100644 > >> --- a/arch/arm/boot/dts/exynos4.dtsi > >> +++ b/arch/arm/boot/dts/exynos4.dtsi > >> @@ -155,6 +155,26 @@ > >> status = "disabled"; > >> }; > >> > >> + ehci@12580000 { > >> + compatible = "samsung,exynos4210-ehci"; > >> + reg = <0x12580000 0x100>; > >> + interrupts = <0 70 0>; > >> + status = "disabled"; > >> + > >> + clocks = <&clock 304>; > >> + clock-names = "usbhost"; > >> + }; > >> + > >> + ohci@12590000 { > >> + compatible = "samsung,exynos4210-ohci"; > >> + reg = <0x12580000 0x100>; > > > > Register value and node name do not match. Typo? > > > > > >> + interrupts = <0 70 0>; > >> + status = "disabled"; > >> + > >> + clocks = <&clock 304>; > >> + clock-names = "usbhost"; > >> + }; > >> + > >> mfc: codec@13400000 { > >> compatible = "samsung,mfc-v5"; > >> reg = <0x13400000 0x10000>; > >> -- > >> 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 3f94fe8..1cdbf89 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -155,6 +155,26 @@ status = "disabled"; }; + ehci@12580000 { + compatible = "samsung,exynos4210-ehci"; + reg = <0x12580000 0x100>; + interrupts = <0 70 0>; + status = "disabled"; + + clocks = <&clock 304>; + clock-names = "usbhost"; + }; + + ohci@12590000 { + compatible = "samsung,exynos4210-ohci"; + reg = <0x12580000 0x100>; + interrupts = <0 70 0>; + status = "disabled"; + + clocks = <&clock 304>; + clock-names = "usbhost"; + }; + mfc: codec@13400000 { compatible = "samsung,mfc-v5"; reg = <0x13400000 0x10000>;
This patch adds EHCI and OHCI host device nodes for Exynos4. Signed-off-by: Dongjin Kim <tobetter@gmail.com> --- arch/arm/boot/dts/exynos4.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)