From patchwork Mon Sep 16 05:31:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chander Kashyap X-Patchwork-Id: 2895501 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A11FB9F1BF for ; Mon, 16 Sep 2013 05:31:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C711A201D3 for ; Mon, 16 Sep 2013 05:31:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD238201C7 for ; Mon, 16 Sep 2013 05:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753831Ab3IPFbi (ORCPT ); Mon, 16 Sep 2013 01:31:38 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:64873 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384Ab3IPFbh (ORCPT ); Mon, 16 Sep 2013 01:31:37 -0400 Received: by mail-pd0-f180.google.com with SMTP id y10so3668784pdj.11 for ; Sun, 15 Sep 2013 22:31:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vQX6np2n0WrqFl3tjIk2dRqDlWWABnGBvy7RiDjZU4E=; b=KFc250uKgTOF70Nh2ln8lYrM0bVAS6JjDPxir9tnyHVLBgfIq5bTSZeAz5EAeIbHjD 4azz2FpY/bHDYVa78iJ6XVwPNt8pUQy24sGliJ9Z+nPqYnGWmgsaJXkrWcc1vfPEDzYM aRd7gt/gLmvFrafQHHoXGSCtuR+veBROVDprZo5d7Ly1fMWyHT1AdhoQMWZEF0eEz23x JMT3yWwWKbFsxLn7gAFf1KTUl97b7PccaQUCIB/NgIYosaHwZGl++v73iRtpvD2yu+RA hQ0D4umfKMxuGbzBNOAmFsECjcjyeFs3ZA0hSOWhdDQ+CAicUfUBJysBhawgPfnlg2jS dHag== X-Gm-Message-State: ALoCoQl70dsoDD+flPk3MmTwy6mMy2KnRTfh3i8Hi8Z63J12V0WboU6oBD3G/TJWyKX4slDQP8Vy X-Received: by 10.66.159.132 with SMTP id xc4mr29340572pab.27.1379309497186; Sun, 15 Sep 2013 22:31:37 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPSA id in2sm28467159pbc.37.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 15 Sep 2013 22:31:36 -0700 (PDT) From: Chander Kashyap To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: kgene.kim@samsung.com, tglx@linutronix.de, thomas.ab@samsung.com, Chander Kashyap Subject: [PATCH] irqchip: exynos-combiner: remove hard-coded irq_base value Date: Mon, 16 Sep 2013 11:01:22 +0530 Message-Id: <1379309482-19779-1-git-send-email-chander.kashyap@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Pass '0' in place of hardcoded "irq_base" value as "first_irq" parameter to "irq_domain_add_simple" in order to use linear irq domain. Signed-off-by: Chander Kashyap --- drivers/irqchip/exynos-combiner.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c index 4c68265..b4ed356 100644 --- a/drivers/irqchip/exynos-combiner.c +++ b/drivers/irqchip/exynos-combiner.c @@ -206,8 +206,7 @@ static unsigned int combiner_lookup_irq(int group) static void __init combiner_init(void __iomem *combiner_base, struct device_node *np, - unsigned int max_nr, - int irq_base) + unsigned int max_nr) { int i, irq; unsigned int nr_irq; @@ -221,7 +220,7 @@ static void __init combiner_init(void __iomem *combiner_base, return; } - combiner_irq_domain = irq_domain_add_simple(np, nr_irq, irq_base, + combiner_irq_domain = irq_domain_add_simple(np, nr_irq, 0, &combiner_irq_domain_ops, combiner_data); if (WARN_ON(!combiner_irq_domain)) { pr_warning("%s: irq domain init failed\n", __func__); @@ -248,7 +247,6 @@ static int __init combiner_of_init(struct device_node *np, { void __iomem *combiner_base; unsigned int max_nr = 20; - int irq_base = -1; combiner_base = of_iomap(np, 0); if (!combiner_base) { @@ -262,14 +260,7 @@ static int __init combiner_of_init(struct device_node *np, __func__, max_nr); } - /* - * FIXME: This is a hardwired COMBINER_IRQ(0,0). Once all devices - * get their IRQ from DT, remove this in order to get dynamic - * allocation. - */ - irq_base = 160; - - combiner_init(combiner_base, np, max_nr, irq_base); + combiner_init(combiner_base, np, max_nr); return 0; }