| Message ID | 1380038363-487-1-git-send-email-m.krawczuk@partner.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mateusz, On Tuesday 24 of September 2013 17:59:23 Mateusz Krawczuk wrote: > It prevents from executing things already handled by pinctrl-exynos > driver, when device tree is available. > > Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++ > 1 file changed, 4 insertions(+) Acked-by: Tomasz Figa <t.figa@samsung.com> [as a temporary solution until we move all the users of this code to device tree] Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Tomasz Figa wrote: > > Hi Mateusz, > > On Tuesday 24 of September 2013 17:59:23 Mateusz Krawczuk wrote: > > It prevents from executing things already handled by pinctrl-exynos > > driver, when device tree is available. > > > > Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > Acked-by: Tomasz Figa <t.figa@samsung.com> > > [as a temporary solution until we move all the users of this code to > device tree] > Yes, agreed. The 'skip irq init' in subject would be changed to 'skip eint init' for clear meaning. Applied. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/plat-samsung/s5p-irq-eint.c b/arch/arm/plat-samsung/s5p-irq-eint.c index faa6516..ebee4dc 100644 --- a/arch/arm/plat-samsung/s5p-irq-eint.c +++ b/arch/arm/plat-samsung/s5p-irq-eint.c @@ -16,6 +16,7 @@ #include <linux/device.h> #include <linux/gpio.h> #include <linux/irqchip/arm-vic.h> +#include <linux/of.h> #include <plat/regs-irqtype.h> @@ -202,6 +203,9 @@ static int __init s5p_init_irq_eint(void) { int irq; + if (of_have_populated_dt()) + return -ENODEV; + for (irq = IRQ_EINT(0); irq <= IRQ_EINT(15); irq++) irq_set_chip(irq, &s5p_irq_vic_eint);