diff mbox

[2/2] ARM: dts: Update display clock frequency for Origen-4412

Message ID 1380171018-24229-2-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat Sept. 26, 2013, 4:50 a.m. UTC
As per the timing information for supported panel, the value should
be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate.

Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152
Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653

Target pixel clock rate for refresh rate @60 Hz
	= 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4412-origen.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

kgene@kernel.org Nov. 12, 2013, 10:17 a.m. UTC | #1
Sachin Kamat wrote:
> 
+ dt ml.

> As per the timing information for supported panel, the value should
> be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate.
> 
> Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152
> Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653

Should be 683?

> 
> Target pixel clock rate for refresh rate @60 Hz
> 	= 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz
> 
Same here.

> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4412-origen.dts |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> b/arch/arm/boot/dts/exynos4412-origen.dts
> index 8768b03..923bcd7 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -152,7 +152,7 @@
>  	display-timings {
>  		native-mode = <&timing0>;
>  		timing0: timing {
> -			clock-frequency = <50000>;
> +			clock-frequency = <47500000>;
>  			hactive = <1024>;
>  			vactive = <600>;
>  			hfront-porch = <64>;
> --
> 1.7.9.5

Please make sure it works fine on both origen boards with your two fixes.

If so, let me pick them up into Samsung tree after squash into one patch.

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tushar Behera Nov. 13, 2013, 3:47 a.m. UTC | #2
On 12 November 2013 15:47, Kukjin Kim <kgene@kernel.org> wrote:
> Sachin Kamat wrote:
>>
> + dt ml.
>
>> As per the timing information for supported panel, the value should
>> be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate.
>>
>> Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152
>> Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653
>
> Should be 683?
>
>>
>> Target pixel clock rate for refresh rate @60 Hz
>>       = 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz
>>
> Same here.
>

Yes, typo in both the cases, however the calculation is right. The
same typo in patch 1/2 also. You may please fix them while applying.

>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>  arch/arm/boot/dts/exynos4412-origen.dts |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
>> b/arch/arm/boot/dts/exynos4412-origen.dts
>> index 8768b03..923bcd7 100644
>> --- a/arch/arm/boot/dts/exynos4412-origen.dts
>> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
>> @@ -152,7 +152,7 @@
>>       display-timings {
>>               native-mode = <&timing0>;
>>               timing0: timing {
>> -                     clock-frequency = <50000>;
>> +                     clock-frequency = <47500000>;
>>                       hactive = <1024>;
>>                       vactive = <600>;
>>                       hfront-porch = <64>;
>> --
>> 1.7.9.5
>
> Please make sure it works fine on both origen boards with your two fixes.
>
> If so, let me pick them up into Samsung tree after squash into one patch.
>
> Thanks,
> Kukjin
>

Thanks.
Sachin Kamat Dec. 2, 2013, 4:14 a.m. UTC | #3
On 13 November 2013 09:17, Tushar Behera <tushar.behera@linaro.org> wrote:
> On 12 November 2013 15:47, Kukjin Kim <kgene@kernel.org> wrote:
>> Sachin Kamat wrote:
>>>
>> + dt ml.
>>
>>> As per the timing information for supported panel, the value should
>>> be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate.
>>>
>>> Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152
>>> Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653
>>
>> Should be 683?
>>
>>>
>>> Target pixel clock rate for refresh rate @60 Hz
>>>       = 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz
>>>
>> Same here.
>>
>
> Yes, typo in both the cases, however the calculation is right. The
> same typo in patch 1/2 also. You may please fix them while applying.
>


Ping Kukjin.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 8768b03..923bcd7 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -152,7 +152,7 @@ 
 	display-timings {
 		native-mode = <&timing0>;
 		timing0: timing {
-			clock-frequency = <50000>;
+			clock-frequency = <47500000>;
 			hactive = <1024>;
 			vactive = <600>;
 			hfront-porch = <64>;