diff mbox

[1/2] ARM: dts: Exynos5420: add clock entries to gsc power domain

Message ID 1381836054-6590-2-git-send-email-l.krishna@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Leela Krishna Amudala Oct. 15, 2013, 11:20 a.m. UTC
Add clock nodes for oscillator clock, input clocks and parents of input
clocks to gsc power domain so that we can set/restore the input
clocks while powering on and powering off a domain.

Signed-off-by: Prathyush K <prathyush.k@samsung.com>
Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |    3 +++
 1 file changed, 3 insertions(+)

Comments

Tomasz Figa Oct. 15, 2013, 6:49 p.m. UTC | #1
Hi Leela,

On Tuesday 15 of October 2013 16:50:53 Leela Krishna Amudala wrote:
> Add clock nodes for oscillator clock, input clocks and parents of input
> clocks to gsc power domain so that we can set/restore the input
> clocks while powering on and powering off a domain.
> 
> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index 09aa06c..7f0296c 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -116,6 +116,9 @@
>  	gsc_pd: power-domain@10044000 {
>  		compatible = "samsung,exynos4210-pd";
>  		reg = <0x10044000 0x20>;
> +		clocks = <&clock 1>, <&clock 1032>, <&clock 1033>,
> +			 <&clock 1034>, <&clock 1035>;
> +		clock-names = "oscclk", "pclk0", "clk0", "pclk1", "clk1";

This does not seem right. Do you have any actual code that uses this?

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Leela Krishna Amudala Oct. 16, 2013, 10:06 a.m. UTC | #2
Hi Tomasz,

On Wed, Oct 16, 2013 at 12:19 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Leela,
>
> On Tuesday 15 of October 2013 16:50:53 Leela Krishna Amudala wrote:
>> Add clock nodes for oscillator clock, input clocks and parents of input
>> clocks to gsc power domain so that we can set/restore the input
>> clocks while powering on and powering off a domain.
>>
>> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420.dtsi |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi index 09aa06c..7f0296c 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -116,6 +116,9 @@
>>       gsc_pd: power-domain@10044000 {
>>               compatible = "samsung,exynos4210-pd";
>>               reg = <0x10044000 0x20>;
>> +             clocks = <&clock 1>, <&clock 1032>, <&clock 1033>,
>> +                      <&clock 1034>, <&clock 1035>;
>> +             clock-names = "oscclk", "pclk0", "clk0", "pclk1", "clk1";
>
> This does not seem right. Do you have any actual code that uses this?
>

I'm not sure whether the code that uses this is present or not.
For time being I'll discard this patch from the series and will post it later.

Best Wishes,
Leela Krishna.

> Best regards,
> Tomasz
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 09aa06c..7f0296c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -116,6 +116,9 @@ 
 	gsc_pd: power-domain@10044000 {
 		compatible = "samsung,exynos4210-pd";
 		reg = <0x10044000 0x20>;
+		clocks = <&clock 1>, <&clock 1032>, <&clock 1033>,
+			 <&clock 1034>, <&clock 1035>;
+		clock-names = "oscclk", "pclk0", "clk0", "pclk1", "clk1";
 	};
 
 	isp_pd: power-domain@10044020 {