| Message ID | 1382013941-861-1-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 17/10/13 14:45, Krzysztof Kozlowski wrote: > pm_runtime_put() wasn't called if clock rate could not be set up in > s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 17, 2013 at 02:45:41PM +0200, Krzysztof Kozlowski wrote: > pm_runtime_put() wasn't called if clock rate could not be set up in > s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage. Applied, thanks.
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index a80376d..0ddaff2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1121,6 +1121,7 @@ static int s3c64xx_spi_setup(struct spi_device *spi) return 0; setup_exit: + pm_runtime_put(&sdd->pdev->dev); /* setup() returns with device de-selected */ disable_cs(sdd, spi);
pm_runtime_put() wasn't called if clock rate could not be set up in s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- drivers/spi/spi-s3c64xx.c | 1 + 1 file changed, 1 insertion(+)