diff mbox

clk: samsung: exynos4: Correct SRC_MFC register

Message ID 1385097668-24620-1-git-send-email-sw0312.kim@samsung.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Seung-Woo Kim Nov. 22, 2013, 5:21 a.m. UTC
The SRC_MFC register was incorrect. This patch corrects it.

Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
 drivers/clk/samsung/clk-exynos4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Tomasz Figa Dec. 9, 2013, 1:35 p.m. UTC | #1
Hi Seung-Woo,

On Friday 22 of November 2013 14:21:08 Seung-Woo Kim wrote:
> The SRC_MFC register was incorrect. This patch corrects it.
> 
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos4.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Good catch.

Acked-by: Tomasz Figa <t.figa@samsung.com>

I guess this could go as a fix for current rc, through clk-fixes.
Mike, what do you think?

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomasz Figa Dec. 18, 2013, 2:54 p.m. UTC | #2
On Friday 22 of November 2013 14:21:08 Seung-Woo Kim wrote:
> The SRC_MFC register was incorrect. This patch corrects it.
> 
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos4.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c
> index ad5ff50..1a7c1b9 100644
> --- a/drivers/clk/samsung/clk-exynos4.c
> +++ b/drivers/clk/samsung/clk-exynos4.c
> @@ -39,7 +39,7 @@
>  #define SRC_TOP1		0xc214
>  #define SRC_CAM			0xc220
>  #define SRC_TV			0xc224
> -#define SRC_MFC			0xcc28
> +#define SRC_MFC			0xc228
>  #define SRC_G3D			0xc22c
>  #define E4210_SRC_IMAGE		0xc230
>  #define SRC_LCD0		0xc234
> 

Applied into samsung-clk fixes branch.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mike Turquette Dec. 19, 2013, 4:23 a.m. UTC | #3
Quoting Tomasz Figa (2013-12-18 06:54:30)
> On Friday 22 of November 2013 14:21:08 Seung-Woo Kim wrote:
> > The SRC_MFC register was incorrect. This patch corrects it.
> > 
> > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> > ---
> >  drivers/clk/samsung/clk-exynos4.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c
> > index ad5ff50..1a7c1b9 100644
> > --- a/drivers/clk/samsung/clk-exynos4.c
> > +++ b/drivers/clk/samsung/clk-exynos4.c
> > @@ -39,7 +39,7 @@
> >  #define SRC_TOP1             0xc214
> >  #define SRC_CAM                      0xc220
> >  #define SRC_TV                       0xc224
> > -#define SRC_MFC                      0xcc28
> > +#define SRC_MFC                      0xc228
> >  #define SRC_G3D                      0xc22c
> >  #define E4210_SRC_IMAGE              0xc230
> >  #define SRC_LCD0             0xc234
> > 
> 
> Applied into samsung-clk fixes branch.

It's always nice when a fix for the -rc cycle includes a description of
the user-visible regression that it fixes.

Regards,
Mike

> 
> Best regards,
> Tomasz
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomasz Figa Dec. 30, 2013, 5:50 p.m. UTC | #4
On Wednesday 18 of December 2013 20:23:10 Mike Turquette wrote:
> Quoting Tomasz Figa (2013-12-18 06:54:30)
> > On Friday 22 of November 2013 14:21:08 Seung-Woo Kim wrote:
> > > The SRC_MFC register was incorrect. This patch corrects it.
> > > 
> > > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> > > ---
> > >  drivers/clk/samsung/clk-exynos4.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c
> > > index ad5ff50..1a7c1b9 100644
> > > --- a/drivers/clk/samsung/clk-exynos4.c
> > > +++ b/drivers/clk/samsung/clk-exynos4.c
> > > @@ -39,7 +39,7 @@
> > >  #define SRC_TOP1             0xc214
> > >  #define SRC_CAM                      0xc220
> > >  #define SRC_TV                       0xc224
> > > -#define SRC_MFC                      0xcc28
> > > +#define SRC_MFC                      0xc228
> > >  #define SRC_G3D                      0xc22c
> > >  #define E4210_SRC_IMAGE              0xc230
> > >  #define SRC_LCD0             0xc234
> > > 
> > 
> > Applied into samsung-clk fixes branch.
> 
> It's always nice when a fix for the -rc cycle includes a description of
> the user-visible regression that it fixes.

I have updated the description when applying.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c
index ad5ff50..1a7c1b9 100644
--- a/drivers/clk/samsung/clk-exynos4.c
+++ b/drivers/clk/samsung/clk-exynos4.c
@@ -39,7 +39,7 @@ 
 #define SRC_TOP1		0xc214
 #define SRC_CAM			0xc220
 #define SRC_TV			0xc224
-#define SRC_MFC			0xcc28
+#define SRC_MFC			0xc228
 #define SRC_G3D			0xc22c
 #define E4210_SRC_IMAGE		0xc230
 #define SRC_LCD0		0xc234