From patchwork Thu Dec 12 16:07:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Figa X-Patchwork-Id: 3332861 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 31850C0D4A for ; Thu, 12 Dec 2013 16:08:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0E3E0207C5 for ; Thu, 12 Dec 2013 16:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B084A207C3 for ; Thu, 12 Dec 2013 16:08:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751467Ab3LLQHv (ORCPT ); Thu, 12 Dec 2013 11:07:51 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:49963 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614Ab3LLQHr (ORCPT ); Thu, 12 Dec 2013 11:07:47 -0500 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MXP009K2BGX1B60@mailout2.w1.samsung.com>; Thu, 12 Dec 2013 16:07:45 +0000 (GMT) X-AuditID: cbfec7f4-b7f966d0000003d9-47-52a9df51c464 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 99.EC.00985.15FD9A25; Thu, 12 Dec 2013 16:07:45 +0000 (GMT) Received: from amdc1227.digital.local ([106.116.147.199]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MXP00BIHBGQS260@eusync3.samsung.com>; Thu, 12 Dec 2013 16:07:45 +0000 (GMT) From: Tomasz Figa To: linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Samuel Ortiz , Mike Turquette , Lee Jones , Sachin Kamat , Kyungmin Park , Tomasz Figa Subject: [PATCH v2 5/8] clk: max77686: Fix clean-up in error and remove paths Date: Thu, 12 Dec 2013 17:07:18 +0100 Message-id: <1386864441-19561-6-git-send-email-t.figa@samsung.com> X-Mailer: git-send-email 1.8.4.3 In-reply-to: <1386864441-19561-1-git-send-email-t.figa@samsung.com> References: <1386864441-19561-1-git-send-email-t.figa@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLJMWRmVeSWpSXmKPExsVy+t/xq7qB91cGGbycqWAx/8g5VouzTW/Y Le5/PcposenxNVaLGef3MVk8nXCRzeLkn15Gi9PdrBbrZ7xmceD0uHNtD5vHvJOBHpuX1Hv0 bVnF6PF5k1wAaxSXTUpqTmZZapG+XQJXxs4nh5gKVghUvP1ziamBcQdvFyMnh4SAiUTX33Ps ELaYxIV769m6GLk4hASWMkr09XxnhnD6mCR2XNvEAlLFJqAm8bnhERuILSKgITGl6zE7SBGz wBomid7NU1lBEsICvhLPr60Aa2ARUJVYcvMy0CQODl4BJ4mVz7khtilIdK75zwhicwo4S9w4 PBvMFgIq2bZ4EvsERt4FjAyrGEVTS5MLipPScw31ihNzi0vz0vWS83M3MUKC7MsOxsXHrA4x CnAwKvHwvji4IkiINbGsuDL3EKMEB7OSCO+9LSuDhHhTEiurUovy44tKc1KLDzEycXBKNTCy X6lo1RB92lPecX5fyMUL612Y84PjA+12PzPw0Gcv37rolHd5f/5p+0c9T17d32y4YlXdidv1 tzrKvltssbHjnP10/f3TCyYkuiVu858za5vUTj+mDz8dxXcs1096duyBSXRqcuSdiE3BX+qS jzfEBAkt470jvbnWIV+obabRtlXf2QsPHrdWYinOSDTUYi4qTgQAziilTRACAAA= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes invalid kfree() and adds missing call to clk_unregister() in error and remove paths in max77686_clk_probe(). While at it, error handling is also cleaned up. Signed-off-by: Tomasz Figa Acked-by: Kyungmin Park --- drivers/clk/clk-max77686.c | 32 ++++++++++---------------------- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c index 2e6ba0e..81b3680 100644 --- a/drivers/clk/clk-max77686.c +++ b/drivers/clk/clk-max77686.c @@ -162,20 +162,9 @@ static int max77686_clk_probe(struct platform_device *pdev) clk = max77686_clk_register(&pdev->dev, max77686_clks[i]); if (IS_ERR(clk)) { ret = PTR_ERR(clk); - - switch (i) { - case MAX77686_CLK_AP: - dev_err(&pdev->dev, "Fail to register CLK_AP\n"); - goto err_clk_ap; - break; - case MAX77686_CLK_CP: - dev_err(&pdev->dev, "Fail to register CLK_CP\n"); - goto err_clk_cp; - break; - case MAX77686_CLK_PMIC: - dev_err(&pdev->dev, "Fail to register CLK_PMIC\n"); - goto err_clk_pmic; - } + dev_err(&pdev->dev, "failed to register %s\n", + max77686_clks[i]->hw.init->name); + goto err_clocks; } } @@ -183,13 +172,12 @@ static int max77686_clk_probe(struct platform_device *pdev) return 0; -err_clk_pmic: - clkdev_drop(max77686_clks[MAX77686_CLK_CP]->lookup); - kfree(max77686_clks[MAX77686_CLK_CP]->hw.clk); -err_clk_cp: - clkdev_drop(max77686_clks[MAX77686_CLK_AP]->lookup); - kfree(max77686_clks[MAX77686_CLK_AP]->hw.clk); -err_clk_ap: +err_clocks: + for (--i; i >= 0; --i) { + clkdev_drop(max77686_clks[i]->lookup); + clk_unregister(max77686_clks[i]->hw.clk); + } + return ret; } @@ -200,7 +188,7 @@ static int max77686_clk_remove(struct platform_device *pdev) for (i = 0; i < MAX77686_CLKS_NUM; i++) { clkdev_drop(max77686_clks[i]->lookup); - kfree(max77686_clks[i]->hw.clk); + clk_unregister(max77686_clks[i]->hw.clk); } return 0; }