diff mbox

[1/1] ARM: exynos_defconfig: Fix a config option

Message ID 1388140690-30668-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat Dec. 27, 2013, 10:38 a.m. UTC
CONFIG_MACH_EXYNOS4_DT does not exist. Use ARCH_EXYNOS4 instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/configs/exynos_defconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kim Kukjin Feb. 24, 2014, 12:21 a.m. UTC | #1
On 12/27/13 19:38, Sachin Kamat wrote:
> CONFIG_MACH_EXYNOS4_DT does not exist. Use ARCH_EXYNOS4 instead.
>
> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
> ---
>   arch/arm/configs/exynos_defconfig |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index dbe1f1c47bb0..dff01ecf78cc 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -10,8 +10,8 @@ CONFIG_PARTITION_ADVANCED=y
>   CONFIG_ARCH_EXYNOS=y
>   CONFIG_S3C_LOWLEVEL_UART_PORT=3
>   CONFIG_S3C24XX_PWM=y
> +CONFIG_ARCH_EXYNOS4=y
>   CONFIG_ARCH_EXYNOS5=y
> -CONFIG_MACH_EXYNOS4_DT=y
>   CONFIG_SMP=y
>   CONFIG_NR_CPUS=8
>   CONFIG_PREEMPT=y

Well, this is not required because it should be fine without this 
change. ARCH_EXYNOS4 will be selected when ARCH_EXYNOS is enabled and 
non-exist CONFIG (MACH_EXYNOS4_DT) will be ignored.

Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sachin Kamat March 4, 2014, 12:23 p.m. UTC | #2
On 24 February 2014 05:51, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 12/27/13 19:38, Sachin Kamat wrote:
>>
>> CONFIG_MACH_EXYNOS4_DT does not exist. Use ARCH_EXYNOS4 instead.
>>
>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>> ---
>>   arch/arm/configs/exynos_defconfig |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/configs/exynos_defconfig
>> b/arch/arm/configs/exynos_defconfig
>> index dbe1f1c47bb0..dff01ecf78cc 100644
>> --- a/arch/arm/configs/exynos_defconfig
>> +++ b/arch/arm/configs/exynos_defconfig
>> @@ -10,8 +10,8 @@ CONFIG_PARTITION_ADVANCED=y
>>   CONFIG_ARCH_EXYNOS=y
>>   CONFIG_S3C_LOWLEVEL_UART_PORT=3
>>   CONFIG_S3C24XX_PWM=y
>> +CONFIG_ARCH_EXYNOS4=y
>>   CONFIG_ARCH_EXYNOS5=y
>> -CONFIG_MACH_EXYNOS4_DT=y
>>   CONFIG_SMP=y
>>   CONFIG_NR_CPUS=8
>>   CONFIG_PREEMPT=y
>
>
> Well, this is not required because it should be fine without this change.
> ARCH_EXYNOS4 will be selected when ARCH_EXYNOS is enabled and non-exist
> CONFIG (MACH_EXYNOS4_DT) will be ignored.

Functionally this might not be needed as Exynos4 is selected by
default. However, I don't see
any point in retaining non-existent symbols.
diff mbox

Patch

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index dbe1f1c47bb0..dff01ecf78cc 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -10,8 +10,8 @@  CONFIG_PARTITION_ADVANCED=y
 CONFIG_ARCH_EXYNOS=y
 CONFIG_S3C_LOWLEVEL_UART_PORT=3
 CONFIG_S3C24XX_PWM=y
+CONFIG_ARCH_EXYNOS4=y
 CONFIG_ARCH_EXYNOS5=y
-CONFIG_MACH_EXYNOS4_DT=y
 CONFIG_SMP=y
 CONFIG_NR_CPUS=8
 CONFIG_PREEMPT=y