| Message ID | 1389095509-14357-2-git-send-email-ch.naveen@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Naveen, Please see my comments inline. On Tuesday 07 of January 2014 17:21:45 Naveen Krishna Ch wrote: > This patch uses the platform_get_irq() instead of the > platform_get_irq_byname(). Making feeder control interrupt > as resource "0" and hash interrupt as "1". > > reasons for this change. > 1. Cannot find any Arch which is currently using this driver > 2. Samsung Exynos5 SoCs only use the feeder control interrupt > 3. Patches adding support for DT and H/W version are in pipeline > > Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com> > CC: Herbert Xu <herbert@gondor.apana.org.au> > CC: David S. Miller <davem@davemloft.net> > CC: Vladimir Zapolskiy <vzapolskiy@gmail.com> > TO: <linux-crypto@vger.kernel.org> > CC: <linux-samsung-soc@vger.kernel.org> > --- > drivers/crypto/s5p-sss.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index cf149b1..dda4551 100644 > --- a/drivers/crypto/s5p-sss.c > +++ b/drivers/crypto/s5p-sss.c > @@ -592,29 +592,29 @@ static int s5p_aes_probe(struct platform_device *pdev) > pdata->ioaddr = devm_ioremap(dev, res->start, > resource_size(res)); > > - pdata->irq_hash = platform_get_irq_byname(pdev, "hash"); > - if (pdata->irq_hash < 0) { > + pdata->irq_fc = platform_get_irq(pdev, 0); > + if (pdata->irq_fc < 0) { > err = pdata->irq_hash; Shouldn't this be also changed to err = pdata->irq_fc; ? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index cf149b1..dda4551 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -592,29 +592,29 @@ static int s5p_aes_probe(struct platform_device *pdev) pdata->ioaddr = devm_ioremap(dev, res->start, resource_size(res)); - pdata->irq_hash = platform_get_irq_byname(pdev, "hash"); - if (pdata->irq_hash < 0) { + pdata->irq_fc = platform_get_irq(pdev, 0); + if (pdata->irq_fc < 0) { err = pdata->irq_hash; - dev_warn(dev, "hash interrupt is not available.\n"); + dev_warn(dev, "feed control interrupt is not available.\n"); goto err_irq; } - err = devm_request_irq(dev, pdata->irq_hash, s5p_aes_interrupt, + err = devm_request_irq(dev, pdata->irq_fc, s5p_aes_interrupt, IRQF_SHARED, pdev->name, pdev); if (err < 0) { - dev_warn(dev, "hash interrupt is not available.\n"); + dev_warn(dev, "feed control interrupt is not available.\n"); goto err_irq; } - pdata->irq_fc = platform_get_irq_byname(pdev, "feed control"); - if (pdata->irq_fc < 0) { - err = pdata->irq_fc; - dev_warn(dev, "feed control interrupt is not available.\n"); + pdata->irq_hash = platform_get_irq(pdev, 1); + if (pdata->irq_hash < 0) { + err = pdata->irq_hash; + dev_warn(dev, "hash interrupt is not available.\n"); goto err_irq; } - err = devm_request_irq(dev, pdata->irq_fc, s5p_aes_interrupt, + err = devm_request_irq(dev, pdata->irq_hash, s5p_aes_interrupt, IRQF_SHARED, pdev->name, pdev); if (err < 0) { - dev_warn(dev, "feed control interrupt is not available.\n"); + dev_warn(dev, "hash interrupt is not available.\n"); goto err_irq; }
This patch uses the platform_get_irq() instead of the platform_get_irq_byname(). Making feeder control interrupt as resource "0" and hash interrupt as "1". reasons for this change. 1. Cannot find any Arch which is currently using this driver 2. Samsung Exynos5 SoCs only use the feeder control interrupt 3. Patches adding support for DT and H/W version are in pipeline Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com> CC: Herbert Xu <herbert@gondor.apana.org.au> CC: David S. Miller <davem@davemloft.net> CC: Vladimir Zapolskiy <vzapolskiy@gmail.com> TO: <linux-crypto@vger.kernel.org> CC: <linux-samsung-soc@vger.kernel.org> --- drivers/crypto/s5p-sss.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)