diff mbox

[1/3] irqchip: exynos-combiner: call handle_bad_irq directly

Message ID 1389321142-4073-1-git-send-email-pankaj.dubey@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Pankaj Dubey Jan. 10, 2014, 2:32 a.m. UTC
This patch is inspired from following commit
 aec0095653: (irqchip: gic: Call handle_bad_irq() directly)

Also this will help in removing unwanted inclusion
of header file "asm/mach/irq.h"

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 drivers/irqchip/exynos-combiner.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Pankaj Dubey Jan. 10, 2014, 2:38 a.m. UTC | #1
On 01/10/2014 11:32 AM, Pankaj Dubey wrote:
> This patch is inspired from following commit
>   aec0095653: (irqchip: gic: Call handle_bad_irq() directly)
>
> Also this will help in removing unwanted inclusion
> of header file "asm/mach/irq.h"
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
This is single patch only. By mistake sent as Patch[1/3].
> ---
>   drivers/irqchip/exynos-combiner.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> index 40e6440..f8636a6 100644
> --- a/drivers/irqchip/exynos-combiner.c
> +++ b/drivers/irqchip/exynos-combiner.c
> @@ -17,7 +17,6 @@
>   #include <linux/irqchip/chained_irq.h>
>   #include <linux/of_address.h>
>   #include <linux/of_irq.h>
> -#include <asm/mach/irq.h>
>   
>   #include "irqchip.h"
>   
> @@ -81,7 +80,7 @@ static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
>   	cascade_irq = irq_find_mapping(combiner_irq_domain, combiner_irq);
>   
>   	if (unlikely(!cascade_irq))
> -		do_bad_IRQ(irq, desc);
> +		handle_bad_irq(irq, desc);
>   	else
>   		generic_handle_irq(cascade_irq);
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomasz Figa Jan. 10, 2014, 4:19 p.m. UTC | #2
Hi Pankaj,

On 10.01.2014 03:32, Pankaj Dubey wrote:
> This patch is inspired from following commit
>   aec0095653: (irqchip: gic: Call handle_bad_irq() directly)
>
> Also this will help in removing unwanted inclusion
> of header file "asm/mach/irq.h"
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>   drivers/irqchip/exynos-combiner.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pankaj Dubey Feb. 13, 2014, 8:14 a.m. UTC | #3
On 01/11/2014 01:19 AM, Tomasz Figa wrote:
> Hi Pankaj,
>
> On 10.01.2014 03:32, Pankaj Dubey wrote:
>> This patch is inspired from following commit
>>   aec0095653: (irqchip: gic: Call handle_bad_irq() directly)
>>
>> Also this will help in removing unwanted inclusion
>> of header file "asm/mach/irq.h"
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>>   drivers/irqchip/exynos-combiner.c |    3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
> Best regards,
> Tomasz
>

Ping.

Thanks,
Pankaj Dubey
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kim Kukjin Feb. 13, 2014, 10:25 p.m. UTC | #4
On 01/11/14 01:19, Tomasz Figa wrote:
> Hi Pankaj,
>
> On 10.01.2014 03:32, Pankaj Dubey wrote:
>> This patch is inspired from following commit
>> aec0095653: (irqchip: gic: Call handle_bad_irq() directly)
>>
>> Also this will help in removing unwanted inclusion
>> of header file "asm/mach/irq.h"
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>> drivers/irqchip/exynos-combiner.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Applied, thanks.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
index 40e6440..f8636a6 100644
--- a/drivers/irqchip/exynos-combiner.c
+++ b/drivers/irqchip/exynos-combiner.c
@@ -17,7 +17,6 @@ 
 #include <linux/irqchip/chained_irq.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <asm/mach/irq.h>
 
 #include "irqchip.h"
 
@@ -81,7 +80,7 @@  static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
 	cascade_irq = irq_find_mapping(combiner_irq_domain, combiner_irq);
 
 	if (unlikely(!cascade_irq))
-		do_bad_IRQ(irq, desc);
+		handle_bad_irq(irq, desc);
 	else
 		generic_handle_irq(cascade_irq);