From patchwork Mon Feb 10 21:25:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 3623581 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 56B17C02E3 for ; Mon, 10 Feb 2014 21:25:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 960A0201EC for ; Mon, 10 Feb 2014 21:25:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4EA0201E9 for ; Mon, 10 Feb 2014 21:25:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbaBJVZf (ORCPT ); Mon, 10 Feb 2014 16:25:35 -0500 Received: from cpsmtpb-ews04.kpnxchange.com ([213.75.39.7]:56542 "EHLO cpsmtpb-ews04.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752702AbaBJVZd (ORCPT ); Mon, 10 Feb 2014 16:25:33 -0500 Received: from cpsps-ews17.kpnxchange.com ([10.94.84.183]) by cpsmtpb-ews04.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 10 Feb 2014 22:25:31 +0100 Received: from CPSMTPM-TLF104.kpnxchange.com ([195.121.3.7]) by cpsps-ews17.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 10 Feb 2014 22:25:31 +0100 Received: from [192.168.1.104] ([82.169.24.127]) by CPSMTPM-TLF104.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 10 Feb 2014 22:25:31 +0100 Message-ID: <1392067531.27939.19.camel@x220> Subject: [PATCH] ASoC: smdk_wm8994: Fix typo "wm8894" From: Paul Bolle To: Ben Dooks , Kukjin Kim , Sangbeom Kim , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Mon, 10 Feb 2014 22:25:31 +0100 X-Mailer: Evolution 3.10.3 (3.10.3-1.fc20) Mime-Version: 1.0 X-OriginalArrivalTime: 10 Feb 2014 21:25:31.0529 (UTC) FILETIME=[A0720F90:01CF26A6] X-RcptDomain: vger.kernel.org Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, KHOP_BIG_TO_CC,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Paul Bolle --- 0) This typo was introduced in commit 0d47acc4ffaa ("ASoC: smdk_wm8994: Make driver name more unique"). 1) So currently there's a difference between platform_drive.driver.name and the (sub)string used in MODULE_ALIAS(). If I'd understand the platform_driver interface I might have been able to say whether that difference is only cosmetic or might actually break stuff. But I don't understand it so I can't say. I can't even say whether this typo shows up in some interface to user space. 2) Entirely untested. sound/soc/samsung/smdk_wm8994.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c index d38ae98..682eb4f 100644 --- a/sound/soc/samsung/smdk_wm8994.c +++ b/sound/soc/samsung/smdk_wm8994.c @@ -202,7 +202,7 @@ static int smdk_audio_probe(struct platform_device *pdev) static struct platform_driver smdk_audio_driver = { .driver = { - .name = "smdk-audio-wm8894", + .name = "smdk-audio-wm8994", .owner = THIS_MODULE, .of_match_table = of_match_ptr(samsung_wm8994_of_match), .pm = &snd_soc_pm_ops,