From patchwork Thu Mar 6 06:12:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 3781781 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 81E0F9F35F for ; Thu, 6 Mar 2014 06:13:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B16BE201DE for ; Thu, 6 Mar 2014 06:13:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9BAF201DD for ; Thu, 6 Mar 2014 06:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbaCFGND (ORCPT ); Thu, 6 Mar 2014 01:13:03 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:26152 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbaCFGNB (ORCPT ); Thu, 6 Mar 2014 01:13:01 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N20006II3XORA60@mailout2.samsung.com> for linux-samsung-soc@vger.kernel.org; Thu, 06 Mar 2014 15:13:00 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.125]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 47.9B.09028.CE118135; Thu, 06 Mar 2014 15:13:00 +0900 (KST) X-AuditID: cbfee68e-b7f566d000002344-cf-531811ec4efb Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id EA.3E.28157.CE118135; Thu, 06 Mar 2014 15:13:00 +0900 (KST) Received: from localhost.localdomain ([107.108.83.245]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N2000AL63X9JW40@mmp1.samsung.com>; Thu, 06 Mar 2014 15:12:59 +0900 (KST) From: Rahul Sharma To: dri-devel@lists.freedesktop.org Cc: airlied@gmail.com, inki.dae@samsung.com, prashanth.g@samsung.com, seanpaul@chromium.org, marcheu@chromium.org, joshi@samsung.com, linux-samsung-soc@vger.kernel.org, r.sh.open@google.com, ajaykumar.rs@samsung.com, Rahul Sharma Subject: [RFC 1/4] drm: allow to create blank writable blob properties Date: Thu, 06 Mar 2014 11:42:11 +0530 Message-id: <1394086334-20967-2-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1394086334-20967-1-git-send-email-rahul.sharma@samsung.com> References: <1394086334-20967-1-git-send-email-rahul.sharma@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42JZI2JSq/tGUCLYYPVySYsT1xcxWRx4f5DF 4srX92wWk+5PYLH4vusLu8WM8/uYLOYd+s1oserwBnaLjRO2MlpMWXSY1eLuhrOMDtwesxsu snjsnHWX3WPBplKP+93HmTz6tqxi9Pi8SS6ALYrLJiU1J7MstUjfLoEr4/X7JraCWVwVmz71 szQw7uPoYuTkkBAwkeib94wRwhaTuHBvPVsXIxeHkMBSRokXza/YYIo+Xf/LCpFYxChxcudT dginnUnizsV/7CBVbAK6ErMPQowSEVCW+DtxFSNIEbNAG5PE7t5epi5GDg5hATeJ2W8zQGpY BFQlvh3dzwpi8wp4SHxf1skOUiIhoCAxZ5INSJhTwFOi+89EJhBbCKhkbv96JpCREgKn2CUO 9L5hhZgjIPFt8iEWiF5ZiU0HmCGOlpQ4uOIGywRG4QWMDKsYRVMLkguKk9KLjPSKE3OLS/PS 9ZLzczcxAuPi9L9nfTsYbx6wPsSYDDRuIrOUaHI+MK7ySuINjc2MLExNTI2NzC3NSBNWEudd 9DApSEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAOjT7nfkkRnn8KpU5LPST05UdfhO8n5oOgK rnavhoSdthx+Zs8nrGNyLNdc+3eZ0+0gvd0z7PbvNton/VNIVnH2BinRWTKnlSoPvHbZMsNY 4qbBVrYT022Vg02nMsx5f30SU/uK3XfTN+eY6PFO1cn6I+hYL7a73Fhnll9ky5bDH/0Sr4p8 XtmpxFKckWioxVxUnAgAr9lU06ECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsVy+t9jAd03ghLBBlOuCVicuL6IyeLA+4Ms Fle+vmezmHR/AovF911f2C1mnN/HZDHv0G9Gi1WHN7BbbJywldFiyqLDrBZ3N5xldOD2mN1w kcVj56y77B4LNpV63O8+zuTRt2UVo8fnTXIBbFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7x pmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QPcpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUN CYLrMTJAAwlrGDNev29iK5jFVbHpUz9LA+M+ji5GTg4JAROJT9f/skLYYhIX7q1n62Lk4hAS WMQocXLnU3YIp51J4s7Ff+wgVWwCuhKzDz5jBLFFBJQl/k5cxQhSxCzQxiSxu7eXqYuRg0NY wE1i9tsMkBoWAVWJb0f3g23gFfCQ+L6skx2kREJAQWLOJBuQMKeAp0T3n4lMILYQUMnc/vVM Exh5FzAyrGIUTS1ILihOSs810itOzC0uzUvXS87P3cQIjrpn0jsYVzVYHGIU4GBU4uHd4Cce LMSaWFZcmXuIUYKDWUmE9+EToBBvSmJlVWpRfnxRaU5q8SHGZKCjJjJLiSbnAxNCXkm8obGJ uamxqaWJhYmZJWnCSuK8B1utA4UE0hNLUrNTUwtSi2C2MHFwSjUwxmwO47ix5efxyyd7lRK6 Ttxlkoyd7bj9goCfbP6OVs8LkiyZW48X/ljx7PfGHYIvTy9ZxPGaeSPbsSP3mi8uzHEsTzlg N9Ur4cz9wP/tSg//XzQ0F/DuOdn36svMJu2Os6Ezlq+bl2/ru/rnXvMbO42nRQe8q1kYlmF0 rId941t7dqv3i848dVViKc5INNRiLipOBAD77Vjx/gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no provision to create a blob property without providing binary data. This data is needed to fill inside the blob. With subsequent patches, blob properties are modified to receive well defined structures by the user application. DRM creates a blank blob (initialized with all zeros) which can be filled by user application through set_blob ioctl. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/drm_crtc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 35ea15d..9a2215c 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -3190,7 +3190,7 @@ static struct drm_property_blob *drm_property_create_blob(struct drm_device *dev struct drm_property_blob *blob; int ret; - if (!length || !data) + if (!length) return NULL; blob = kzalloc(sizeof(struct drm_property_blob)+length, GFP_KERNEL); @@ -3205,7 +3205,8 @@ static struct drm_property_blob *drm_property_create_blob(struct drm_device *dev blob->length = length; - memcpy(blob->data, data, length); + if (data) + memcpy(blob->data, data, length); list_add_tail(&blob->head, &dev->mode_config.property_blob_list); return blob;