diff mbox

[v2] ARM: dts: exynos4210-trats: add max8997 IRQ

Message ID 1395828429-11023-1-git-send-email-r.baldyga@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Robert Baldyga March 26, 2014, 10:07 a.m. UTC 
This patch adds IRQ line specification for the MAX8997 chip and necessary
pinctrl group to configure pull-up and driver strength of the pin.
It's needed for proper handling of IRQs coming from MAX8997 multifunction
device (IRQs are used by PMIC, MUIC and RTC).

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---

Changelog:

v2:
- Corrected commit message.

v1: https://lkml.org/lkml/2014/3/14/124

 arch/arm/boot/dts/exynos4210-trats.dts |   13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Krzysztof Kozlowski June 14, 2015, 4:31 a.m. UTC | #1 
2014-03-26 19:07 GMT+09:00 Robert Baldyga <r.baldyga@samsung.com>:
> This patch adds IRQ line specification for the MAX8997 chip and necessary
> pinctrl group to configure pull-up and driver strength of the pin.
> It's needed for proper handling of IRQs coming from MAX8997 multifunction
> device (IRQs are used by PMIC, MUIC and RTC).
>
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>

(limit the CC list)
Yet another old patch I found on LKML... Robert, is this patch still
worth applying? If yes, would you be so kind to rebase it and resend?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 662b482..5629eef 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -156,6 +156,14 @@ 
 		};
 	};
 
+	pinctrl@11000000 {
+		max8997_irq: max8997-irq {
+			samsung,pins = "gpx0-7";
+			samsung,pin-pud = <3>;
+			samsung,pin-drv = <0>;
+		};
+	};
+
 	i2c@13890000 {
 		samsung,i2c-sda-delay = <100>;
 		samsung,i2c-slave-addr = <0x10>;
@@ -187,6 +195,11 @@ 
 		max8997_pmic@66 {
 			compatible = "maxim,max8997-pmic";
 
+			pinctrl-0 = <&max8997_irq>;
+			pinctrl-names = "default";
+
+			interrupt-parent = <&gpx0>;
+			interrupts = <7 0>;
 			reg = <0x66>;
 
 			max8997,pmic-buck1-uses-gpio-dvs;