| Message ID | 1398409152-14770-3-git-send-email-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Chanho, On 25 April 2014 12:29, Chanho Park <chanho61.park@samsung.com> wrote: > This patch enables a exynos_usbphy node for exynos4 SoCs. > A exynos4x12 usb phy node is almost same with 4210's one > except compatible string and pmu syscon. > > Cc: Tomasz Figa <t.figa@samsung.com> > Cc: Kamil Debski <k.debski@samsung.com> > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > arch/arm/boot/dts/exynos4.dtsi | 10 ++++++++++ > arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++ > 2 files changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 264066f..5f9b23b 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -278,6 +278,16 @@ > status = "disabled"; > }; > > + exynos_usbphy: exynos-usbphy@125B0000 { > + compatible = "samsung,exynos4210-usb2-phy"; > + reg = <0x125B0000 0x100>; > + samsung,pmureg-phandle = <&pmu_system_controller>; > + clocks = <&clock CLK_USB_DEVICE>, <&clock CLK_XUSBXTI>; > + clock-names = "phy", "ref"; > + status = "disabled"; For readability it is better if status line is the last entry of the node. --- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sachin, > -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Tuesday, April 29, 2014 6:23 PM > To: Chanho Park > Cc: Kukjin Kim; linux-samsung-soc; Tomasz Figa; Kamil Debski; > devicetree@vger.kernel.org > Subject: Re: [PATCHv2 2/4] ARM: dts: exynos4: add exynos_usbphy node > > Hi Chanho, > > On 25 April 2014 12:29, Chanho Park <chanho61.park@samsung.com> wrote: > > This patch enables a exynos_usbphy node for exynos4 SoCs. > > A exynos4x12 usb phy node is almost same with 4210's one > > except compatible string and pmu syscon. > > > > Cc: Tomasz Figa <t.figa@samsung.com> > > Cc: Kamil Debski <k.debski@samsung.com> > > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > > --- > > arch/arm/boot/dts/exynos4.dtsi | 10 ++++++++++ > > arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++ > > 2 files changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos4.dtsi > b/arch/arm/boot/dts/exynos4.dtsi > > index 264066f..5f9b23b 100644 > > --- a/arch/arm/boot/dts/exynos4.dtsi > > +++ b/arch/arm/boot/dts/exynos4.dtsi > > @@ -278,6 +278,16 @@ > > status = "disabled"; > > }; > > > > + exynos_usbphy: exynos-usbphy@125B0000 { > > + compatible = "samsung,exynos4210-usb2-phy"; > > + reg = <0x125B0000 0x100>; > > + samsung,pmureg-phandle = <&pmu_system_controller>; > > + clocks = <&clock CLK_USB_DEVICE>, <&clock CLK_XUSBXTI>; > > + clock-names = "phy", "ref"; > > + status = "disabled"; > > For readability it is better if status line is the last entry of the > node. Yes. It could be more readable it is in the last line. I'll update it in next patch. Thanks. Best Regards, Chanho Park -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 264066f..5f9b23b 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -278,6 +278,16 @@ status = "disabled"; }; + exynos_usbphy: exynos-usbphy@125B0000 { + compatible = "samsung,exynos4210-usb2-phy"; + reg = <0x125B0000 0x100>; + samsung,pmureg-phandle = <&pmu_system_controller>; + clocks = <&clock CLK_USB_DEVICE>, <&clock CLK_XUSBXTI>; + clock-names = "phy", "ref"; + status = "disabled"; + #phy-cells = <1>; + }; + ehci@12580000 { compatible = "samsung,exynos4210-ehci"; reg = <0x12580000 0x100>; diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi index 7f767f7..6d9a21a 100644 --- a/arch/arm/boot/dts/exynos4x12.dtsi +++ b/arch/arm/boot/dts/exynos4x12.dtsi @@ -247,4 +247,9 @@ clock-names = "biu", "ciu"; status = "disabled"; }; + + exynos-usbphy@125B0000 { + compatible = "samsung,exynos4x12-usb2-phy"; + samsung,sysreg-phandle = <&sys_reg>; + }; };
This patch enables a exynos_usbphy node for exynos4 SoCs. A exynos4x12 usb phy node is almost same with 4210's one except compatible string and pmu syscon. Cc: Tomasz Figa <t.figa@samsung.com> Cc: Kamil Debski <k.debski@samsung.com> Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- arch/arm/boot/dts/exynos4.dtsi | 10 ++++++++++ arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++ 2 files changed, 15 insertions(+)