From patchwork Sat May 10 09:57:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 4147621 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5F8119F23C for ; Sat, 10 May 2014 09:58:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8A354201D3 for ; Sat, 10 May 2014 09:58:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4E02201BB for ; Sat, 10 May 2014 09:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932243AbaEJJ5f (ORCPT ); Sat, 10 May 2014 05:57:35 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:53363 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932237AbaEJJ5e (ORCPT ); Sat, 10 May 2014 05:57:34 -0400 Received: by mail-pd0-f169.google.com with SMTP id z10so4669162pdj.28 for ; Sat, 10 May 2014 02:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=c0b1UvWAoN/LoDcAJqN9s8/FAjiLRAYEkVw2aHb6M5A=; b=ryZJbleTbiT46nFU2yDfL/putOPU6vctlv2n2oIKF+6uMJcKLQpRhE41XS2OqT/L+e zSz/MLxRlBXqktIc5MniXCD6SjsdaazjfSjTFNwRl1AJENLSzUAtkJ3CPlU+zS3GdwwU 3K33mmIkMo3ezntspdSeF4mXrRs4wAZdhdr2n0SqsFz0aEr2KR7/xfnok9xFyWRpBuuo BpV76Llpsf6ONUUZbJwbEH1kUgt1TYaig5RaVXR60NI00x11DjUJrMve8AQ6AL6gHKbH sCLzeiI1HCFlhXEdT2t77jI93opj92pSB6T26CRvE5fF3RXWJoAkxLmm4G4iTh4Ga5Ua jtpA== X-Received: by 10.67.14.231 with SMTP id fj7mr30310832pad.115.1399715853339; Sat, 10 May 2014 02:57:33 -0700 (PDT) Received: from vivek-linuxpc.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id ox3sm11946297pbb.88.2014.05.10.02.57.29 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 10 May 2014 02:57:32 -0700 (PDT) From: Vivek Gautam To: linux-usb@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, stern@rowland.harvard.edu, swarren@wwwdotorg.org, kgene.kim@samsung.com, thierry.reding@gmail.com, Vivek Gautam Subject: [PATCH 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap Date: Sat, 10 May 2014 15:27:02 +0530 Message-Id: <1399715823-19839-6-git-send-email-gautam.vivek@samsung.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1399715823-19839-1-git-send-email-gautam.vivek@samsung.com> References: <1399715823-19839-1-git-send-email-gautam.vivek@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using devm_ioremap_resource() API should actually be preferred over devm_ioremap(), since the former request the mem region first and then gives back the ioremap'ed memory pointer. devm_ioremap_resource() calls request_mem_region(), therby preventing other drivers to make any overlapping call to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-tegra.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 572634c..ccc6433 100644 --- a/drivers/usb/host/ehci-tegra.c +++ b/drivers/usb/host/ehci-tegra.c @@ -411,9 +411,8 @@ static int tegra_ehci_probe(struct platform_device *pdev) } hcd->rsrc_start = res->start; hcd->rsrc_len = resource_size(res); - hcd->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); + hcd->regs = devm_ioremap_resource(&pdev->dev, res); if (!hcd->regs) { - dev_err(&pdev->dev, "Failed to remap I/O memory\n"); err = -ENOMEM; goto cleanup_clk_en; }