From patchwork Sat May 10 12:00:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 4148011 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A5D41BFF02 for ; Sat, 10 May 2014 12:01:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CCF3C2013D for ; Sat, 10 May 2014 12:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6F23200F3 for ; Sat, 10 May 2014 12:01:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757440AbaEJMBa (ORCPT ); Sat, 10 May 2014 08:01:30 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:35669 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756758AbaEJMAf (ORCPT ); Sat, 10 May 2014 08:00:35 -0400 Received: by mail-pd0-f169.google.com with SMTP id z10so4711985pdj.14 for ; Sat, 10 May 2014 05:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=o8l5257nNLYFk4MuV3Rs2Nia5g27CBSVDlyhGPiGZSU=; b=TZM9zt0j2NJL1PUUMkoUHxyt48NjHQxvj1QiszyJyHJPB7r6rexMRZ0LgY9fWBZmb1 8O9tzT9Mgd3DQVAnJYIcZelRk2w3Gm23cblgdHCHUOJ+RtVMbRkT0BKZi1X+x8Q/aqaF j1zC0Z398iQaXsQcEDPh/rH45P3ficZmUz6KGzZt4tzRPehP50VuQ49CdEgPgwFTkP6k k54hmX+yf0eicvO86y6Ybn/Ek6RCDRhMPvlny2NRNAijIEk27q3jhrv2VmCqgJHlNe8u WqtU+UdxWVmtI04Pz/dq4+3ypF1VQd0pKGJtfS69UdMS1X/ujj/KeYHAnIDZM/VtDPSP cMkA== X-Received: by 10.66.189.106 with SMTP id gh10mr32256523pac.31.1399723234636; Sat, 10 May 2014 05:00:34 -0700 (PDT) Received: from vivek-linuxpc.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id tb4sm21186685pac.45.2014.05.10.05.00.30 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 10 May 2014 05:00:34 -0700 (PDT) From: Vivek Gautam To: linux-usb@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, stern@rowland.harvard.edu, swarren@wwwdotorg.org, kgene.kim@samsung.com, thierry.reding@gmail.com, shc_work@mail.ru, Vivek Gautam Subject: [PATCH v2 4/6] usb: host: ehci-spear: Use devm_ioremap_resource instead of devm_ioremap Date: Sat, 10 May 2014 17:30:08 +0530 Message-Id: <1399723210-21569-5-git-send-email-gautam.vivek@samsung.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1399723210-21569-1-git-send-email-gautam.vivek@samsung.com> References: <1399723210-21569-1-git-send-email-gautam.vivek@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using devm_ioremap_resource() API should actually be preferred over devm_ioremap(), since the former request the mem region first and then gives back the ioremap'ed memory pointer. devm_ioremap_resource() calls request_mem_region(), therby preventing other drivers to make any overlapping call to the same region. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-spear.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c index 8bd915b..1d59958 100644 --- a/drivers/usb/host/ehci-spear.c +++ b/drivers/usb/host/ehci-spear.c @@ -106,16 +106,9 @@ static int spear_ehci_hcd_drv_probe(struct platform_device *pdev) hcd->rsrc_start = res->start; hcd->rsrc_len = resource_size(res); - if (!devm_request_mem_region(&pdev->dev, hcd->rsrc_start, hcd->rsrc_len, - driver->description)) { - retval = -EBUSY; - goto err_put_hcd; - } - - hcd->regs = devm_ioremap(&pdev->dev, hcd->rsrc_start, hcd->rsrc_len); - if (hcd->regs == NULL) { - dev_dbg(&pdev->dev, "error mapping memory\n"); - retval = -ENOMEM; + hcd->regs = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(hcd->regs)) { + retval = PTR_ERR(hcd->regs); goto err_put_hcd; }