From patchwork Tue Jun 3 04:57:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olof Johansson X-Patchwork-Id: 4285051 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3F32FBEEA7 for ; Tue, 3 Jun 2014 04:56:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5C8A02015D for ; Tue, 3 Jun 2014 04:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BF4B2015A for ; Tue, 3 Jun 2014 04:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbaFCE4B (ORCPT ); Tue, 3 Jun 2014 00:56:01 -0400 Received: from mail-pb0-f49.google.com ([209.85.160.49]:53555 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbaFCE4A (ORCPT ); Tue, 3 Jun 2014 00:56:00 -0400 Received: by mail-pb0-f49.google.com with SMTP id jt11so4929037pbb.8 for ; Mon, 02 Jun 2014 21:56:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=t0MTmKcRRyKl1sO9eW34Wl6thLrNPXxuEQhOFKlpayg=; b=cz8gai/d2EIHwunQIQ9ejClJZ2QAoSQezgYxKP1ecyyK1zGX+bDWD4FoOzW9P+kvAA AinQSpHlFtSCMeEs0cKl1SojCh5LtXSlFis5QRt7c4gJnmkqJ1ox9MGqGWauxCy9PrCR dvjjAXc7GkaldnVzBijZduczG8jY7pp6Uy7ZzAcj/vzwpk+sfmV7Am7kHb5zFQcS7srD mBTrFFSkTmtNa/Cs3bJ7seQcQsG78JtCRLM7k/MCVLZ0AJB2Uj17ZSidslW/B8ylukC7 /QHVDq7jP/R4OTuU+EpcWx+wjf32MZaSjjlGLRKLZL3MAb3cQX4b7r8JxkVsxK2gcHPW NVnA== X-Gm-Message-State: ALoCoQkpQbXG9mbtxamJ6DDS9zngc9bDflkqx1CRxH6YPs/Ukoh1d7qSP8MwnAYub5DjVQ9FQQFx X-Received: by 10.66.236.196 with SMTP id uw4mr1042655pac.113.1401771360496; Mon, 02 Jun 2014 21:56:00 -0700 (PDT) Received: from brutus.lixom.net (173-13-129-225-sfba.hfc.comcastbusiness.net. [173.13.129.225]) by mx.google.com with ESMTPSA id mt1sm23340135pbb.31.2014.06.02.21.55.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jun 2014 21:55:59 -0700 (PDT) From: Olof Johansson To: kgene.kim@samsung.com Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, t.figa@samsung.com, Olof Johansson Subject: [PATCH] ARM: exynos: mark machine descriptor functions static Date: Mon, 2 Jun 2014 21:57:36 -0700 Message-Id: <1401771456-6101-1-git-send-email-olof@lixom.net> X-Mailer: git-send-email 1.7.10.4 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no reason to export these functions, and I have no idea why they have over time ended up in the header file. As a result, none of the checker tools caught it (i.e. sparse was silent on it). Signed-off-by: Olof Johansson --- I'm guessing with all the churn right now this might not apply, so it might need manual application around -rc1. There's definitely room for more cleanup in common.h. arch/arm/mach-exynos/common.h | 6 ------ arch/arm/mach-exynos/exynos.c | 10 +++++----- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h index 5a3a1ec..0b0b6d5 100644 --- a/arch/arm/mach-exynos/common.h +++ b/arch/arm/mach-exynos/common.h @@ -116,13 +116,7 @@ void mct_init(void __iomem *base, int irq_g0, int irq_l0, int irq_l1); struct map_desc; extern void __iomem *sysram_ns_base_addr; extern void __iomem *sysram_base_addr; -void exynos_init_io(void); -void exynos_restart(enum reboot_mode mode, const char *cmd); void exynos_sysram_init(void); -void exynos_cpuidle_init(void); -void exynos_cpufreq_init(void); -void exynos_init_late(void); - void exynos_firmware_init(void); #ifdef CONFIG_PINCTRL_EXYNOS diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 9183675..c4f9c3d 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -146,7 +146,7 @@ static struct map_desc exynos5_iodesc[] __initdata = { }, }; -void exynos_restart(enum reboot_mode mode, const char *cmd) +static void exynos_restart(enum reboot_mode mode, const char *cmd) { struct device_node *np; u32 val = 0x1; @@ -174,7 +174,7 @@ static struct platform_device exynos_cpuidle = { .id = -1, }; -void __init exynos_cpuidle_init(void) +static void __init exynos_cpuidle_init(void) { if (soc_is_exynos5440()) return; @@ -182,7 +182,7 @@ void __init exynos_cpuidle_init(void) platform_device_register(&exynos_cpuidle); } -void __init exynos_cpufreq_init(void) +static void __init exynos_cpufreq_init(void) { platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); } @@ -209,7 +209,7 @@ void __init exynos_sysram_init(void) } } -void __init exynos_init_late(void) +static void __init exynos_init_late(void) { if (of_machine_is_compatible("samsung,exynos5440")) /* to be supported later */ @@ -256,7 +256,7 @@ static void __init exynos_map_io(void) iotable_init(exynos5_iodesc, ARRAY_SIZE(exynos5_iodesc)); } -void __init exynos_init_io(void) +static void __init exynos_init_io(void) { debug_ll_io_init();