| Message ID | 1403058061-24271-5-git-send-email-cw00.choi@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Chanwoo, On 18.06.2014 04:21, Chanwoo Choi wrote: > This patchset fix wrong compatible string for Exynos3250 ADC. Exynos3250 SoC > need to control only special clock for ADC. Exynos SoC except for Exynos3250 > has not included special clock for ADC. The exynos ADC driver can control > special clock if compatible string is 'exynos3250-adc-v2'. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 6c1fb67..107dc44 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -414,10 +414,10 @@ > }; > > adc: adc@126C0000 { > - compatible = "samsung,exynos-adc-v3"; > + compatible = "samsung,exynos3250-adc-v2"; > reg = <0x126C0000 0x100>, <0x10020718 0x4>; > interrupts = <0 137 0>; > - clock-names = "adc", "sclk_tsadc"; > + clock-names = "adc", "sclk_adc"; So, is it "sclk_adc" or "sclk_tsadc"? The code uses the former, while the documentation mentions the latter. Please fix this. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tomasz, On 06/18/2014 05:37 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 18.06.2014 04:21, Chanwoo Choi wrote: >> This patchset fix wrong compatible string for Exynos3250 ADC. Exynos3250 SoC >> need to control only special clock for ADC. Exynos SoC except for Exynos3250 >> has not included special clock for ADC. The exynos ADC driver can control >> special clock if compatible string is 'exynos3250-adc-v2'. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 6c1fb67..107dc44 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -414,10 +414,10 @@ >> }; >> >> adc: adc@126C0000 { >> - compatible = "samsung,exynos-adc-v3"; >> + compatible = "samsung,exynos3250-adc-v2"; >> reg = <0x126C0000 0x100>, <0x10020718 0x4>; >> interrupts = <0 137 0>; >> - clock-names = "adc", "sclk_tsadc"; >> + clock-names = "adc", "sclk_adc"; > > So, is it "sclk_adc" or "sclk_tsadc"? The code uses the former, while > the documentation mentions the latter. Please fix this. OK, I'll fix it by using 'sclk_adc' clock name. Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 6c1fb67..107dc44 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -414,10 +414,10 @@ }; adc: adc@126C0000 { - compatible = "samsung,exynos-adc-v3"; + compatible = "samsung,exynos3250-adc-v2"; reg = <0x126C0000 0x100>, <0x10020718 0x4>; interrupts = <0 137 0>; - clock-names = "adc", "sclk_tsadc"; + clock-names = "adc", "sclk_adc"; clocks = <&cmu CLK_TSADC>, <&cmu CLK_SCLK_TSADC>; #io-channel-cells = <1>; io-channel-ranges;