diff mbox

[v2] ARM: dts: exynos4: fix pwm-cells in pwm node

Message ID 1403143414-6242-1-git-send-email-jaewon02.kim@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jaewon Kim June 19, 2014, 2:03 a.m. UTC
pwm-cells should be 3. Third cell is optional PWM flags. And This flag
supported by this binding is PWM_POLARITY_INVERTED.

Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---

Changes in v2:
 - Remove unnecessary handle.

 arch/arm/boot/dts/exynos4.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sachin Kamat June 19, 2014, 6:07 a.m. UTC | #1
Hi Jaewon,

On Thu, Jun 19, 2014 at 7:33 AM, Jaewon Kim <jaewon02.kim@samsung.com> wrote:
> pwm-cells should be 3. Third cell is optional PWM flags. And This flag
> supported by this binding is PWM_POLARITY_INVERTED.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>
> Changes in v2:
>  - Remove unnecessary handle.
>
>  arch/arm/boot/dts/exynos4.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index b8ece4b..e118356 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -554,7 +554,7 @@
>                 interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
>                 clocks = <&clock CLK_PWM>;
>                 clock-names = "timers";
> -               #pwm-cells = <2>;
> +               #pwm-cells = <3>;
>                 status = "disabled";
>         };

I think I had already reviewed this patch. Anyway,
Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kim Kukjin June 23, 2014, 12:48 a.m. UTC | #2
Sachin Kamat wrote:
> 
> Hi Jaewon,
> 
> On Thu, Jun 19, 2014 at 7:33 AM, Jaewon Kim <jaewon02.kim@samsung.com> wrote:
> > pwm-cells should be 3. Third cell is optional PWM flags. And This flag
> > supported by this binding is PWM_POLARITY_INVERTED.
> >
> > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> > ---
> >
> > Changes in v2:
> >  - Remove unnecessary handle.
> >
> >  arch/arm/boot/dts/exynos4.dtsi |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> > index b8ece4b..e118356 100644
> > --- a/arch/arm/boot/dts/exynos4.dtsi
> > +++ b/arch/arm/boot/dts/exynos4.dtsi
> > @@ -554,7 +554,7 @@
> >                 interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
> >                 clocks = <&clock CLK_PWM>;
> >                 clock-names = "timers";
> > -               #pwm-cells = <2>;
> > +               #pwm-cells = <3>;
> >                 status = "disabled";
> >         };
> 
> I think I had already reviewed this patch. Anyway,
> Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>

Applied, thanks.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4b..e118356 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -554,7 +554,7 @@ 
 		interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
 		clocks = <&clock CLK_PWM>;
 		clock-names = "timers";
-		#pwm-cells = <2>;
+		#pwm-cells = <3>;
 		status = "disabled";
 	};