| Message ID | 1403761178-5371-2-git-send-email-sachin.kamat@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/26/2014 11:09 AM, Sachin Kamat wrote: > USB DWC3 driver on Exynos platforms does not work without its > corresponding phy driver. Hence it makes no sense to keep the > phy driver as user selectable. Instead select it from USB config > to make things easier for the end user. > While at it make the config depend on ARCH_EXYNOS5 instead of > ARCH_EXYNOS as this IP is available only on Exynos5 platforms. > > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > --- Reviewed-by: Tushar Behera <tushar.b@samsung.com> > drivers/phy/Kconfig | 8 +------- > drivers/usb/dwc3/Kconfig | 3 ++- > 2 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 7fe7ef5f1322..6be353c9dc4c 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -138,15 +138,9 @@ config PHY_EXYNOS5250_USB2 > bool > > config PHY_EXYNOS5_USBDRD > - tristate "Exynos5 SoC series USB DRD PHY driver" > - depends on ARCH_EXYNOS5 && OF > - depends on HAS_IOMEM > + tristate > select GENERIC_PHY > select MFD_SYSCON > - help > - Enable USB DRD PHY support for Exynos 5 SoC series. > - This driver provides PHY interface for USB 3.0 DRD controller > - present on Exynos5 SoC series. > > config PHY_XGENE > tristate "APM X-Gene 15Gbps PHY support" > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 261c3b428220..501477452ad8 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -55,7 +55,8 @@ config USB_DWC3_OMAP > > config USB_DWC3_EXYNOS > tristate "Samsung Exynos Platform" > - depends on ARCH_EXYNOS || COMPILE_TEST > + depends on ARCH_EXYNOS5 || COMPILE_TEST > + select PHY_EXYNOS5_USBDRD > default USB_DWC3 > help > Recent Exynos5 SoCs ship with one DesignWare Core USB3 IP inside, >
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 7fe7ef5f1322..6be353c9dc4c 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -138,15 +138,9 @@ config PHY_EXYNOS5250_USB2 bool config PHY_EXYNOS5_USBDRD - tristate "Exynos5 SoC series USB DRD PHY driver" - depends on ARCH_EXYNOS5 && OF - depends on HAS_IOMEM + tristate select GENERIC_PHY select MFD_SYSCON - help - Enable USB DRD PHY support for Exynos 5 SoC series. - This driver provides PHY interface for USB 3.0 DRD controller - present on Exynos5 SoC series. config PHY_XGENE tristate "APM X-Gene 15Gbps PHY support" diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 261c3b428220..501477452ad8 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -55,7 +55,8 @@ config USB_DWC3_OMAP config USB_DWC3_EXYNOS tristate "Samsung Exynos Platform" - depends on ARCH_EXYNOS || COMPILE_TEST + depends on ARCH_EXYNOS5 || COMPILE_TEST + select PHY_EXYNOS5_USBDRD default USB_DWC3 help Recent Exynos5 SoCs ship with one DesignWare Core USB3 IP inside,
USB DWC3 driver on Exynos platforms does not work without its corresponding phy driver. Hence it makes no sense to keep the phy driver as user selectable. Instead select it from USB config to make things easier for the end user. While at it make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS as this IP is available only on Exynos5 platforms. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Cc: Kishon Vijay Abraham I <kishon@ti.com> --- drivers/phy/Kconfig | 8 +------- drivers/usb/dwc3/Kconfig | 3 ++- 2 files changed, 3 insertions(+), 8 deletions(-)