From patchwork Fri Jul 4 10:33:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 4480481 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C2ED69F36A for ; Fri, 4 Jul 2014 10:36:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 09CA520412 for ; Fri, 4 Jul 2014 10:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B202C20225 for ; Fri, 4 Jul 2014 10:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754306AbaGDKgz (ORCPT ); Fri, 4 Jul 2014 06:36:55 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:61915 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754150AbaGDKgy (ORCPT ); Fri, 4 Jul 2014 06:36:54 -0400 Received: by mail-pa0-f42.google.com with SMTP id lj1so1839322pab.1 for ; Fri, 04 Jul 2014 03:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=qc8GVY9XQ3gy188xalGS/zJo5gsunW/9CjojZjwRbNo=; b=cg+4pVgfyX4nBdAL39jqhLWGmV/2gfp2YhVRjQ4PL84/naibO/YnEeXaVvjJ8ON12f eOvbfxyuLAtzZaXKVb2uh9z53aO2R28VNia+FfOOf42WM2bFYqHjf/MgZmm4YIDAULe9 oFCzJExKyH92XxGfD0hXaMY/okB2FrT4GuMtRfR1DBQ65BIsot1QfXDPUfy8KYD6IClJ qKTT8xxAozx910dzekzDVbzMEaERiv7Xbqho7Lwi5ONxmy8/KdQLyfoCBS9zuSAAHqDP NpyJ/srWoNJRvcQGhgnrUyYsTQGHQNAjd7LsrToFaqQaZo8CEnph1tFlInAmEg/2ZDXW eNAw== X-Received: by 10.68.133.163 with SMTP id pd3mr10039191pbb.166.1404470214034; Fri, 04 Jul 2014 03:36:54 -0700 (PDT) Received: from linaro.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id ph6sm8373181pdb.93.2014.07.04.03.36.49 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Jul 2014 03:36:53 -0700 (PDT) From: Tushar Behera To: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: kgene.kim@samsung.com, airlied@linux.ie, kyungmin.park@samsung.com, sw0312.kim@samsung.com, jy0922.shim@samsung.com, inki.dae@samsung.com, trblinux@gmail.com Subject: [PATCH] drm/exynos: fimd: Keep power enabled during fimd_bind Date: Fri, 4 Jul 2014 16:03:19 +0530 Message-Id: <1404469999-21147-1-git-send-email-tushar.b@samsung.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Under some conditions (when IOMMU is enabled), fimd_bind() accesses hardware registers and power-domain should be enabled during that time. fimd_bind --> fimd_mgr_initialize --> fimd_clear_channel If the power-domain is disabled by that time, we get a boot-time crash. It would be better to keep power-domain enabled explicitly. Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0180034 Internal error: : 1008 [#1] PREEMPT SMP ARM ... PC is at fimd_bind+0x84/0x134 LR is at component_bind_all+0xb4/0x1d8 Signed-off-by: Tushar Behera --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 33161ad..34275fb 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -888,11 +888,15 @@ static int fimd_bind(struct device *dev, struct device *master, void *data) struct fimd_context *ctx = fimd_manager.ctx; struct drm_device *drm_dev = data; + pm_runtime_get_sync(dev); + fimd_mgr_initialize(&fimd_manager, drm_dev); exynos_drm_crtc_create(&fimd_manager); if (ctx->display) exynos_drm_create_enc_conn(drm_dev, ctx->display); + pm_runtime_put_sync(dev); + return 0; }