Message ID | 1407231076-15506-1-git-send-email-zhaowei.yuan@samsung.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers | show |
Hi, On 08/05/2014 06:31 PM, Zhaowei Yuan wrote: > ctx->ctx should be released if the following allocation for ctx->shm > gets failed. > > Signed-off-by: Zhaowei Yuan <zhaowei.yuan@samsung.com> > --- > drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 1 + > 1 file changed, 1 insertion(+) > mode change 100644 => 100755 drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c It's wrong to change file permission, please don't make a same mistake. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c old mode 100644 new mode 100755 index 58ec7bb..dc00aea --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c @@ -228,6 +228,7 @@ static int s5p_mfc_alloc_instance_buffer_v5(struct s5p_mfc_ctx *ctx) ret = s5p_mfc_alloc_priv_buf(dev->mem_dev_l, &ctx->shm); if (ret) { mfc_err("Failed to allocate shared memory buffer\n"); + s5p_mfc_release_priv_buf(dev->mem_dev_l, &ctx->ctx); return ret; }
ctx->ctx should be released if the following allocation for ctx->shm gets failed. Signed-off-by: Zhaowei Yuan <zhaowei.yuan@samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 1 + 1 file changed, 1 insertion(+) mode change 100644 => 100755 drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html