From patchwork Fri Aug 15 12:40:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 4726931 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0B049C0338 for ; Fri, 15 Aug 2014 12:41:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 96616201EF for ; Fri, 15 Aug 2014 12:41:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EB09201F7 for ; Fri, 15 Aug 2014 12:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751132AbaHOMk0 (ORCPT ); Fri, 15 Aug 2014 08:40:26 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:43909 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbaHOMkY (ORCPT ); Fri, 15 Aug 2014 08:40:24 -0400 Received: by mail-wg0-f42.google.com with SMTP id l18so2195550wgh.13 for ; Fri, 15 Aug 2014 05:40:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gBF3DI8Kr7nlTUx035yYVvhrHHKpVhhinHm8Nhixiew=; b=bQgl4BdHH1u/OXGOcZ3l3iZKwz6wvu4lqgz0gKzh2J1Qixj1Co1NRWhnCmQqNjfXDS NoruHNiwvqx57aqHRs8QJ4JEJ9pzVIeYzFyTuf1cZelUvXzze82YR1AtHpmKWhGdExoY 6z40+eYfvjRSKwUvw0kvrgMy+J4UPM4vHTkGIhuDbuYkhMGWAPIuPxexJWp3wDqMq44v tPslad247osp9jxTfiEWQVJnPtV5sAZ1Na+Pr8RRVkjsmaHW+wDcvkv8UYIUVtCypyRC GSvJuBl4o9CW/3bOrzGAo/f1nAbF9Z0r3kfk0kKYYpY1AaeU3Nc+kxKGlf5eLkiqKlzz 2neQ== X-Gm-Message-State: ALoCoQnGgUkoOz+FU1hWKW16bnAl+34VH7Llg58A6pinWftkln0ecr9BuG1IiDMIvsDcHlV4Wudb X-Received: by 10.194.95.234 with SMTP id dn10mr20704126wjb.73.1408106422873; Fri, 15 Aug 2014 05:40:22 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id fr2sm6486559wib.7.2014.08.15.05.40.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Aug 2014 05:40:22 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kishon@ti.com, kgene.kim@samsung.com, maxime.ripard@free-electrons.com, linux-samsung-soc@vger.kernel.org Cc: peter.griffin@linaro.org, patches@linaro.org, lee.jones@linaro.org Subject: [PATCH 1/9] phy: phy-omap-control: Remove unncessary site specific OOM messages Date: Fri, 15 Aug 2014 13:40:08 +0100 Message-Id: <1408106416-19044-2-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> References: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin --- drivers/phy/phy-omap-control.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/phy-omap-control.c b/drivers/phy/phy-omap-control.c index 9487bf1..cb2f4d1 100644 --- a/drivers/phy/phy-omap-control.c +++ b/drivers/phy/phy-omap-control.c @@ -295,10 +295,8 @@ static int omap_control_phy_probe(struct platform_device *pdev) control_phy = devm_kzalloc(&pdev->dev, sizeof(*control_phy), GFP_KERNEL); - if (!control_phy) { - dev_err(&pdev->dev, "unable to alloc memory for control phy\n"); + if (!control_phy) return -ENOMEM; - } control_phy->dev = &pdev->dev; control_phy->type = *(enum omap_control_phy_type *)of_id->data;