From patchwork Fri Aug 15 12:40:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 4727061 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2E0C79F38D for ; Fri, 15 Aug 2014 12:42:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 55C69201ED for ; Fri, 15 Aug 2014 12:42:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B5B0201BC for ; Fri, 15 Aug 2014 12:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751221AbaHOMkb (ORCPT ); Fri, 15 Aug 2014 08:40:31 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:50199 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbaHOMk2 (ORCPT ); Fri, 15 Aug 2014 08:40:28 -0400 Received: by mail-wi0-f177.google.com with SMTP id ho1so767296wib.4 for ; Fri, 15 Aug 2014 05:40:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VMChPy6IKnlejcIhMrQ8d0R18OBqnlCCsJHUXxNomz0=; b=FIzpWaRVwoOfxEpUwuElLr8dK2rK6VtTWRq3mH6LLqu3KrQ3d+rwneCcqj6V8xV62v ewzPJKkT6/8E2vv/RG4wSIXH/SZnYqHzOwl5CA9HX6lahmaltzITfKzU/goQtvS+wEOj a2xKz/yZYZ9PcsvLXFstIz/I5G5aiiMQ8KgQiLmC5cYhbRcylvyPtqNjv9UjgyVL0NBP looqGVabV09gtcVCiS1clPZT2nPvRnHA5987DXmWOq2poF1hSdBCoixyVn79MVtv73vh 8tNXYLg+b8wWcUN0cy+7vNtz3HPfjTj5p3G032k+8s3rluYaKK2QHrHJv5jjd2TTwpOc IeWw== X-Gm-Message-State: ALoCoQkckUApQp2Yw8svFj8z4UnK0z7qo+Nr2jAuSI5h0uauFkdstKKacdz1quhgA0m+HFeuYEw9 X-Received: by 10.180.97.101 with SMTP id dz5mr8489164wib.52.1408106427096; Fri, 15 Aug 2014 05:40:27 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id fr2sm6486559wib.7.2014.08.15.05.40.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Aug 2014 05:40:26 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kishon@ti.com, kgene.kim@samsung.com, maxime.ripard@free-electrons.com, linux-samsung-soc@vger.kernel.org Cc: peter.griffin@linaro.org, patches@linaro.org, lee.jones@linaro.org Subject: [PATCH 3/9] phy: phy-omap-usb2: Remove unncessary site specific OOM messages Date: Fri, 15 Aug 2014 13:40:10 +0100 Message-Id: <1408106416-19044-4-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> References: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin --- drivers/phy/phy-omap-usb2.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c index 93d7835..51c6f92 100644 --- a/drivers/phy/phy-omap-usb2.c +++ b/drivers/phy/phy-omap-usb2.c @@ -212,16 +212,12 @@ static int omap_usb2_probe(struct platform_device *pdev) phy_data = (struct usb_phy_data *)of_id->data; phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); - if (!phy) { - dev_err(&pdev->dev, "unable to allocate memory for USB2 PHY\n"); + if (!phy) return -ENOMEM; - } otg = devm_kzalloc(&pdev->dev, sizeof(*otg), GFP_KERNEL); - if (!otg) { - dev_err(&pdev->dev, "unable to allocate memory for USB OTG\n"); + if (!otg) return -ENOMEM; - } phy->dev = &pdev->dev;