From patchwork Thu Oct 16 12:57:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 5091741 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BA53EC11AD for ; Thu, 16 Oct 2014 12:58:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EF5E72016C for ; Thu, 16 Oct 2014 12:58:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 238EA201EF for ; Thu, 16 Oct 2014 12:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445AbaJPM6k (ORCPT ); Thu, 16 Oct 2014 08:58:40 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:54147 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbaJPM6d (ORCPT ); Thu, 16 Oct 2014 08:58:33 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NDJ00BCLG663XB0@mailout3.w1.samsung.com>; Thu, 16 Oct 2014 14:01:18 +0100 (BST) X-AuditID: cbfec7f5-b7f776d000003e54-ec-543fc0f2165e Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id BE.EC.15956.2F0CF345; Thu, 16 Oct 2014 13:58:26 +0100 (BST) Received: from amdc1339.digital.local ([106.116.147.30]) by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NDJ00F34G17BB00@eusync2.samsung.com>; Thu, 16 Oct 2014 13:58:25 +0100 (BST) From: Marek Szyprowski To: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Kyungmin Park , Robert Baldyga , Paul Zimmerman , Krzysztof Kozlowski Subject: [PATCH 2/9] usb: dwc2/gadget: fix enumeration issues Date: Thu, 16 Oct 2014 14:57:58 +0200 Message-id: <1413464285-24172-3-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1413464285-24172-1-git-send-email-m.szyprowski@samsung.com> References: <1413464285-24172-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDJMWRmVeSWpSXmKPExsVy+t/xK7qfDtiHGNxZI2zx+oWhxdmmN+wW M87vY7JYtKyV2WLtkbvsFtunTGeyeHB4J7sDu0ffllWMHlv2f2b0+LxJLoA5issmJTUnsyy1 SN8ugSvjxJxzrAVd7BUz9j5ga2D8ytrFyMkhIWAi8bxvPRuELSZx4R6IzcUhJLCUUeJ6634W CKePSaK39zMTSBWbgKFE19susA4RAQeJJUvvgHUwC9xhlFi//xNYkbCArcSJ4/vBbBYBVYlJ B66BNfAKeEhcv7mUGWKdnMT/lyvAajgFPCV2bV4JFhcCqjl/dTrjBEbeBYwMqxhFU0uTC4qT 0nON9IoTc4tL89L1kvNzNzFCQujrDsalx6wOMQpwMCrx8GoE24cIsSaWFVfmHmKU4GBWEuFd NAkoxJuSWFmVWpQfX1Sak1p8iJGJg1OqgVGp9br6y1WGqrGW116rrPwd+YCdv1XHuMTmlcGx O9uFjLseOc52lWZwS3PafoX3uWe7uW2LpOT5zaW8R8KOvIhZePBT56oA4c+Fe/Z5S0assDPc fM7h3/nsYJsr93do3qrtffRr+v9bUzbLfZr37H5ypnHJKqfPazz/HP1r9+xZAKeQRtk50y1K LMUZiYZazEXFiQDFSXL8/wEAAA== Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Excessive debug messages might cause timing issues that prevent correct usb enumeration. This patch hides information about USB bus reset to let driver enumerate fast enough to avoid making host angry. This fixes endless enumeration and usb reset loop observed with some Linux hosts. Signed-off-by: Marek Szyprowski Reviewed-by: Felipe Balbi --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 119c8a3effc2..8870e38c1d82 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2333,7 +2333,7 @@ irq_retry: u32 usb_status = readl(hsotg->regs + GOTGCTL); - dev_info(hsotg->dev, "%s: USBRst\n", __func__); + dev_dbg(hsotg->dev, "%s: USBRst\n", __func__); dev_dbg(hsotg->dev, "GNPTXSTS=%08x\n", readl(hsotg->regs + GNPTXSTS));