| Message ID | 1413478133-2577-4-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Oct 16, 2014 at 06:48:49PM +0200, Javier Martinez Canillas wrote: > The only operating modes that are supported by the regulators in the > max77802 PMIC are Output ON (normal) and Output On in Low Power Mode. > OFF was wrongly counted as an operating mode while is only a regulator > status. Make clear in the code that OFF is not an operating mode. Applied, thanks.
diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802.c index dae2c1a..3abf99d 100644 --- a/drivers/regulator/max77802.c +++ b/drivers/regulator/max77802.c @@ -49,6 +49,7 @@ #define MAX77802_RAMP_RATE_MASK_4BIT 0xF0 #define MAX77802_RAMP_RATE_SHIFT_4BIT 4 +#define MAX77802_STATUS_OFF 0x0 #define MAX77802_OFF_PWRREQ 0x1 #define MAX77802_LP_PWRREQ 0x2 @@ -615,7 +616,7 @@ static int max77802_pmic_probe(struct platform_device *pdev) * the hardware reports OFF as the regulator operating mode. * Default to operating mode NORMAL in that case. */ - if (val == MAX77802_OPMODE_OFF) + if (val == MAX77802_STATUS_OFF) max77802->opmode[id] = MAX77802_OPMODE_NORMAL; else max77802->opmode[id] = val;
The only operating modes that are supported by the regulators in the max77802 PMIC are Output ON (normal) and Output On in Low Power Mode. OFF was wrongly counted as an operating mode while is only a regulator status. Make clear in the code that OFF is not an operating mode. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- Changes since v1: None drivers/regulator/max77802.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)